public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* Re: MUSB regression in 2.6.31-rc6
@ 2009-08-17 21:27 ewitcher
  2009-08-18  7:31 ` Jarkko Nikula
  0 siblings, 1 reply; 19+ messages in thread
From: ewitcher @ 2009-08-17 21:27 UTC (permalink / raw)
  To: Kalle Valo, Jarkko Nikula
  Cc: felipe.balbi-xNZwKgViW5gAvxtiuMwx3w, Gadiyar,Anand,
	Gupta,Ajay Kumar,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Hello,

The below referenced patch was helpful to me in resolving the

<3>twl4030_usb twl4030_usb: ldo init failed

error.

Examining the minicom.cap attachment, I can see that twl4030_usb  is initialized before regulator.  If you move the twl4030_usb initialization to after regulator, you should be ok.

[PATCH] USB:otg:twl4030-usb.c: mark .init as subsys_initcall_sync
http://marc.info/?l=linux-usb&m=124913041802639&w=2

I also included the aforementioned patch at the end of

 Re: [PATCH 10/10] OMAP3: update OMAP3 Beagle defconfig, v2
http://marc.info/?l=linux-omap&m=125038741913297&w=2

Regards,

Eric


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread
* MUSB regression in 2.6.31-rc6
@ 2009-08-15 14:43 Jarkko Nikula
       [not found] ` <20090815174352.c2883585.jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 19+ messages in thread
From: Jarkko Nikula @ 2009-08-15 14:43 UTC (permalink / raw)
  To: ajay.gupta; +Cc: linux-usb, linux-omap, Felipe Balbi

Hi

BeagleBoard stopped booting at 2.6.31-rc6 and it turned out that this
commit broke it:

commit e8e2ff462dd92693f29eb848f42d3eb720390d59
Author: Gupta, Ajay Kumar <ajay.gupta@ti.com>
Date:   Wed Jul 29 11:58:57 2009 +0530

    USB: musb: fix the nop registration for OMAP3EVM

While this is easy to fix for the Beagle with a patch below, I don't know
how many other OMAP boards there are which should be fixed as well.
Or would it be better to revert the patch itself for 2.6.31?


-- 
Jarkko

--- 
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 991ac9c..2ca0d44 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -30,6 +30,7 @@
 
 #include <linux/regulator/machine.h>
 #include <linux/i2c/twl4030.h>
+#include <linux/usb/otg.h>
 
 #include <mach/hardware.h>
 #include <asm/mach-types.h>
@@ -406,6 +407,10 @@ static void __init omap3_beagle_init(void)
 	/* REVISIT leave DVI powered down until it's needed ... */
 	gpio_direction_output(170, true);
 
+#ifdef CONFIG_NOP_USB_XCEIV
+	/* OMAP3EVM uses ISP1504 phy and so register nop transceiver */
+	usb_nop_xceiv_register();
+#endif
 	usb_musb_init();
 	omap3beagle_flash_init();
 }
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index 803adcb..e27ed96 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -13,6 +13,7 @@ config USB_MUSB_HDRC
 	select NOP_USB_XCEIV if ARCH_DAVINCI
 	select TWL4030_USB if MACH_OMAP_3430SDP
 	select NOP_USB_XCEIV if MACH_OMAP3EVM
+	select NOP_USB_XCEIV if MACH_OMAP3_BEAGLE
 	select USB_OTG_UTILS
 	tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
 	help

^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2009-08-18  7:30 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-17 21:27 MUSB regression in 2.6.31-rc6 ewitcher
2009-08-18  7:31 ` Jarkko Nikula
  -- strict thread matches above, loose matches on Subject: below --
2009-08-15 14:43 Jarkko Nikula
     [not found] ` <20090815174352.c2883585.jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-08-15 14:49   ` Gadiyar, Anand
     [not found]     ` <5A47E75E594F054BAF48C5E4FC4B92AB0305398E07-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-15 15:07       ` Jarkko Nikula
2009-08-15 17:40         ` Felipe Balbi
2009-08-16  3:47           ` Gupta, Ajay Kumar
     [not found]           ` <20090815174000.GA13164-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-08-16  7:44             ` Jarkko Nikula
2009-08-16  8:14               ` Koen Kooi
     [not found]               ` <20090816104415.e12a5e46.jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-08-16  8:25                 ` Felipe Balbi
2009-08-16  8:47                   ` Jarkko Nikula
2009-08-16  9:02                     ` Felipe Balbi
2009-08-16 13:07                 ` Gupta, Ajay Kumar
     [not found]                   ` <19F8576C6E063C45BE387C64729E739404322AA35B-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-08-16 13:13                     ` Felipe Balbi
2009-08-16 16:49                       ` Jarkko Nikula
2009-08-16 17:10                         ` Felipe Balbi
2009-08-16 17:43                           ` Jarkko Nikula
2009-08-16 21:52                             ` Felipe Balbi
2009-08-17 12:51               ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox