[PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6

[PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6

[Shilimkar, Santosh]

Kevin/Tony,

This patch series addresses the OMAP4430 boot up crash issues on the latest 2.6.31-rc6 kernel release.

On the latest mainline as well as linux-omap master (2.6.31-rc6), OMAP4 boot is crashing. This has broken after "[PATCH 00/14] OMAP PM fixes for .31-rc series" series got merged in.
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg14527.html
 
Two issues -
1. NULL pointer dereference in omap_serial_init()-
static struct omap_uart_state omap_uart[OMAP_MAX_NR_PORTS], has three instances populated and for OMAP4 macro OMAP_MAX_NR_PORTS=4. So at the fourth iteration, there is NULL pointer oops.
This was also related to the merge issue in the linux-next branch. 
http://lkml.org/lkml/2009/8/20/192

[PATCH 1/2] ARM: OMAP4: Fix NULL pointer dereference crash.

2. Console is not working because the uart platform data is not getting registered to kernel. Registration fails because of clock check failure in omap_serial_init(). As you aware the clock framework is still under review on mailing list. Hence below patch is necessary to fix the same.

[PATCH 2/2] ARM: OMAP4: Bypass the clock check.

Please review the same.

Thanks!!

Regards,
Santosh

[PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6

[Shilimkar, Santosh]

Russell,

On the mainline 2.6.31-rc6, OMAP4 boot is crashing. Also serial code in the linux-next branch isn't merge correctly and needs reworked patches. 

Can you please see if they are ok? 

This patch series addresses the OMAP4430 boot up crash issues on the latest 2.6.31-rc6 kernel release. They are generated against 2.6.31-rc6 
(commit= 6c30c53fd5ae6a99a23ad78e90c428d2c8ffb07f)
OMAP4 was broken after "[PATCH 00/14] OMAP PM fixes for .31-rc series" series got merged in.
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg14527.html
 
Two issues -
1. NULL pointer dereference in omap_serial_init()-
static struct omap_uart_state omap_uart[OMAP_MAX_NR_PORTS], has three instances populated and for OMAP4 macro OMAP_MAX_NR_PORTS=4. So at the fourth iteration, there is NULL pointer oops.
This was also related to the merge issue in the linux-next branch. 
http://lkml.org/lkml/2009/8/20/192

	[PATCH 1/2] ARM: OMAP4: Fix NULL pointer dereference crash.

2. Console is not working because the uart platform data is not getting registered to kernel. Registration fails because of clock check failure in omap_serial_init(). As you aware the clock framework is still under review on mailing list. Hence below patch is necessary to fix the same.

	[PATCH 2/2] ARM: OMAP4: Bypass the clock check.

Thanks !!

Regards,
Santosh

Re: [PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6

[Kevin Hilman]

"Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:

> Russell,
>
> On the mainline 2.6.31-rc6, OMAP4 boot is crashing. Also serial code in the linux-next branch isn't merge correctly and needs reworked patches. 
>
> Can you please see if they are ok? 

After the fix I suggested on patch 2/2, I'm OK with these.

Tony, should I pull these into my fixes queue, or do you want to merge
them directly.  We will need them in your for-next branch to resolve
the problems in linux-next.

Kevin

> This patch series addresses the OMAP4430 boot up crash issues on the latest 2.6.31-rc6 kernel release. They are generated against 2.6.31-rc6 
> (commit= 6c30c53fd5ae6a99a23ad78e90c428d2c8ffb07f)
> OMAP4 was broken after "[PATCH 00/14] OMAP PM fixes for .31-rc series" series got merged in.
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg14527.html
>  
> Two issues -
> 1. NULL pointer dereference in omap_serial_init()-
> static struct omap_uart_state omap_uart[OMAP_MAX_NR_PORTS], has three instances populated and for OMAP4 macro OMAP_MAX_NR_PORTS=4. So at the fourth iteration, there is NULL pointer oops.
> This was also related to the merge issue in the linux-next branch. 
> http://lkml.org/lkml/2009/8/20/192
>
> 	[PATCH 1/2] ARM: OMAP4: Fix NULL pointer dereference crash.
>
> 2. Console is not working because the uart platform data is not getting registered to kernel. Registration fails because of clock check failure in omap_serial_init(). As you aware the clock framework is still under review on mailing list. Hence below patch is necessary to fix the same.
>
> 	[PATCH 2/2] ARM: OMAP4: Bypass the clock check.
>
> Thanks !!
>
> Regards,
> Santosh

RE: [PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6

[Shilimkar, Santosh]

Thanks Kevin!!

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Friday, August 21, 2009 9:30 PM
> To: Shilimkar, Santosh
> Cc: Russell King; Tony Lindgren; linux-omap@vger.kernel.org; linux-arm-
> kernel@lists.arm.linux.org.uk
> Subject: Re: [PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6
> 
> "Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
> 
> > Russell,
> >
> > On the mainline 2.6.31-rc6, OMAP4 boot is crashing. Also serial code in
> the linux-next branch isn't merge correctly and needs reworked patches.
> >
> > Can you please see if they are ok?
> 
> After the fix I suggested on patch 2/2, I'm OK with these.
> 
> Tony, should I pull these into my fixes queue, or do you want to merge
> them directly.  We will need them in your for-next branch to resolve
> the problems in linux-next.
 I will submit new version with you comment.

Re: [PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6

[Tony Lindgren]

* Shilimkar, Santosh <santosh.shilimkar@ti.com> [090822 10:56]:
> Thanks Kevin!!
> 
> > -----Original Message-----
> > From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> > Sent: Friday, August 21, 2009 9:30 PM
> > To: Shilimkar, Santosh
> > Cc: Russell King; Tony Lindgren; linux-omap@vger.kernel.org; linux-arm-
> > kernel@lists.arm.linux.org.uk
> > Subject: Re: [PATCH 0/2] ARM: OMAP4: Boot up crash 2.6.31-rc6
> > 
> > "Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
> > 
> > > Russell,
> > >
> > > On the mainline 2.6.31-rc6, OMAP4 boot is crashing. Also serial code in
> > the linux-next branch isn't merge correctly and needs reworked patches.
> > >
> > > Can you please see if they are ok?
> > 
> > After the fix I suggested on patch 2/2, I'm OK with these.
> > 
> > Tony, should I pull these into my fixes queue, or do you want to merge
> > them directly.  We will need them in your for-next branch to resolve
> > the problems in linux-next.
>  I will submit new version with you comment.

See also Kevin's updated patch that removes the uart platform_data for omaps.

Tony