public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
	Kalle Valo <kalle.valo@iki.fi>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] OMAP: remove OMAP_TAG_UART
Date: Mon, 24 Aug 2009 17:19:23 +0300	[thread overview]
Message-ID: <20090824141922.GJ5165@atomide.com> (raw)
In-Reply-To: <87hbvxpdwq.fsf@deeprootsystems.com>

* Kevin Hilman <khilman@deeprootsystems.com> [090824 15:58]:
> Grazvydas Ignotas <notasas@gmail.com> writes:
> 
> > On Mon, Aug 24, 2009 at 10:41 AM, Kevin
> > Hilman<khilman@deeprootsystems.com> wrote:
> >> Kalle Valo <kalle.valo@iki.fi> writes:
> >>
> >>> Omap tags are deprecrated and convert all OMAP_TAG_UART cases to use
> >>> omap_uart_platform_data instead.
> >>>
> >>> Tested on rx51 and n8x0. Compile tested on omap_osk_5912.
> >>>
> >>> Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
> >>
> >> Rather than converting all the omap_uart_configs into platform_data.
> >> Any objections to just dropping the platform_data all together?
> >>
> >> This is only used for selecting which UARTs to enable at boot time,
> >> and all the board files simply enable all the UARTs.
> >
> > Pandora wasn't enabling all UARTs, as did some other off-tree board
> > (someone was posting UART questions on this list). This meant that
> > UART3 was appearing as ttyS0 here, and after this patch it will appear
> > as ttyS2, which means we will have to update our boot scripts. Not a
> > huge deal but I'd prefer retaining platform_data.
> 
> I think your boot scripts should be fixed.
> 
> Your problem actually points out another justification for my patch.
> Having all the UARTs enabled means that the ttyS* names will be
> consistent across multiple boards and result in much more portable
> userspace init.

Great, finally! The shifting of the UART numbering has been driving me
crazy for years now. Will buy Kevin a pint.

Tony

      reply	other threads:[~2009-08-24 14:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07  5:16 [PATCH 0/2] Remove omap serial tags Kalle Valo
2009-08-07  5:16 ` [PATCH 1/2] OMAP: remove OMAP_TAG_SERIAL_CONSOLE Kalle Valo
2009-08-10 15:46   ` [APPLIED] " Tony Lindgren
2009-08-07  5:16 ` [PATCH 2/2] OMAP: remove OMAP_TAG_UART Kalle Valo
2009-08-07  5:40   ` Pandita, Vikram
2009-08-07  6:03     ` Kalle Valo
2009-08-07  9:26       ` Grazvydas Ignotas
2009-08-07 13:27       ` Roger Quadros
2009-08-07 13:29         ` Pandita, Vikram
2009-08-10 15:49   ` [APPLIED] " Tony Lindgren
     [not found]   ` <87k50tslp1.fsf@deeprootsystems.com>
2009-08-24 12:54     ` Grazvydas Ignotas
2009-08-24 12:57       ` Kevin Hilman
2009-08-24 14:19         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090824141922.GJ5165@atomide.com \
    --to=tony@atomide.com \
    --cc=kalle.valo@iki.fi \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=notasas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox