From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] OMAP: remove OMAP_TAG_UART Date: Mon, 24 Aug 2009 17:19:23 +0300 Message-ID: <20090824141922.GJ5165@atomide.com> References: <20090807051516.4787.36125.stgit@tikku> <20090807051650.4787.84433.stgit@tikku> <87k50tslp1.fsf@deeprootsystems.com> <6ed0b2680908240554m7e7b7fc3m95ec28d7223cb85e@mail.gmail.com> <87hbvxpdwq.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:49464 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752487AbZHXOT0 (ORCPT ); Mon, 24 Aug 2009 10:19:26 -0400 Content-Disposition: inline In-Reply-To: <87hbvxpdwq.fsf@deeprootsystems.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Grazvydas Ignotas , Kalle Valo , linux-omap@vger.kernel.org * Kevin Hilman [090824 15:58]: > Grazvydas Ignotas writes: > > > On Mon, Aug 24, 2009 at 10:41 AM, Kevin > > Hilman wrote: > >> Kalle Valo writes: > >> > >>> Omap tags are deprecrated and convert all OMAP_TAG_UART cases to use > >>> omap_uart_platform_data instead. > >>> > >>> Tested on rx51 and n8x0. Compile tested on omap_osk_5912. > >>> > >>> Signed-off-by: Kalle Valo > >> > >> Rather than converting all the omap_uart_configs into platform_data. > >> Any objections to just dropping the platform_data all together? > >> > >> This is only used for selecting which UARTs to enable at boot time, > >> and all the board files simply enable all the UARTs. > > > > Pandora wasn't enabling all UARTs, as did some other off-tree board > > (someone was posting UART questions on this list). This meant that > > UART3 was appearing as ttyS0 here, and after this patch it will appear > > as ttyS2, which means we will have to update our boot scripts. Not a > > huge deal but I'd prefer retaining platform_data. > > I think your boot scripts should be fixed. > > Your problem actually points out another justification for my patch. > Having all the UARTs enabled means that the ttyS* names will be > consistent across multiple boards and result in much more portable > userspace init. Great, finally! The shifting of the UART numbering has been driving me crazy for years now. Will buy Kevin a pint. Tony