[PATCH] OMAP3: Zoom2: provide default MTD partitions

[PATCH] OMAP3: Zoom2: provide default MTD partitions

[Maxime Petazzoni]

This change introduces default MTD partitions for the Zoom-II board
NAND, inspired by the OMAP3 Beagle partitions and the OMAP3 Zoom2
partitions defined in OmapZoom.org's OMAP kernel.

The size of the U-Boot environment partition was increased to 1MB, as
the previously smaller partition couldn't contain the U-Boot environment
correctly (erasing the next partition would erase the U-Boot env as
well).

Finally, the "system" partition gets an increased size of 256MB to take
advantage of the size of the flash on the Zoom-II board.

Signed-off-by: Maxime Petazzoni <mpetazzoni@mvista.com>
---
 arch/arm/mach-omap2/board-zoom2.c |   86 +++++++++++++++++++++++++++++++++++++
 1 files changed, 86 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
index 4d295d5..ce5a4d8 100644
--- a/arch/arm/mach-omap2/board-zoom2.c
+++ b/arch/arm/mach-omap2/board-zoom2.c
@@ -16,16 +16,101 @@
 #include <linux/gpio.h>
 #include <linux/i2c/twl4030.h>
 #include <linux/regulator/machine.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/partitions.h>
+#include <linux/mtd/nand.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 
 #include <mach/common.h>
+#include <mach/nand.h>
 #include <mach/usb.h>
 #include <mach/keypad.h>
 
 #include "mmc-twl4030.h"
 
+#define LDP3430_NAND_CS	0
+#define GPMC_CS0_BASE	0x60
+#define GPMC_CS_SIZE	0x30
+
+static struct mtd_partition zoom2_nand_partitions[] = {
+	{
+		.name		= "X-Loader-NAND",
+		.offset		= 0,
+		.size		= 4 * (64 * 2048),	/* 512kB */
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "U-Boot-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x80000 */
+		.size		= 4 * (64 * 2048),	/* 512kB */
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "Boot Env-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x100000 */
+		.size		= 8 * (64 * 2048),	/* 1MB */
+	},
+	{
+		.name		= "Kernel-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x200000 */
+		.size		= 32 * (64 * 2048),	/* 4MB */
+	},
+	{
+		.name		= "system",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x600000 */
+		.size		= 2048 * (64 * 2048),	/* 256MB */
+	},
+	{
+		.name		= "userdata",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x10600000 */
+		.size		= 512 * (64 * 2048),	/* 64MB */
+	},
+	{
+		.name		= "cache",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x14600000 */
+		.size		= 512 * (64 * 2048),	/* 64MB */
+	},
+};
+
+/* NAND chip access: 16 bit */
+static struct omap_nand_platform_data zoom2_nand_data = {
+	.parts		= zoom2_nand_partitions,
+	.nr_parts	= ARRAY_SIZE(zoom2_nand_partitions),
+	.nand_setup	= NULL,
+	.dma_channel	= -1,		/* disable DMA in OMAP NAND driver */
+	.dev_ready	= NULL,
+};
+
+static struct resource zoom2_nand_resource = {
+	.flags		= IORESOURCE_MEM,
+};
+
+static struct platform_device zoom2_nand_device = {
+	.name		= "omap2-nand",
+	.id		= 0,
+	.dev		= {
+		.platform_data = &zoom2_nand_data,
+	},
+	.num_resources	= 1,
+	.resource	= &zoom2_nand_resource,
+};
+
+static void __init zoom2_flash_init(void)
+{
+	u8 nandcs = LDP3430_NAND_CS;
+	u32 gpmc_base_add = OMAP34XX_GPMC_VIRT;
+
+	zoom2_nand_data.cs = nandcs;
+	zoom2_nand_data.gpmc_cs_baseaddr = (void *)(gpmc_base_add +
+			GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
+	zoom2_nand_data.gpmc_baseaddr = (void *) (gpmc_base_add);
+
+	if (platform_device_register(&zoom2_nand_device) < 0)
+		printk(KERN_ERR "Unable to register NAND device!\n");
+}
+
 /* Zoom2 has Qwerty keyboard*/
 static int zoom2_twl4030_keymap[] = {
 	KEY(0, 0, KEY_E),
@@ -271,6 +356,7 @@ static void __init omap_zoom2_init(void)
 	omap_serial_init(&zoom2_uart_config);
 	omap_zoom2_debugboard_init();
 	usb_musb_init();
+	zoom2_flash_init();
 }
 
 static void __init omap_zoom2_map_io(void)
-- 
1.6.3.3.210.g29cb3

RE: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[Pandita, Vikram]

[-- Attachment #1: Type: text/plain, Size: 5438 bytes --]

Petazzoni/Vimal

>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Maxime
>Petazzoni
>Sent: Thursday, August 27, 2009 7:00 AM
>To: linux-omap@vger.kernel.org
>Subject: [PATCH] OMAP3: Zoom2: provide default MTD partitions
>
>This change introduces default MTD partitions for the Zoom-II board
>NAND, inspired by the OMAP3 Beagle partitions and the OMAP3 Zoom2
>partitions defined in OmapZoom.org's OMAP kernel.

Thanks for putting this together for zoom2, however I NAK for now.

Why?

I know of an implementation by Vimal Singh that introduces a common flash file for Zoom1 and Zoom2.
There is reuse of code there.

I have attached the patch by Vimal here (in-lining would be difficult)

Please discuss and get a converged approach on handling NAND partitions on Zoom1 and Zoom2.

Also the Systerm/User/Cache partition definitions are more from Android perspective.

Given that each system may have a different NAND partition requirement, 
have you looked at bootargs passing the MTD partition info: Eg: 

mtdparts=omap2-nand.0:512k@0(xloader),\
1536k@512k(bootloader),\
29m@2m(kernel),\
160m@32m(system),\
32m@192m(userdata),\
32m@224m(cache)


Lets discuss the final approach on this list and try to close this soon.

Thnx

>
>The size of the U-Boot environment partition was increased to 1MB, as
>the previously smaller partition couldn't contain the U-Boot environment
>correctly (erasing the next partition would erase the U-Boot env as
>well).
>
>Finally, the "system" partition gets an increased size of 256MB to take
>advantage of the size of the flash on the Zoom-II board.
>
>Signed-off-by: Maxime Petazzoni <mpetazzoni@mvista.com>
>---
> arch/arm/mach-omap2/board-zoom2.c |   86 +++++++++++++++++++++++++++++++++++++
> 1 files changed, 86 insertions(+), 0 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
>index 4d295d5..ce5a4d8 100644
>--- a/arch/arm/mach-omap2/board-zoom2.c
>+++ b/arch/arm/mach-omap2/board-zoom2.c
>@@ -16,16 +16,101 @@
> #include <linux/gpio.h>
> #include <linux/i2c/twl4030.h>
> #include <linux/regulator/machine.h>
>+#include <linux/mtd/mtd.h>
>+#include <linux/mtd/partitions.h>
>+#include <linux/mtd/nand.h>
>
> #include <asm/mach-types.h>
> #include <asm/mach/arch.h>
>
> #include <mach/common.h>
>+#include <mach/nand.h>
> #include <mach/usb.h>
> #include <mach/keypad.h>
>
> #include "mmc-twl4030.h"
>
>+#define LDP3430_NAND_CS	0
>+#define GPMC_CS0_BASE	0x60
>+#define GPMC_CS_SIZE	0x30
>+
>+static struct mtd_partition zoom2_nand_partitions[] = {
>+	{
>+		.name		= "X-Loader-NAND",
>+		.offset		= 0,
>+		.size		= 4 * (64 * 2048),	/* 512kB */
>+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
>+	},
>+	{
>+		.name		= "U-Boot-NAND",
>+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x80000 */
>+		.size		= 4 * (64 * 2048),	/* 512kB */
>+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
>+	},
>+	{
>+		.name		= "Boot Env-NAND",
>+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x100000 */
>+		.size		= 8 * (64 * 2048),	/* 1MB */
>+	},
>+	{
>+		.name		= "Kernel-NAND",
>+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x200000 */
>+		.size		= 32 * (64 * 2048),	/* 4MB */
>+	},
>+	{
>+		.name		= "system",
>+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x600000 */
>+		.size		= 2048 * (64 * 2048),	/* 256MB */
>+	},
>+	{
>+		.name		= "userdata",
>+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x10600000 */
>+		.size		= 512 * (64 * 2048),	/* 64MB */
>+	},
>+	{
>+		.name		= "cache",
>+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x14600000 */
>+		.size		= 512 * (64 * 2048),	/* 64MB */
>+	},
>+};
>+
>+/* NAND chip access: 16 bit */
>+static struct omap_nand_platform_data zoom2_nand_data = {
>+	.parts		= zoom2_nand_partitions,
>+	.nr_parts	= ARRAY_SIZE(zoom2_nand_partitions),
>+	.nand_setup	= NULL,
>+	.dma_channel	= -1,		/* disable DMA in OMAP NAND driver */
>+	.dev_ready	= NULL,
>+};
>+
>+static struct resource zoom2_nand_resource = {
>+	.flags		= IORESOURCE_MEM,
>+};
>+
>+static struct platform_device zoom2_nand_device = {
>+	.name		= "omap2-nand",
>+	.id		= 0,
>+	.dev		= {
>+		.platform_data = &zoom2_nand_data,
>+	},
>+	.num_resources	= 1,
>+	.resource	= &zoom2_nand_resource,
>+};
>+
>+static void __init zoom2_flash_init(void)
>+{
>+	u8 nandcs = LDP3430_NAND_CS;
>+	u32 gpmc_base_add = OMAP34XX_GPMC_VIRT;
>+
>+	zoom2_nand_data.cs = nandcs;
>+	zoom2_nand_data.gpmc_cs_baseaddr = (void *)(gpmc_base_add +
>+			GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
>+	zoom2_nand_data.gpmc_baseaddr = (void *) (gpmc_base_add);
>+
>+	if (platform_device_register(&zoom2_nand_device) < 0)
>+		printk(KERN_ERR "Unable to register NAND device!\n");
>+}
>+
> /* Zoom2 has Qwerty keyboard*/
> static int zoom2_twl4030_keymap[] = {
> 	KEY(0, 0, KEY_E),
>@@ -271,6 +356,7 @@ static void __init omap_zoom2_init(void)
> 	omap_serial_init(&zoom2_uart_config);
> 	omap_zoom2_debugboard_init();
> 	usb_musb_init();
>+	zoom2_flash_init();
> }
>
> static void __init omap_zoom2_map_io(void)
>--
>1.6.3.3.210.g29cb3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: add_nand_support_zoom2.patch --]
[-- Type: application/octet-stream, Size: 11067 bytes --]

---
 arch/arm/mach-omap2/Makefile                |    2 
 arch/arm/mach-omap2/board-ldp-flash.c       |  195 ++++++++++++++++++++++++++++
 arch/arm/mach-omap2/board-ldp.c             |    2 
 arch/arm/mach-omap2/board-zoom2.c           |    2 
 arch/arm/plat-omap/include/mach/board-ldp.h |   36 +++++
 arch/arm/plat-omap/include/mach/gpmc.h      |    2 
 arch/arm/plat-omap/include/mach/nand.h      |    1 
 7 files changed, 240 insertions(+)

Index: kernel-omap3/arch/arm/mach-omap2/Makefile
===================================================================
--- kernel-omap3.orig/arch/arm/mach-omap2/Makefile	2009-08-25 19:48:39.000000000 +0530
+++ kernel-omap3/arch/arm/mach-omap2/Makefile	2009-08-25 19:52:26.000000000 +0530
@@ -55,6 +55,7 @@
 obj-$(CONFIG_MACH_OMAP3_BEAGLE)		+= board-omap3beagle.o \
 					   mmc-twl4030.o
 obj-$(CONFIG_MACH_OMAP_LDP)		+= board-ldp.o \
+					   board-ldp-flash.o \
 					   mmc-twl4030.o \
 					   board-ldp-camera.o
 obj-$(CONFIG_MACH_OVERO)		+= board-overo.o \
@@ -71,6 +72,7 @@
 					   board-rx51-peripherals.o \
 					   mmc-twl4030.o
 obj-$(CONFIG_MACH_OMAP_ZOOM2)		+= board-zoom2.o \
+					   board-ldp-flash.o \
 					   mmc-twl4030.o \
 					   board-zoom-debugboard.o
 
Index: kernel-omap3/arch/arm/mach-omap2/board-ldp-flash.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ kernel-omap3/arch/arm/mach-omap2/board-ldp-flash.c	2009-08-25 19:50:05.000000000 +0530
@@ -0,0 +1,195 @@
+/*
+ * linux/arch/arm/mach-omap2/board-ldp-flash.c
+ *
+ * Copyright (C) 2008 Texas Instruments Inc.
+ *
+ * Modified from mach-omap2/board-2430sdp-flash.c
+ * Author: Rohit Choraria <rohitkc@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/delay.h>
+#include <linux/platform_device.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/partitions.h>
+#include <linux/mtd/nand.h>
+#include <linux/types.h>
+#include <linux/io.h>
+
+#include <asm/mach/flash.h>
+#include <mach/board.h>
+#include <mach/gpmc.h>
+#include <mach/nand.h>
+
+#include <mach/board-ldp.h>
+
+#define NAND_CMD_UNLOCK1	0x23
+#define NAND_CMD_UNLOCK2	0x24
+/**
+ * @brief platform specific unlock function
+ *
+ * @param mtd - mtd info
+ * @param ofs - offset to start unlock from
+ * @param len - length to unlock
+ *
+ * @return - unlock status
+ */
+static int omap_ldp_nand_unlock(struct mtd_info *mtd, loff_t ofs, size_t len)
+{
+	int ret = 0;
+	int chipnr;
+	int status;
+	unsigned long page;
+	struct nand_chip *this = mtd->priv;
+	printk(KERN_INFO "nand_unlock: start: %08x, length: %d!\n",
+			(int)ofs, (int)len);
+
+	/* select the NAND device */
+	chipnr = (int)(ofs >> this->chip_shift);
+	this->select_chip(mtd, chipnr);
+	/* check the WP bit */
+	this->cmdfunc(mtd, NAND_CMD_STATUS, -1, -1);
+	if ((this->read_byte(mtd) & 0x80) == 0) {
+		printk(KERN_ERR "nand_unlock: Device is write protected!\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	if ((ofs & (mtd->writesize - 1)) != 0) {
+		printk(KERN_ERR "nand_unlock: Start address must be"
+				"beginning of nand page!\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	if (len == 0 || (len & (mtd->writesize - 1)) != 0) {
+		printk(KERN_ERR "nand_unlock: Length must be a multiple of "
+				"nand page size!\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	/* submit address of first page to unlock */
+	page = (unsigned long)(ofs >> this->page_shift);
+	this->cmdfunc(mtd, NAND_CMD_UNLOCK1, -1, page & this->pagemask);
+
+	/* submit ADDRESS of LAST page to unlock */
+	page += (unsigned long)((ofs + len) >> this->page_shift) ;
+	this->cmdfunc(mtd, NAND_CMD_UNLOCK2, -1, page & this->pagemask);
+
+	/* call wait ready function */
+	status = this->waitfunc(mtd, this);
+	udelay(1000);
+	/* see if device thinks it succeeded */
+	if (status & 0x01) {
+		/* there was an error */
+		printk(KERN_ERR "nand_unlock: error status =0x%08x ", status);
+		ret = -EIO;
+		goto out;
+	}
+
+ out:
+	/* de-select the NAND device */
+	this->select_chip(mtd, -1);
+	return ret;
+}
+
+static struct mtd_partition ldp_nand_partitions[] = {
+	/* All the partition sizes are listed in terms of NAND block size */
+	{
+		.name		= "X-Loader-NAND",
+		.offset		= 0,
+		.size		= 4 * (64 * 2048),	/* 512KB, 0x80000 */
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "U-Boot-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x80000 */
+		.size		= 10 * (64 * 2048),	/* 1.25MB, 0x140000 */
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "Boot Env-NAND",
+		.offset		= MTDPART_OFS_APPEND,   /* Offset = 0x1c0000 */
+		.size		= 2 * (64 * 2048),	/* 256KB, 0x40000 */
+	},
+	{
+		.name		= "Kernel-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x0200000*/
+		.size		= 240 * (64 * 2048),	/* 30M, 0x1E00000 */
+	},
+#ifdef CONFIG_MACH_OMAP_ZOOM2
+	{
+		.name		= "system",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x2000000 */
+		.size		= 1280 * (64 * 2048),   /* 160M, 0xA000000 */
+	},
+	{
+		.name		= "userdata",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0xC000000 */
+		.size		= 256 * (64 * 2048),	/* 32M, 0x2000000 */
+ 	},
+	{
+		.name		= "cache",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0xE000000 */
+		.size		= 256 * (64 * 2048),	/* 32M, 0x2000000 */
+ 	},
+#else
+	{
+		.name		= "File System - NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x2000000 */
+		.size		= MTDPART_SIZ_FULL,	/* 96MB, 0x6000000 */
+	},
+#endif
+};
+
+/* NAND chip access: 16 bit */
+static struct omap_nand_platform_data ldp_nand_data = {
+	.parts		= ldp_nand_partitions,
+	.nr_parts	= ARRAY_SIZE(ldp_nand_partitions),
+	.nand_setup	= NULL,
+	.dma_channel	= -1,		/* disable DMA in OMAP NAND driver */
+	.dev_ready	= NULL,
+	.unlock		= omap_ldp_nand_unlock,
+};
+
+static struct resource ldp_nand_resource = {
+	.flags		= IORESOURCE_MEM,
+};
+
+static struct platform_device ldp_nand_device = {
+	.name		= "omap2-nand",
+	.id		= 0,
+	.dev		= {
+	.platform_data	= &ldp_nand_data,
+	},
+	.num_resources	= 1,
+	.resource	= &ldp_nand_resource,
+};
+
+/**
+ * ldp430_flash_init - Identify devices connected to GPMC and register.
+ *
+ * @return - void.
+ */
+void __init ldp_flash_init(void)
+{
+	u8 nandcs = GPMC_CS_NUM + 1;
+	u32 gpmc_base_add = OMAP34XX_GPMC_VIRT;
+
+	/* pop nand part */
+	nandcs = LDP3430_NAND_CS;
+
+	ldp_nand_data.cs = nandcs;
+	ldp_nand_data.gpmc_cs_baseaddr = (void *)(gpmc_base_add +
+					GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
+	ldp_nand_data.gpmc_baseaddr = (void *) (gpmc_base_add);
+
+	if (platform_device_register(&ldp_nand_device) < 0)
+		printk(KERN_ERR "Unable to register NAND device\n");
+}
+
Index: kernel-omap3/arch/arm/mach-omap2/board-ldp.c
===================================================================
--- kernel-omap3.orig/arch/arm/mach-omap2/board-ldp.c	2009-08-25 19:48:39.000000000 +0530
+++ kernel-omap3/arch/arm/mach-omap2/board-ldp.c	2009-08-25 19:50:05.000000000 +0530
@@ -42,6 +42,7 @@
 #include <mach/control.h>
 #include <mach/usb.h>
 #include <mach/keypad.h>
+#include <mach/board-ldp.h>
 
 #include "mmc-twl4030.h"
 
@@ -404,6 +405,7 @@
 	ads7846_dev_init();
 	omap_serial_init(&ldp_uart_config);
 	usb_musb_init();
+	ldp_flash_init();
 
 	twl4030_mmc_init(mmc);
 	/* link regulators to MMC adapters */
Index: kernel-omap3/arch/arm/mach-omap2/board-zoom2.c
===================================================================
--- kernel-omap3.orig/arch/arm/mach-omap2/board-zoom2.c	2009-08-25 19:48:39.000000000 +0530
+++ kernel-omap3/arch/arm/mach-omap2/board-zoom2.c	2009-08-25 19:50:05.000000000 +0530
@@ -22,6 +22,7 @@
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
+#include <mach/board-ldp.h>
 #include <mach/common.h>
 #include <mach/usb.h>
 #include <mach/keypad.h>
@@ -277,6 +278,7 @@
 	omap_serial_init(&zoom2_uart_config);
 	omap_zoom2_debugboard_init();
 	usb_musb_init();
+	ldp_flash_init();
 }
 
 static struct map_desc zoom2_io_desc[] __initdata = {
Index: kernel-omap3/arch/arm/plat-omap/include/mach/board-ldp.h
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ kernel-omap3/arch/arm/plat-omap/include/mach/board-ldp.h	2009-08-25 19:50:05.000000000 +0530
@@ -0,0 +1,36 @@
+/*
+ * arch/arm/plat-omap/include/mach/board-ldp.h
+ *
+ * Hardware definitions for TI OMAP3 LDP.
+ *
+ * Copyright (C) 2008 Texas Instruments Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
+ * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
+ * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __ASM_ARCH_OMAP_LDP_H
+#define __ASM_ARCH_OMAP_LDP_H
+
+extern void ldp_flash_init(void);
+
+#define LDP3430_NAND_CS               0
+
+#endif /* __ASM_ARCH_OMAP_LDP_H */
Index: kernel-omap3/arch/arm/plat-omap/include/mach/gpmc.h
===================================================================
--- kernel-omap3.orig/arch/arm/plat-omap/include/mach/gpmc.h	2009-08-25 19:57:35.000000000 +0530
+++ kernel-omap3/arch/arm/plat-omap/include/mach/gpmc.h	2009-08-25 19:58:24.000000000 +0530
@@ -27,6 +27,8 @@
 
 #define GPMC_CONFIG		0x50
 #define GPMC_STATUS		0x54
+#define GPMC_CS0_BASE		0x60
+#define GPMC_CS_SIZE		0x30
 
 #define GPMC_CONFIG1_WRAPBURST_SUPP     (1 << 31)
 #define GPMC_CONFIG1_READMULTIPLE_SUPP  (1 << 30)
Index: kernel-omap3/arch/arm/plat-omap/include/mach/nand.h
===================================================================
--- kernel-omap3.orig/arch/arm/plat-omap/include/mach/nand.h	2009-08-25 19:48:39.000000000 +0530
+++ kernel-omap3/arch/arm/plat-omap/include/mach/nand.h	2009-08-25 19:50:05.000000000 +0530
@@ -18,6 +18,7 @@
 	int			nr_parts;
 	int			(*nand_setup)(void __iomem *);
 	int			(*dev_ready)(struct omap_nand_platform_data *);
+	int			(*unlock)(struct mtd_info *, loff_t, size_t);
 	int			dma_channel;
 	void __iomem		*gpmc_cs_baseaddr;
 	void __iomem		*gpmc_baseaddr;

Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[vimal singh]

[-- Attachment #1: Type: text/plain, Size: 6749 bytes --]

Hi,

On Thu, Aug 27, 2009 at 7:16 PM, Pandita, Vikram<vikram.pandita@ti.com> wrote:
> Petazzoni/Vimal
>
>>-----Original Message-----
>>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Maxime
>>Petazzoni
>>Sent: Thursday, August 27, 2009 7:00 AM
>>To: linux-omap@vger.kernel.org
>>Subject: [PATCH] OMAP3: Zoom2: provide default MTD partitions
>>
>>This change introduces default MTD partitions for the Zoom-II board
>>NAND, inspired by the OMAP3 Beagle partitions and the OMAP3 Zoom2
>>partitions defined in OmapZoom.org's OMAP kernel.
>
> Thanks for putting this together for zoom2, however I NAK for now.
>
> Why?
>
> I know of an implementation by Vimal Singh that introduces a common flash file for Zoom1 and Zoom2.
> There is reuse of code there.
>
> I have attached the patch by Vimal here (in-lining would be difficult)

I am attaching an updated patch, which is prepared on top of the patch
which I submitted for flash supports for OMAP2/3 SDP board:
http://marc.info/?l=linux-omap&m=125065707704826&w=2

-vimal

>
> Please discuss and get a converged approach on handling NAND partitions on Zoom1 and Zoom2.
>
> Also the Systerm/User/Cache partition definitions are more from Android perspective.
>
> Given that each system may have a different NAND partition requirement,
> have you looked at bootargs passing the MTD partition info: Eg:
>
> mtdparts=omap2-nand.0:512k@0(xloader),\
> 1536k@512k(bootloader),\
> 29m@2m(kernel),\
> 160m@32m(system),\
> 32m@192m(userdata),\
> 32m@224m(cache)
>
>
> Lets discuss the final approach on this list and try to close this soon.
>
> Thnx
>
>>
>>The size of the U-Boot environment partition was increased to 1MB, as
>>the previously smaller partition couldn't contain the U-Boot environment
>>correctly (erasing the next partition would erase the U-Boot env as
>>well).
>>
>>Finally, the "system" partition gets an increased size of 256MB to take
>>advantage of the size of the flash on the Zoom-II board.
>>
>>Signed-off-by: Maxime Petazzoni <mpetazzoni@mvista.com>
>>---
>> arch/arm/mach-omap2/board-zoom2.c |   86 +++++++++++++++++++++++++++++++++++++
>> 1 files changed, 86 insertions(+), 0 deletions(-)
>>
>>diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
>>index 4d295d5..ce5a4d8 100644
>>--- a/arch/arm/mach-omap2/board-zoom2.c
>>+++ b/arch/arm/mach-omap2/board-zoom2.c
>>@@ -16,16 +16,101 @@
>> #include <linux/gpio.h>
>> #include <linux/i2c/twl4030.h>
>> #include <linux/regulator/machine.h>
>>+#include <linux/mtd/mtd.h>
>>+#include <linux/mtd/partitions.h>
>>+#include <linux/mtd/nand.h>
>>
>> #include <asm/mach-types.h>
>> #include <asm/mach/arch.h>
>>
>> #include <mach/common.h>
>>+#include <mach/nand.h>
>> #include <mach/usb.h>
>> #include <mach/keypad.h>
>>
>> #include "mmc-twl4030.h"
>>
>>+#define LDP3430_NAND_CS       0
>>+#define GPMC_CS0_BASE 0x60
>>+#define GPMC_CS_SIZE  0x30
>>+
>>+static struct mtd_partition zoom2_nand_partitions[] = {
>>+      {
>>+              .name           = "X-Loader-NAND",
>>+              .offset         = 0,
>>+              .size           = 4 * (64 * 2048),      /* 512kB */
>>+              .mask_flags     = MTD_WRITEABLE,        /* force read-only */
>>+      },
>>+      {
>>+              .name           = "U-Boot-NAND",
>>+              .offset         = MTDPART_OFS_APPEND,   /* Offset = 0x80000 */
>>+              .size           = 4 * (64 * 2048),      /* 512kB */
>>+              .mask_flags     = MTD_WRITEABLE,        /* force read-only */
>>+      },
>>+      {
>>+              .name           = "Boot Env-NAND",
>>+              .offset         = MTDPART_OFS_APPEND,   /* Offset = 0x100000 */
>>+              .size           = 8 * (64 * 2048),      /* 1MB */
>>+      },
>>+      {
>>+              .name           = "Kernel-NAND",
>>+              .offset         = MTDPART_OFS_APPEND,   /* Offset = 0x200000 */
>>+              .size           = 32 * (64 * 2048),     /* 4MB */
>>+      },
>>+      {
>>+              .name           = "system",
>>+              .offset         = MTDPART_OFS_APPEND,   /* Offset = 0x600000 */
>>+              .size           = 2048 * (64 * 2048),   /* 256MB */
>>+      },
>>+      {
>>+              .name           = "userdata",
>>+              .offset         = MTDPART_OFS_APPEND,   /* Offset = 0x10600000 */
>>+              .size           = 512 * (64 * 2048),    /* 64MB */
>>+      },
>>+      {
>>+              .name           = "cache",
>>+              .offset         = MTDPART_OFS_APPEND,   /* Offset = 0x14600000 */
>>+              .size           = 512 * (64 * 2048),    /* 64MB */
>>+      },
>>+};
>>+
>>+/* NAND chip access: 16 bit */
>>+static struct omap_nand_platform_data zoom2_nand_data = {
>>+      .parts          = zoom2_nand_partitions,
>>+      .nr_parts       = ARRAY_SIZE(zoom2_nand_partitions),
>>+      .nand_setup     = NULL,
>>+      .dma_channel    = -1,           /* disable DMA in OMAP NAND driver */
>>+      .dev_ready      = NULL,
>>+};
>>+
>>+static struct resource zoom2_nand_resource = {
>>+      .flags          = IORESOURCE_MEM,
>>+};
>>+
>>+static struct platform_device zoom2_nand_device = {
>>+      .name           = "omap2-nand",
>>+      .id             = 0,
>>+      .dev            = {
>>+              .platform_data = &zoom2_nand_data,
>>+      },
>>+      .num_resources  = 1,
>>+      .resource       = &zoom2_nand_resource,
>>+};
>>+
>>+static void __init zoom2_flash_init(void)
>>+{
>>+      u8 nandcs = LDP3430_NAND_CS;
>>+      u32 gpmc_base_add = OMAP34XX_GPMC_VIRT;
>>+
>>+      zoom2_nand_data.cs = nandcs;
>>+      zoom2_nand_data.gpmc_cs_baseaddr = (void *)(gpmc_base_add +
>>+                      GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
>>+      zoom2_nand_data.gpmc_baseaddr = (void *) (gpmc_base_add);
>>+
>>+      if (platform_device_register(&zoom2_nand_device) < 0)
>>+              printk(KERN_ERR "Unable to register NAND device!\n");
>>+}
>>+
>> /* Zoom2 has Qwerty keyboard*/
>> static int zoom2_twl4030_keymap[] = {
>>       KEY(0, 0, KEY_E),
>>@@ -271,6 +356,7 @@ static void __init omap_zoom2_init(void)
>>       omap_serial_init(&zoom2_uart_config);
>>       omap_zoom2_debugboard_init();
>>       usb_musb_init();
>>+      zoom2_flash_init();
>> }
>>
>> static void __init omap_zoom2_map_io(void)
>>--
>>1.6.3.3.210.g29cb3
>>
>>--
>>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>the body of a message to majordomo@vger.kernel.org
>>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

[-- Attachment #2: add_nand_support_zoom2.patch --]
[-- Type: application/octet-stream, Size: 10296 bytes --]

---
 arch/arm/mach-omap2/Makefile                |    2 
 arch/arm/mach-omap2/board-ldp-flash.c       |  196 ++++++++++++++++++++++++++++
 arch/arm/mach-omap2/board-ldp.c             |    2 
 arch/arm/mach-omap2/board-zoom2.c           |    2 
 arch/arm/plat-omap/include/mach/board-ldp.h |   36 +++++
 arch/arm/plat-omap/include/mach/nand.h      |    1 
 6 files changed, 239 insertions(+)

Index: linux-omap-2.6/arch/arm/mach-omap2/Makefile
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/Makefile
+++ linux-omap-2.6/arch/arm/mach-omap2/Makefile
@@ -54,6 +54,7 @@ obj-$(CONFIG_MACH_OMAP_APOLLON)		+= boar
 obj-$(CONFIG_MACH_OMAP3_BEAGLE)		+= board-omap3beagle.o \
 					   mmc-twl4030.o
 obj-$(CONFIG_MACH_OMAP_LDP)		+= board-ldp.o \
+					   board-ldp-flash.o \
 					   mmc-twl4030.o
 obj-$(CONFIG_MACH_OVERO)		+= board-overo.o \
 					   mmc-twl4030.o
@@ -69,6 +70,7 @@ obj-$(CONFIG_MACH_NOKIA_RX51)		+= board-
 					   board-rx51-peripherals.o \
 					   mmc-twl4030.o
 obj-$(CONFIG_MACH_OMAP_ZOOM2)		+= board-zoom2.o \
+					   board-ldp-flash.o \
 					   mmc-twl4030.o \
 					   board-zoom-debugboard.o
 
Index: linux-omap-2.6/arch/arm/mach-omap2/board-ldp-flash.c
===================================================================
--- /dev/null
+++ linux-omap-2.6/arch/arm/mach-omap2/board-ldp-flash.c
@@ -0,0 +1,196 @@
+/*
+ * arch/arm/mach-omap2/board-ldp-flash.c
+ *
+ * Copyright (C) 2008-09 Texas Instruments Inc.
+ *
+ * Modified from mach-omap2/board-2430sdp-flash.c
+ * Author(s): Rohit Choraria <rohitkc@ti.com>
+ *            Vimal Singh <vimalsingh@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/delay.h>
+#include <linux/platform_device.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/partitions.h>
+#include <linux/mtd/nand.h>
+#include <linux/types.h>
+#include <linux/io.h>
+
+#include <asm/mach/flash.h>
+#include <mach/board.h>
+#include <mach/gpmc.h>
+#include <mach/nand.h>
+
+#include <mach/board-ldp.h>
+
+#define NAND_CMD_UNLOCK1	0x23
+#define NAND_CMD_UNLOCK2	0x24
+/**
+ * @brief platform specific unlock function
+ *
+ * @param mtd - mtd info
+ * @param ofs - offset to start unlock from
+ * @param len - length to unlock
+ *
+ * @return - unlock status
+ */
+static int omap_ldp_nand_unlock(struct mtd_info *mtd, loff_t ofs, size_t len)
+{
+	int ret = 0;
+	int chipnr;
+	int status;
+	unsigned long page;
+	struct nand_chip *this = mtd->priv;
+	printk(KERN_INFO "nand_unlock: start: %08x, length: %d!\n",
+			(int)ofs, (int)len);
+
+	/* select the NAND device */
+	chipnr = (int)(ofs >> this->chip_shift);
+	this->select_chip(mtd, chipnr);
+	/* check the WP bit */
+	this->cmdfunc(mtd, NAND_CMD_STATUS, -1, -1);
+	if ((this->read_byte(mtd) & 0x80) == 0) {
+		printk(KERN_ERR "nand_unlock: Device is write protected!\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	if ((ofs & (mtd->writesize - 1)) != 0) {
+		printk(KERN_ERR "nand_unlock: Start address must be"
+				"beginning of nand page!\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	if (len == 0 || (len & (mtd->writesize - 1)) != 0) {
+		printk(KERN_ERR "nand_unlock: Length must be a multiple of "
+				"nand page size!\n");
+		ret = -EINVAL;
+		goto out;
+	}
+
+	/* submit address of first page to unlock */
+	page = (unsigned long)(ofs >> this->page_shift);
+	this->cmdfunc(mtd, NAND_CMD_UNLOCK1, -1, page & this->pagemask);
+
+	/* submit ADDRESS of LAST page to unlock */
+	page += (unsigned long)((ofs + len) >> this->page_shift) ;
+	this->cmdfunc(mtd, NAND_CMD_UNLOCK2, -1, page & this->pagemask);
+
+	/* call wait ready function */
+	status = this->waitfunc(mtd, this);
+	udelay(1000);
+	/* see if device thinks it succeeded */
+	if (status & 0x01) {
+		/* there was an error */
+		printk(KERN_ERR "nand_unlock: error status =0x%08x ", status);
+		ret = -EIO;
+		goto out;
+	}
+
+ out:
+	/* de-select the NAND device */
+	this->select_chip(mtd, -1);
+	return ret;
+}
+
+static struct mtd_partition ldp_nand_partitions[] = {
+	/* All the partition sizes are listed in terms of NAND block size */
+	{
+		.name		= "X-Loader-NAND",
+		.offset		= 0,
+		.size		= 4 * (64 * 2048),	/* 512KB, 0x80000 */
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "U-Boot-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x80000 */
+		.size		= 10 * (64 * 2048),	/* 1.25MB, 0x140000 */
+		.mask_flags	= MTD_WRITEABLE,	/* force read-only */
+	},
+	{
+		.name		= "Boot Env-NAND",
+		.offset		= MTDPART_OFS_APPEND,   /* Offset = 0x1c0000 */
+		.size		= 2 * (64 * 2048),	/* 256KB, 0x40000 */
+	},
+	{
+		.name		= "Kernel-NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x0200000*/
+		.size		= 240 * (64 * 2048),	/* 30M, 0x1E00000 */
+	},
+#ifdef CONFIG_MACH_OMAP_ZOOM2
+	{
+		.name		= "system",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x2000000 */
+		.size		= 1280 * (64 * 2048),   /* 160M, 0xA000000 */
+	},
+	{
+		.name		= "userdata",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0xC000000 */
+		.size		= 256 * (64 * 2048),	/* 32M, 0x2000000 */
+	},
+	{
+		.name		= "cache",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0xE000000 */
+		.size		= 256 * (64 * 2048),	/* 32M, 0x2000000 */
+	},
+#else
+	{
+		.name		= "File System - NAND",
+		.offset		= MTDPART_OFS_APPEND,	/* Offset = 0x2000000 */
+		.size		= MTDPART_SIZ_FULL,	/* 96MB, 0x6000000 */
+	},
+#endif
+};
+
+/* NAND chip access: 16 bit */
+static struct omap_nand_platform_data ldp_nand_data = {
+	.parts		= ldp_nand_partitions,
+	.nr_parts	= ARRAY_SIZE(ldp_nand_partitions),
+	.nand_setup	= NULL,
+	.dma_channel	= -1,		/* disable DMA in OMAP NAND driver */
+	.dev_ready	= NULL,
+	.unlock		= omap_ldp_nand_unlock,
+};
+
+static struct resource ldp_nand_resource = {
+	.flags		= IORESOURCE_MEM,
+};
+
+static struct platform_device ldp_nand_device = {
+	.name		= "omap2-nand",
+	.id		= 0,
+	.dev		= {
+	.platform_data	= &ldp_nand_data,
+	},
+	.num_resources	= 1,
+	.resource	= &ldp_nand_resource,
+};
+
+/**
+ * ldp430_flash_init - Identify devices connected to GPMC and register.
+ *
+ * @return - void.
+ */
+void __init ldp_flash_init(void)
+{
+	u8 nandcs = GPMC_CS_NUM + 1;
+	u32 gpmc_base_add = OMAP34XX_GPMC_VIRT;
+
+	/* pop nand part */
+	nandcs = LDP3430_NAND_CS;
+
+	ldp_nand_data.cs = nandcs;
+	ldp_nand_data.gpmc_cs_baseaddr = (void *)(gpmc_base_add +
+					GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
+	ldp_nand_data.gpmc_baseaddr = (void *) (gpmc_base_add);
+
+	if (platform_device_register(&ldp_nand_device) < 0)
+		printk(KERN_ERR "Unable to register NAND device\n");
+}
+
Index: linux-omap-2.6/arch/arm/mach-omap2/board-ldp.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/board-ldp.c
+++ linux-omap-2.6/arch/arm/mach-omap2/board-ldp.c
@@ -42,6 +42,7 @@
 #include <mach/control.h>
 #include <mach/usb.h>
 #include <mach/keypad.h>
+#include <mach/board-ldp.h>
 
 #include "mmc-twl4030.h"
 
@@ -385,6 +386,7 @@ static void __init omap_ldp_init(void)
 	ads7846_dev_init();
 	omap_serial_init(&ldp_uart_config);
 	usb_musb_init();
+	ldp_flash_init();
 
 	twl4030_mmc_init(mmc);
 	/* link regulators to MMC adapters */
Index: linux-omap-2.6/arch/arm/mach-omap2/board-zoom2.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/board-zoom2.c
+++ linux-omap-2.6/arch/arm/mach-omap2/board-zoom2.c
@@ -20,6 +20,7 @@
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 
+#include <mach/board-ldp.h>
 #include <mach/common.h>
 #include <mach/usb.h>
 #include <mach/keypad.h>
@@ -271,6 +272,7 @@ static void __init omap_zoom2_init(void)
 	omap_serial_init(&zoom2_uart_config);
 	omap_zoom2_debugboard_init();
 	usb_musb_init();
+	ldp_flash_init();
 }
 
 static void __init omap_zoom2_map_io(void)
Index: linux-omap-2.6/arch/arm/plat-omap/include/mach/board-ldp.h
===================================================================
--- /dev/null
+++ linux-omap-2.6/arch/arm/plat-omap/include/mach/board-ldp.h
@@ -0,0 +1,36 @@
+/*
+ * arch/arm/plat-omap/include/mach/board-ldp.h
+ *
+ * Hardware definitions for TI OMAP3 LDP/ZOOM2.
+ *
+ * Copyright (C) 2008-09 Texas Instruments Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
+ * NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
+ * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __ASM_ARCH_OMAP_LDP_H
+#define __ASM_ARCH_OMAP_LDP_H
+
+extern void ldp_flash_init(void);
+
+#define LDP3430_NAND_CS               0
+
+#endif /* __ASM_ARCH_OMAP_LDP_H */
Index: linux-omap-2.6/arch/arm/plat-omap/include/mach/nand.h
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/include/mach/nand.h
+++ linux-omap-2.6/arch/arm/plat-omap/include/mach/nand.h
@@ -18,6 +18,7 @@ struct omap_nand_platform_data {
 	int			nr_parts;
 	int			(*nand_setup)(void __iomem *);
 	int			(*dev_ready)(struct omap_nand_platform_data *);
+	int			(*unlock)(struct mtd_info *, loff_t, size_t);
 	int			dma_channel;
 	void __iomem		*gpmc_cs_baseaddr;
 	void __iomem		*gpmc_baseaddr;

RE: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[Pandita, Vikram]

Vimal

>-----Original Message-----
>From: vimal singh [mailto:vimal.newwork@gmail.com]
>Sent: Thursday, August 27, 2009 9:03 AM
>To: Pandita, Vikram
>Cc: Maxime Petazzoni; Singh, Vimal; linux-omap@vger.kernel.org; Rix, Tom
>Subject: Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions
>
>Hi,
>>
>> Also the Systerm/User/Cache partition definitions are more from Android perspective.
>>
>> Given that each system may have a different NAND partition requirement,
>> have you looked at bootargs passing the MTD partition info: Eg:
>>
>> mtdparts=omap2-nand.0:512k@0(xloader),\
>> 1536k@512k(bootloader),\
>> 29m@2m(kernel),\
>> 160m@32m(system),\
>> 32m@192m(userdata),\
>> 32m@224m(cache)


What about this bootargs nand partition specification approach? 


>>
>>
>> Lets discuss the final approach on this list and try to close this soon.
>>
>> Thnx
>>

Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[Maxime Petazzoni]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

Hi,

* Pandita, Vikram <vikram.pandita@ti.com> [2009-08-27 19:16:27]:

> Why?
> 
> I know of an implementation by Vimal Singh that introduces a common
> flash file for Zoom1 and Zoom2.
> There is reuse of code there.

Thanks for your comments.

There are indeed other implentations around using a common flash file
for Zoom1 and Zoom2 boards. I didn't know of this specific
implementation by Vimal Singh, but we use something very similar
internally.

Since linux-omap didn't had any MTD partitions definitions for either
boards, I decided to go for the smallest change: only partitions for
Zoom2.

> Please discuss and get a converged approach on handling NAND
> partitions on Zoom1 and Zoom2.

Agreed. We should use a common file for Zoom1 and Zoom2 flash, with
Zoom2 specific partition sizes. But I'm not sure I deserve the right to
propose Vimal Singh's patch (by the way, why hasn't it been merged in
the linux-omap tree?). How should we proceed then?

> Also the Systerm/User/Cache partition definitions are more from Android perspective.
> 
> Given that each system may have a different NAND partition requirement, 
> have you looked at bootargs passing the MTD partition info: Eg: 
> 
> mtdparts=omap2-nand.0:512k@0(xloader),\
> 1536k@512k(bootloader),\
> 29m@2m(kernel),\
> 160m@32m(system),\
> 32m@192m(userdata),\
> 32m@224m(cache)

Yes, I am aware of the mtdparts command line arguments, which works
great. I think a "default", sensible partition layout for the Zoom2
would be nice though.

- Maxime

-- 
Maxime Petazzoni
Linux kernel & software dev
MontaVista Software, Inc

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

RE: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[Rix, Tom]

The bootloader perspective..

The minimum set needed are for xloader, u-boot and the environment. 
xloader is very static.
u-boot at 1.25m should be big enough
environment is very static and should be big enough..
This is consistent with the bootloader.

The rest can be done with mtdparts and the differences between ldp and zoom2
flash layout can be separated in their respective environment files. 

The bootloader flashing utility 'fastboot' depends on the kernel layout.
There is a change pending to decouple using an mtdparts-like mechanism. 
See 'Runtime Partitions' toward the bottom of..

https://omapzoom.org/gf/project/omapzoom/wiki/?pagename=FAQ-8%3A+Zoom-II+Android%C2%A0fastboot

Tom

________________________________________
From: Maxime Petazzoni [mpetazzoni@mvista.com]
Sent: Thursday, August 27, 2009 9:06 AM
To: Pandita, Vikram
Cc: Singh, Vimal; linux-omap@vger.kernel.org; Rix, Tom
Subject: Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions

Hi,

* Pandita, Vikram <vikram.pandita@ti.com> [2009-08-27 19:16:27]:

> Why?
>
> I know of an implementation by Vimal Singh that introduces a common
> flash file for Zoom1 and Zoom2.
> There is reuse of code there.

Thanks for your comments.

There are indeed other implentations around using a common flash file
for Zoom1 and Zoom2 boards. I didn't know of this specific
implementation by Vimal Singh, but we use something very similar
internally.

Since linux-omap didn't had any MTD partitions definitions for either
boards, I decided to go for the smallest change: only partitions for
Zoom2.

> Please discuss and get a converged approach on handling NAND
> partitions on Zoom1 and Zoom2.

Agreed. We should use a common file for Zoom1 and Zoom2 flash, with
Zoom2 specific partition sizes. But I'm not sure I deserve the right to
propose Vimal Singh's patch (by the way, why hasn't it been merged in
the linux-omap tree?). How should we proceed then?

> Also the Systerm/User/Cache partition definitions are more from Android perspective.
>
> Given that each system may have a different NAND partition requirement,
> have you looked at bootargs passing the MTD partition info: Eg:
>
> mtdparts=omap2-nand.0:512k@0(xloader),\
> 1536k@512k(bootloader),\
> 29m@2m(kernel),\
> 160m@32m(system),\
> 32m@192m(userdata),\
> 32m@224m(cache)

Yes, I am aware of the mtdparts command line arguments, which works
great. I think a "default", sensible partition layout for the Zoom2
would be nice though.

- Maxime

--
Maxime Petazzoni
Linux kernel & software dev
MontaVista Software, Inc

Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[vimal singh]

On Thu, Aug 27, 2009 at 7:36 PM, Maxime Petazzoni<mpetazzoni@mvista.com> wrote:
> Hi,
>
> * Pandita, Vikram <vikram.pandita@ti.com> [2009-08-27 19:16:27]:
>
>> Why?
>>
>> I know of an implementation by Vimal Singh that introduces a common
>> flash file for Zoom1 and Zoom2.
>> There is reuse of code there.
>
> Thanks for your comments.
>
> There are indeed other implentations around using a common flash file
> for Zoom1 and Zoom2 boards. I didn't know of this specific
> implementation by Vimal Singh, but we use something very similar
> internally.
>
> Since linux-omap didn't had any MTD partitions definitions for either
> boards, I decided to go for the smallest change: only partitions for
> Zoom2.
>
>> Please discuss and get a converged approach on handling NAND
>> partitions on Zoom1 and Zoom2.
>
> Agreed. We should use a common file for Zoom1 and Zoom2 flash, with
> Zoom2 specific partition sizes. But I'm not sure I deserve the right to
> propose Vimal Singh's patch (by the way, why hasn't it been merged in
> the linux-omap tree?). How should we proceed then?
>
>> Also the Systerm/User/Cache partition definitions are more from Android perspective.
>>
>> Given that each system may have a different NAND partition requirement,
>> have you looked at bootargs passing the MTD partition info: Eg:
>>
>> mtdparts=omap2-nand.0:512k@0(xloader),\
>> 1536k@512k(bootloader),\
>> 29m@2m(kernel),\
>> 160m@32m(system),\
>> 32m@192m(userdata),\
>> 32m@224m(cache)
>
> Yes, I am aware of the mtdparts command line arguments, which works
> great. I think a "default", sensible partition layout for the Zoom2
> would be nice though.

I agree. Keeping it in the mind that mtdparts command line arguments
will be given higher precedence anyway...

-vimal

>
> - Maxime
>
> --
> Maxime Petazzoni
> Linux kernel & software dev
> MontaVista Software, Inc
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkqWktkACgkQ7KsOe4Pmrg28zwCdHvKdX9NDgWVoUOx6Mc8kA6+7
> rx8An1NMQg5aEUHrEgGBZM/1YoFTvQtz
> =4L+0
> -----END PGP SIGNATURE-----
>
>



-- 
Regards,
Vimal Singh

Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[Maxime Petazzoni]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

* vimal singh <vimal.newwork@gmail.com> [2009-09-01 12:34:26]:

> > Yes, I am aware of the mtdparts command line arguments, which works
> > great. I think a "default", sensible partition layout for the Zoom2
> > would be nice though.
> 
> I agree. Keeping it in the mind that mtdparts command line arguments
> will be given higher precedence anyway...

Exactly. I would recommend that your patch gets merged in. Although I'm
a bit curious of the rationale behind a 30M kernel partition?

Also, given a 512MB NAND, we could easily affect 256MB or more to the
system partition (as well as a bit more space for the userdata
partition).

But that's just nitpicking. As we said, mtdparts can be used to take
precedence over the default settings if they don't match the
user/system's needs.

- Maxime
-- 
Maxime Petazzoni
Linux kernel & software dev
MontaVista Software, Inc

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] OMAP3: Zoom2: provide default MTD partitions

[vimal singh]

On Tue, Sep 1, 2009 at 12:42 PM, Maxime Petazzoni<mpetazzoni@mvista.com> wrote:
> * vimal singh <vimal.newwork@gmail.com> [2009-09-01 12:34:26]:
>
>> > Yes, I am aware of the mtdparts command line arguments, which works
>> > great. I think a "default", sensible partition layout for the Zoom2
>> > would be nice though.
>>
>> I agree. Keeping it in the mind that mtdparts command line arguments
>> will be given higher precedence anyway...
>
> Exactly. I would recommend that your patch gets merged in. Although I'm
> a bit curious of the rationale behind a 30M kernel partition?
>
> Also, given a 512MB NAND, we could easily affect 256MB or more to the
> system partition (as well as a bit more space for the userdata
> partition).
>
> But that's just nitpicking. As we said, mtdparts can be used to take
> precedence over the default settings if they don't match the
> user/system's needs.

I'll re-submit this patch along with one that I mentioned earlier:
http://marc.info/?l=linux-omap&m=125065707704826&w=2

in a series of patches.

-- 
Regards,
Vimal Singh