* [PATCH] usb: ehci-omap: Fix build break
@ 2009-09-22 15:11 Olof Johansson
2009-09-22 17:12 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Olof Johansson @ 2009-09-22 15:11 UTC (permalink / raw)
To: Ajay Kumar Gupta; +Cc: linux-omap, tony
Fix build break:
CC drivers/usb/host/ehci-hcd.o
In file included from drivers/usb/host/ehci-hcd.c:1101:
drivers/usb/host/ehci-omap.c: In function 'omap_start_ehc':
drivers/usb/host/ehci-omap.c:238: error: 'CHIP_GE_OMAP3430ES3' undeclared (first use in this function)
drivers/usb/host/ehci-omap.c:238: error: (Each undeclared identifier is reported only once
drivers/usb/host/ehci-omap.c:238: error: for each function it appears in.)
make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
No reference to CHIP_GE_OMAP3430ES3 anywhere else, I'm assuming it's
ES3_1 that's supposed to be used.
Signed-off-by: Olof Johansson <olof@lixom.net>
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index f77a99d..301e7b6 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -235,7 +235,7 @@ static void omap_usb_utmi_init(struct ehci_hcd_omap *omap, u8 tll_channel_mask)
*/
static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
{
- struct omap_chip_id oci = OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3);
+ struct omap_chip_id oci = OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1);
unsigned long timeout = jiffies + msecs_to_jiffies(1000);
u8 tll_ch_mask = 0;
unsigned reg = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: ehci-omap: Fix build break
2009-09-22 15:11 [PATCH] usb: ehci-omap: Fix build break Olof Johansson
@ 2009-09-22 17:12 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2009-09-22 17:12 UTC (permalink / raw)
To: Olof Johansson; +Cc: Ajay Kumar Gupta, linux-omap
* Olof Johansson <olof@lixom.net> [090922 07:55]:
> Fix build break:
>
> CC drivers/usb/host/ehci-hcd.o
> In file included from drivers/usb/host/ehci-hcd.c:1101:
> drivers/usb/host/ehci-omap.c: In function 'omap_start_ehc':
> drivers/usb/host/ehci-omap.c:238: error: 'CHIP_GE_OMAP3430ES3' undeclared (first use in this function)
> drivers/usb/host/ehci-omap.c:238: error: (Each undeclared identifier is reported only once
> drivers/usb/host/ehci-omap.c:238: error: for each function it appears in.)
> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
>
>
> No reference to CHIP_GE_OMAP3430ES3 anywhere else, I'm assuming it's
> ES3_1 that's supposed to be used.
I'm dropping the "ehci: Support for ES3.x" patch instead for now
until it's fixed to use the omap_rev().
So this should not be needed.
Tony
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index f77a99d..301e7b6 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -235,7 +235,7 @@ static void omap_usb_utmi_init(struct ehci_hcd_omap *omap, u8 tll_channel_mask)
> */
> static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
> {
> - struct omap_chip_id oci = OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3);
> + struct omap_chip_id oci = OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1);
> unsigned long timeout = jiffies + msecs_to_jiffies(1000);
> u8 tll_ch_mask = 0;
> unsigned reg = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-22 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-22 15:11 [PATCH] usb: ehci-omap: Fix build break Olof Johansson
2009-09-22 17:12 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox