* [PATCH] OMAP3: iovmm: fix compiler warning @ 2009-09-18 8:56 Sanjeev Premi 2009-09-18 9:54 ` Hiroshi DOYU 0 siblings, 1 reply; 9+ messages in thread From: Sanjeev Premi @ 2009-09-18 8:56 UTC (permalink / raw) To: linux-omap; +Cc: Sanjeev Premi This patch fixes these compiler warnings: arch/arm/plat-omap/iovmm.c: In function 'vmap_sg': arch/arm/plat-omap/iovmm.c:202: warning: passing argument 1 of 'flush_cache_vmap' makes integer from pointer without a cast arch/arm/plat-omap/iovmm.c:202: warning: passing argument 2 of 'flush_cache_vmap' makes integer from pointer without a cast arch/arm/plat-omap/iovmm.c: In function 'sgtable_fill_vmalloc': arch/arm/plat-omap/iovmm.c:393: warning: passing argument 1 of 'flush_cache_vmap' makes integer from pointer without a cast arch/arm/plat-omap/iovmm.c:393: warning: passing argument 2 of 'flush_cache_vmap' makes integer from pointer without a cast Signed-off-by: Sanjeev Premi <premi@ti.com> --- arch/arm/plat-omap/iovmm.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 004fd83..481bf77 100644 --- a/arch/arm/plat-omap/iovmm.c +++ b/arch/arm/plat-omap/iovmm.c @@ -199,7 +199,8 @@ static void *vmap_sg(const struct sg_table *sgt) va += bytes; } - flush_cache_vmap(new->addr, new->addr + total); + flush_cache_vmap((unsigned long) new->addr, + (unsigned long) (new->addr + total)); return new->addr; err_out: @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct sg_table *sgt, void *_va) } va_end = _va + PAGE_SIZE * i; - flush_cache_vmap(_va, va_end); + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); } static inline void sgtable_drain_vmalloc(struct sg_table *sgt) -- 1.6.2.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-18 8:56 [PATCH] OMAP3: iovmm: fix compiler warning Sanjeev Premi @ 2009-09-18 9:54 ` Hiroshi DOYU 2009-09-18 10:23 ` Premi, Sanjeev 0 siblings, 1 reply; 9+ messages in thread From: Hiroshi DOYU @ 2009-09-18 9:54 UTC (permalink / raw) To: premi; +Cc: linux-omap Hi Premi, From: ext Sanjeev Premi <premi@ti.com> Subject: [PATCH] OMAP3: iovmm: fix compiler warning Date: Fri, 18 Sep 2009 10:56:26 +0200 > This patch fixes these compiler warnings: > > arch/arm/plat-omap/iovmm.c: In function 'vmap_sg': > arch/arm/plat-omap/iovmm.c:202: warning: passing argument 1 of > 'flush_cache_vmap' makes integer from pointer without a cast > arch/arm/plat-omap/iovmm.c:202: warning: passing argument 2 of > 'flush_cache_vmap' makes integer from pointer without a cast > arch/arm/plat-omap/iovmm.c: In function 'sgtable_fill_vmalloc': > arch/arm/plat-omap/iovmm.c:393: warning: passing argument 1 of > 'flush_cache_vmap' makes integer from pointer without a cast > arch/arm/plat-omap/iovmm.c:393: warning: passing argument 2 of > 'flush_cache_vmap' makes integer from pointer without a cast > > Signed-off-by: Sanjeev Premi <premi@ti.com> > --- > arch/arm/plat-omap/iovmm.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c > index 004fd83..481bf77 100644 > --- a/arch/arm/plat-omap/iovmm.c > +++ b/arch/arm/plat-omap/iovmm.c > @@ -199,7 +199,8 @@ static void *vmap_sg(const struct sg_table *sgt) > va += bytes; > } > > - flush_cache_vmap(new->addr, new->addr + total); > + flush_cache_vmap((unsigned long) new->addr, > + (unsigned long) (new->addr + total)); I think that the space after casting isn't necessary. > return new->addr; > > err_out: > @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct sg_table *sgt, void *_va) > } > > va_end = _va + PAGE_SIZE * i; > - flush_cache_vmap(_va, va_end); > + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); > } > > static inline void sgtable_drain_vmalloc(struct sg_table *sgt) If no need for pointer, what about below? Modified arch/arm/plat-omap/iovmm.c diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 6fc52fc..3ea0cd0 100644 --- a/arch/arm/plat-omap/iovmm.c +++ b/arch/arm/plat-omap/iovmm.c @@ -368,12 +368,12 @@ out: } EXPORT_SYMBOL_GPL(da_to_va); -static void sgtable_fill_vmalloc(struct sg_table *sgt, void *_va) +static void sgtable_fill_vmalloc(struct sg_table *sgt, u32 _va) { unsigned int i; struct scatterlist *sg; - void *va = _va; - void *va_end; + u32 va = _va; + u32 va_end; for_each_sg(sgt->sgl, sg, sgt->nents, i) { struct page *pg; @@ -693,7 +693,7 @@ u32 iommu_vmalloc(struct iommu *obj, u32 da, size_t bytes, u32 flags) da = PTR_ERR(sgt); goto err_sgt_alloc; } - sgtable_fill_vmalloc(sgt, va); + sgtable_fill_vmalloc(sgt, (u32)va); flags &= IOVMF_HW_MASK; flags |= IOVMF_DISCONT; ^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-18 9:54 ` Hiroshi DOYU @ 2009-09-18 10:23 ` Premi, Sanjeev 2009-09-18 14:40 ` Premi, Sanjeev 0 siblings, 1 reply; 9+ messages in thread From: Premi, Sanjeev @ 2009-09-18 10:23 UTC (permalink / raw) To: Hiroshi DOYU; +Cc: linux-omap@vger.kernel.org > -----Original Message----- > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com] > Sent: Friday, September 18, 2009 3:25 PM > To: Premi, Sanjeev > Cc: linux-omap@vger.kernel.org > Subject: Re: [PATCH] OMAP3: iovmm: fix compiler warning > > Hi Premi, > > From: ext Sanjeev Premi <premi@ti.com> > Subject: [PATCH] OMAP3: iovmm: fix compiler warning > Date: Fri, 18 Sep 2009 10:56:26 +0200 > > > This patch fixes these compiler warnings: > > > > arch/arm/plat-omap/iovmm.c: In function 'vmap_sg': > > arch/arm/plat-omap/iovmm.c:202: warning: passing argument 1 of > > 'flush_cache_vmap' makes integer from pointer without a cast > > arch/arm/plat-omap/iovmm.c:202: warning: passing argument 2 of > > 'flush_cache_vmap' makes integer from pointer without a cast > > arch/arm/plat-omap/iovmm.c: In function 'sgtable_fill_vmalloc': > > arch/arm/plat-omap/iovmm.c:393: warning: passing argument 1 of > > 'flush_cache_vmap' makes integer from pointer without a cast > > arch/arm/plat-omap/iovmm.c:393: warning: passing argument 2 of > > 'flush_cache_vmap' makes integer from pointer without a cast > > > > Signed-off-by: Sanjeev Premi <premi@ti.com> > > --- > > arch/arm/plat-omap/iovmm.c | 5 +++-- > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c > > index 004fd83..481bf77 100644 > > --- a/arch/arm/plat-omap/iovmm.c > > +++ b/arch/arm/plat-omap/iovmm.c > > @@ -199,7 +199,8 @@ static void *vmap_sg(const struct sg_table *sgt) > > va += bytes; > > } > > > > - flush_cache_vmap(new->addr, new->addr + total); > > + flush_cache_vmap((unsigned long) new->addr, > > + (unsigned long) (new->addr + total)); > > I think that the space after casting isn't necessary. > > > return new->addr; > > > > err_out: > > @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct > sg_table *sgt, void *_va) > > } > > > > va_end = _va + PAGE_SIZE * i; > > - flush_cache_vmap(_va, va_end); > > + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); > > } > > > > static inline void sgtable_drain_vmalloc(struct sg_table *sgt) > > If no need for pointer, what about below? I did not check for the usage of sgtable_drain_vmalloc(). Yes. If the void* isn't MUST then, change below is fine. ~sanjeev > > Modified arch/arm/plat-omap/iovmm.c > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c > index 6fc52fc..3ea0cd0 100644 > --- a/arch/arm/plat-omap/iovmm.c > +++ b/arch/arm/plat-omap/iovmm.c > @@ -368,12 +368,12 @@ out: > } > EXPORT_SYMBOL_GPL(da_to_va); > > -static void sgtable_fill_vmalloc(struct sg_table *sgt, void *_va) > +static void sgtable_fill_vmalloc(struct sg_table *sgt, u32 _va) > { > unsigned int i; > struct scatterlist *sg; > - void *va = _va; > - void *va_end; > + u32 va = _va; > + u32 va_end; > > for_each_sg(sgt->sgl, sg, sgt->nents, i) { > struct page *pg; > @@ -693,7 +693,7 @@ u32 iommu_vmalloc(struct iommu *obj, u32 > da, size_t bytes, u32 flags) > da = PTR_ERR(sgt); > goto err_sgt_alloc; > } > - sgtable_fill_vmalloc(sgt, va); > + sgtable_fill_vmalloc(sgt, (u32)va); > > flags &= IOVMF_HW_MASK; > flags |= IOVMF_DISCONT; > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-18 10:23 ` Premi, Sanjeev @ 2009-09-18 14:40 ` Premi, Sanjeev 2009-09-18 14:54 ` Hiroshi DOYU 0 siblings, 1 reply; 9+ messages in thread From: Premi, Sanjeev @ 2009-09-18 14:40 UTC (permalink / raw) To: Premi, Sanjeev, Hiroshi DOYU; +Cc: linux-omap@vger.kernel.org > -----Original Message----- > From: linux-omap-owner@vger.kernel.org > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Premi, Sanjeev > Sent: Friday, September 18, 2009 3:53 PM > To: Hiroshi DOYU > Cc: linux-omap@vger.kernel.org > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > > > -----Original Message----- > > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com] > > Sent: Friday, September 18, 2009 3:25 PM > > To: Premi, Sanjeev > > Cc: linux-omap@vger.kernel.org > > Subject: Re: [PATCH] OMAP3: iovmm: fix compiler warning > > > > Hi Premi, > > > > From: ext Sanjeev Premi <premi@ti.com> > > Subject: [PATCH] OMAP3: iovmm: fix compiler warning > > Date: Fri, 18 Sep 2009 10:56:26 +0200 > > > > > This patch fixes these compiler warnings: > > > > > > arch/arm/plat-omap/iovmm.c: In function 'vmap_sg': > > > arch/arm/plat-omap/iovmm.c:202: warning: passing argument 1 of > > > 'flush_cache_vmap' makes integer from pointer without a cast > > > arch/arm/plat-omap/iovmm.c:202: warning: passing argument 2 of > > > 'flush_cache_vmap' makes integer from pointer without a cast > > > arch/arm/plat-omap/iovmm.c: In function 'sgtable_fill_vmalloc': > > > arch/arm/plat-omap/iovmm.c:393: warning: passing argument 1 of > > > 'flush_cache_vmap' makes integer from pointer without a cast > > > arch/arm/plat-omap/iovmm.c:393: warning: passing argument 2 of > > > 'flush_cache_vmap' makes integer from pointer without a cast > > > > > > Signed-off-by: Sanjeev Premi <premi@ti.com> > > > --- > > > arch/arm/plat-omap/iovmm.c | 5 +++-- > > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm/plat-omap/iovmm.c > b/arch/arm/plat-omap/iovmm.c > > > index 004fd83..481bf77 100644 > > > --- a/arch/arm/plat-omap/iovmm.c > > > +++ b/arch/arm/plat-omap/iovmm.c > > > @@ -199,7 +199,8 @@ static void *vmap_sg(const struct > sg_table *sgt) > > > va += bytes; > > > } > > > > > > - flush_cache_vmap(new->addr, new->addr + total); > > > + flush_cache_vmap((unsigned long) new->addr, > > > + (unsigned long) (new->addr + total)); > > > > I think that the space after casting isn't necessary. > > > > > return new->addr; > > > > > > err_out: > > > @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct > > sg_table *sgt, void *_va) > > > } > > > > > > va_end = _va + PAGE_SIZE * i; > > > - flush_cache_vmap(_va, va_end); > > > + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); > > > } > > > > > > static inline void sgtable_drain_vmalloc(struct sg_table *sgt) > > > > If no need for pointer, what about below? > > I did not check for the usage of sgtable_drain_vmalloc(). > Yes. If the void* isn't MUST then, change below is fine. > > ~sanjeev On second look, the need for void* is driven backwards from: pg = vmalloc_to_page(va); In function sgtable_fill_vmalloc(). Now we need a typecast from u32 to void*. Shouldn't we go with the original patch itself? Or, new go with changes below with additional: - pg = vmalloc_to_page(va); + pg = vmalloc_to_page((void *)va); ~sanjeev > > > > Modified arch/arm/plat-omap/iovmm.c > > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c > > index 6fc52fc..3ea0cd0 100644 > > --- a/arch/arm/plat-omap/iovmm.c > > +++ b/arch/arm/plat-omap/iovmm.c > > @@ -368,12 +368,12 @@ out: > > } > > EXPORT_SYMBOL_GPL(da_to_va); > > > > -static void sgtable_fill_vmalloc(struct sg_table *sgt, void *_va) > > +static void sgtable_fill_vmalloc(struct sg_table *sgt, u32 _va) > > { > > unsigned int i; > > struct scatterlist *sg; > > - void *va = _va; > > - void *va_end; > > + u32 va = _va; > > + u32 va_end; > > > > for_each_sg(sgt->sgl, sg, sgt->nents, i) { > > struct page *pg; > > @@ -693,7 +693,7 @@ u32 iommu_vmalloc(struct iommu *obj, u32 > > da, size_t bytes, u32 flags) > > da = PTR_ERR(sgt); > > goto err_sgt_alloc; > > } > > - sgtable_fill_vmalloc(sgt, va); > > + sgtable_fill_vmalloc(sgt, (u32)va); > > > > flags &= IOVMF_HW_MASK; > > flags |= IOVMF_DISCONT; > > > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-18 14:40 ` Premi, Sanjeev @ 2009-09-18 14:54 ` Hiroshi DOYU 2009-09-22 21:36 ` Tony Lindgren 0 siblings, 1 reply; 9+ messages in thread From: Hiroshi DOYU @ 2009-09-18 14:54 UTC (permalink / raw) To: premi; +Cc: linux-omap Hi Premi, From: "ext Premi, Sanjeev" <premi@ti.com> Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning Date: Fri, 18 Sep 2009 16:40:29 +0200 [...] > > > > @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct > > > sg_table *sgt, void *_va) > > > > } > > > > > > > > va_end = _va + PAGE_SIZE * i; > > > > - flush_cache_vmap(_va, va_end); > > > > + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); > > > > } > > > > > > > > static inline void sgtable_drain_vmalloc(struct sg_table *sgt) > > > > > > If no need for pointer, what about below? > > > > I did not check for the usage of sgtable_drain_vmalloc(). > > Yes. If the void* isn't MUST then, change below is fine. > > > > ~sanjeev > > On second look, the need for void* is driven backwards from: > pg = vmalloc_to_page(va); > In function sgtable_fill_vmalloc(). > > Now we need a typecast from u32 to void*. > > Shouldn't we go with the original patch itself? Right, the original is better, then;) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-18 14:54 ` Hiroshi DOYU @ 2009-09-22 21:36 ` Tony Lindgren 2009-09-23 4:06 ` Premi, Sanjeev 0 siblings, 1 reply; 9+ messages in thread From: Tony Lindgren @ 2009-09-22 21:36 UTC (permalink / raw) To: Hiroshi DOYU; +Cc: premi, linux-omap * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090918 07:54]: > Hi Premi, > > From: "ext Premi, Sanjeev" <premi@ti.com> > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > Date: Fri, 18 Sep 2009 16:40:29 +0200 > > [...] > > > > > > @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct > > > > sg_table *sgt, void *_va) > > > > > } > > > > > > > > > > va_end = _va + PAGE_SIZE * i; > > > > > - flush_cache_vmap(_va, va_end); > > > > > + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); > > > > > } > > > > > > > > > > static inline void sgtable_drain_vmalloc(struct sg_table *sgt) > > > > > > > > If no need for pointer, what about below? > > > > > > I did not check for the usage of sgtable_drain_vmalloc(). > > > Yes. If the void* isn't MUST then, change below is fine. > > > > > > ~sanjeev > > > > On second look, the need for void* is driven backwards from: > > pg = vmalloc_to_page(va); > > In function sgtable_fill_vmalloc(). > > > > Now we need a typecast from u32 to void*. > > > > Shouldn't we go with the original patch itself? > > Right, the original is better, then;) Can you please specify which one (if any) should be queued? Do you mean http://patchwork.kernel.org/patch/48467/ Tony ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-22 21:36 ` Tony Lindgren @ 2009-09-23 4:06 ` Premi, Sanjeev 2009-09-23 5:45 ` Hiroshi DOYU 0 siblings, 1 reply; 9+ messages in thread From: Premi, Sanjeev @ 2009-09-23 4:06 UTC (permalink / raw) To: Tony Lindgren, Hiroshi DOYU; +Cc: linux-omap@vger.kernel.org > -----Original Message----- > From: Tony Lindgren [mailto:tony@atomide.com] > Sent: Wednesday, September 23, 2009 3:06 AM > To: Hiroshi DOYU > Cc: Premi, Sanjeev; linux-omap@vger.kernel.org > Subject: Re: [PATCH] OMAP3: iovmm: fix compiler warning > > * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090918 07:54]: > > Hi Premi, > > > > From: "ext Premi, Sanjeev" <premi@ti.com> > > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > > Date: Fri, 18 Sep 2009 16:40:29 +0200 > > > > [...] > > [snip]--[snip] > > > Shouldn't we go with the original patch itself? > > > > Right, the original is better, then;) > > Can you please specify which one (if any) should be queued? > > Do you mean http://patchwork.kernel.org/patch/48467/ [sp] Yes. That's right. > > Tony > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-23 4:06 ` Premi, Sanjeev @ 2009-09-23 5:45 ` Hiroshi DOYU 2009-09-23 8:29 ` Premi, Sanjeev 0 siblings, 1 reply; 9+ messages in thread From: Hiroshi DOYU @ 2009-09-23 5:45 UTC (permalink / raw) To: premi; +Cc: tony, linux-omap Hi Premi, From: "ext Premi, Sanjeev" <premi@ti.com> Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning Date: Wed, 23 Sep 2009 06:06:43 +0200 > > -----Original Message----- > > From: Tony Lindgren [mailto:tony@atomide.com] > > Sent: Wednesday, September 23, 2009 3:06 AM > > To: Hiroshi DOYU > > Cc: Premi, Sanjeev; linux-omap@vger.kernel.org > > Subject: Re: [PATCH] OMAP3: iovmm: fix compiler warning > > > > * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090918 07:54]: > > > Hi Premi, > > > > > > From: "ext Premi, Sanjeev" <premi@ti.com> > > > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > > > Date: Fri, 18 Sep 2009 16:40:29 +0200 > > > > > > [...] > > > > > [snip]--[snip] > > > > > Shouldn't we go with the original patch itself? > > > > > > Right, the original is better, then;) > > > > Can you please specify which one (if any) should be queued? > > > > Do you mean http://patchwork.kernel.org/patch/48467/ > > [sp] Yes. That's right. I know it's nitpicky, but it's better to remove a space after casting as pointed previously. Would it be possible to send the update version? ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] OMAP3: iovmm: fix compiler warning 2009-09-23 5:45 ` Hiroshi DOYU @ 2009-09-23 8:29 ` Premi, Sanjeev 0 siblings, 0 replies; 9+ messages in thread From: Premi, Sanjeev @ 2009-09-23 8:29 UTC (permalink / raw) To: Hiroshi DOYU; +Cc: tony@atomide.com, linux-omap@vger.kernel.org > -----Original Message----- > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com] > Sent: Wednesday, September 23, 2009 11:16 AM > To: Premi, Sanjeev > Cc: tony@atomide.com; linux-omap@vger.kernel.org > Subject: Re: [PATCH] OMAP3: iovmm: fix compiler warning > > Hi Premi, > > From: "ext Premi, Sanjeev" <premi@ti.com> > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > Date: Wed, 23 Sep 2009 06:06:43 +0200 > > > > -----Original Message----- > > > From: Tony Lindgren [mailto:tony@atomide.com] > > > Sent: Wednesday, September 23, 2009 3:06 AM > > > To: Hiroshi DOYU > > > Cc: Premi, Sanjeev; linux-omap@vger.kernel.org > > > Subject: Re: [PATCH] OMAP3: iovmm: fix compiler warning > > > > > > * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090918 07:54]: > > > > Hi Premi, > > > > > > > > From: "ext Premi, Sanjeev" <premi@ti.com> > > > > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > > > > Date: Fri, 18 Sep 2009 16:40:29 +0200 > > > > > > > > [...] > > > > > > > > [snip]--[snip] > > > > > > > Shouldn't we go with the original patch itself? > > > > > > > > Right, the original is better, then;) > > > > > > Can you please specify which one (if any) should be queued? > > > > > > Do you mean http://patchwork.kernel.org/patch/48467/ > > > > [sp] Yes. That's right. > > I know it's nitpicky, but it's better to remove a space after casting > as pointed previously. > > Would it be possible to send the update version? > > In few mins... ~sanjeev ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-09-23 8:29 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-09-18 8:56 [PATCH] OMAP3: iovmm: fix compiler warning Sanjeev Premi 2009-09-18 9:54 ` Hiroshi DOYU 2009-09-18 10:23 ` Premi, Sanjeev 2009-09-18 14:40 ` Premi, Sanjeev 2009-09-18 14:54 ` Hiroshi DOYU 2009-09-22 21:36 ` Tony Lindgren 2009-09-23 4:06 ` Premi, Sanjeev 2009-09-23 5:45 ` Hiroshi DOYU 2009-09-23 8:29 ` Premi, Sanjeev
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox