From: Tony Lindgren <tony@atomide.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] Runtime detection of Si features
Date: Wed, 23 Sep 2009 10:10:14 -0700 [thread overview]
Message-ID: <20090923171013.GK4919@atomide.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59301DDA2D09E@dbde02.ent.ti.com>
* Premi, Sanjeev <premi@ti.com> [090923 06:41]:
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony@atomide.com]
> > Sent: Wednesday, September 23, 2009 1:39 AM
> > To: Premi, Sanjeev
> > Cc: linux-omap@vger.kernel.org
> > Subject: Re: [PATCH v2] Runtime detection of Si features
>
> [snip]---[snip]---[snip]
>
> > > diff --git a/arch/arm/mach-omap2/mmc-twl4030.c
> > b/arch/arm/mach-omap2/mmc-twl4030.c
> > > index 3c04c2f..d68284d 100644
> > > --- a/arch/arm/mach-omap2/mmc-twl4030.c
> > > +++ b/arch/arm/mach-omap2/mmc-twl4030.c
> > > @@ -10,6 +10,7 @@
> > > * published by the Free Software Foundation.
> > > */
> > > #include <linux/err.h>
> > > +#include <linux/bitops.h>
> > > #include <linux/io.h>
> > > #include <linux/module.h>
> > > #include <linux/platform_device.h>
> >
> > The mmc-twl4030.c change should not be related to this, right?
> >
> > Other than that, let's plan on merging these after 2.6.32-rc1.
> >
>
> [sp] Not really related to the runtime detection; but required to
> ensure successful compilation. Using BIT() macros in cpu.h
> (see below) make this necessary.
OK
> Should I split this into patch-set; making this into a
> separate patch?
No, that's fine.
Tony
> Best regards,
> Sanjeev
>
> > Regards,
> >
> > Tony
> >
>
> [snip]---[snip]---[snip]
>
> > > diff --git a/arch/arm/plat-omap/include/mach/cpu.h
> > b/arch/arm/plat-omap/include/mach/cpu.h
> > > index 4fbc6a9..4a04f77 100644
> > > --- a/arch/arm/plat-omap/include/mach/cpu.h
> > > +++ b/arch/arm/plat-omap/include/mach/cpu.h
> > > @@ -432,4 +432,27 @@ IS_OMAP_TYPE(3430, 0x3430)
> > > int omap_chip_is(struct omap_chip_id oci);
> > > void omap2_check_revision(void);
> > >
> > > +/*
> > > + * Runtime detection of OMAP3 features
> > > + */
> > > +extern u32 omap3_features;
> > > +
> > > +#define OMAP3_HAS_L2CACHE BIT(0)
> > > +#define OMAP3_HAS_IVA BIT(1)
> > > +#define OMAP3_HAS_SGX BIT(2)
> > > +#define OMAP3_HAS_NEON BIT(3)
> > > +#define OMAP3_HAS_ISP BIT(4)
> > > +
> > > +#define OMAP3_HAS_FEATURE(feat,flag) \
> > > +static inline unsigned int omap3_has_ ##feat(void) \
> > > +{ \
> > > + return (omap3_features & OMAP3_HAS_ ##flag); \
> > > +} \
> > > +
> > > +OMAP3_HAS_FEATURE(l2cache, L2CACHE)
> > > +OMAP3_HAS_FEATURE(sgx, SGX)
> > > +OMAP3_HAS_FEATURE(iva, IVA)
> > > +OMAP3_HAS_FEATURE(neon, NEON)
> > > +OMAP3_HAS_FEATURE(isp, ISP)
> > > +
> > > #endif /* __ASM_ARCH_OMAP_CPU_H */
> > > --
> > > 1.6.2.2
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-omap" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
prev parent reply other threads:[~2009-09-23 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 11:50 [PATCH v2] Runtime detection of Si features Sanjeev Premi
2009-08-25 11:36 ` Premi, Sanjeev
2009-09-22 20:09 ` Tony Lindgren
2009-09-23 13:41 ` Premi, Sanjeev
2009-09-23 17:10 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923171013.GK4919@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox