public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Gadiyar, Anand" <gadiyar@ti.com>
Cc: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap3: ehci: remove chargepump hack
Date: Thu, 24 Sep 2009 15:45:06 +0300	[thread overview]
Message-ID: <20090924124506.GH4186@nokia.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB030A1C5936@dbde02.ent.ti.com>

On Thu, Sep 24, 2009 at 02:19:52PM +0200, ext Gadiyar, Anand wrote:
> > On Thu, Sep 24, 2009 at 02:06:57PM +0200, ext Anand Gadiyar wrote:
> > > omap3: ehci: remove chargepump hack
> > > 
> > > This hack was for a very early development board that is no longer
> > > in use. Remove it. No board should require it.
> > 
> > do we have anyone using it besides development boards ?
> > 
> 
> Not sure I understand the question. If you meant "is anyone other than
> development boards using the chargepump hack", then the short answer is no.
> 
> The chargepump hack was only for one particular reference design board - the
> very first version of it. Only 6-odd boards were made which needed that hack.
> It's long gone from internal codebases, as are the boards.
> 
> As far as I know, no board in the wild will need it. If you look at the
> patch, only the 3430 SDP board set this flag to true, and all others
> were false. I confirm that all later versions of the expansion board in use
> with the 3430SDP do not require this hack.
> 
> So there's no point having it around.

good, so:

Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

-- 
balbi

  reply	other threads:[~2009-09-24 12:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 12:06 [PATCH] omap3: ehci: remove chargepump hack Anand Gadiyar
2009-09-24 12:10 ` Felipe Balbi
2009-09-24 12:19   ` Gadiyar, Anand
2009-09-24 12:45     ` Felipe Balbi [this message]
2009-09-30  1:19       ` Gadiyar, Anand
2009-09-30 18:29 ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090924124506.GH4186@nokia.com \
    --to=felipe.balbi@nokia.com \
    --cc=gadiyar@ti.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox