Re: [PATCH 0/2] twl4030 power support for 3430SDP

[Amit Kucheria <amit.kucheria@verdurent.com>]

On 09 Oct 01, Kevin Hilman wrote:
> Amit Kucheria <amit.kucheria@canonical.com> writes:
> 
> > On 09 Oct 01, Kevin Hilman wrote:
> >> I've been carrying these in the PM branch, but now that twl4030 power
> >> support is in mainline, these can be queued for 2.6.33.
> >> 
> >> Kevin Hilman (1):
> >>   OMAP3: PM: 3430SDP: add initial twl4030 power scripts
> >> 
> >> Rajendra Nayak (1):
> >>   OMAP3: PM: 3430SDP: Update twl4030 power scripts and device groups
> >> 
> >>  arch/arm/mach-omap2/board-3430sdp.c |   93 ++++++++++++++++++++++++++++++++++-
> >>  1 files changed, 91 insertions(+), 2 deletions(-)
> >> 
> >
> > Hi Kevin,
> >
> > Do you want to wait until I push patches that modify the way the scripts are
> > loaded in memory? (they now allow overlapping scripts to work around space
> > constraints)
> >
> > Also we now have very simplified scripts that use broadcast messages. These
> > might still need to be tweaked for the various boards though. It works on the
> > RX51.
> 
> Well, I don't *want* to wait because that means I would have to rework
> these patches.  :)  
> 
> But it sounds waiting is the right thing.  How close are you to having
> the new scripting stuff ready?  Should we put it into the PM branch in
> the meantime so it can get some testing on other boards than RX51?
> 
> Kevin

Kevin,

I take back my objections to these patches. On studying the current state of
the scripts it looks like the feature allowing overlapping scripts to work
around space constraints might no longer be necessary after the conversion of
the scripts to use broadcast messages instead of the singular ones. <whew>

I'll push the optimised scripts shortly.

Acked-by: Amit Kucheria <amit.kucheria@verdurent.com>

-- 
-------------------------------------------------------------------------
Amit Kucheria,				 Kernel Developer, Verdurent
-------------------------------------------------------------------------