From: Tony Lindgren <tony@atomide.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Venkatraman S <svenkatr@ti.com>,
Anuj Aggarwal <anuj.aggarwal@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] SDMA: Fixing bug in omap_dma_set_global_params()
Date: Wed, 7 Oct 2009 15:03:54 -0700 [thread overview]
Message-ID: <20091007220354.GC29320@atomide.com> (raw)
In-Reply-To: <20091007083836.89b48fbd.rdunlap@xenotime.net>
* Randy Dunlap <rdunlap@xenotime.net> [091007 08:38]:
> On Wed, 7 Oct 2009 14:48:26 +0530 Venkatraman S wrote:
>
> > On Mon, Oct 5, 2009 at 10:11 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > > On Mon, 5 Oct 2009 14:12:43 +0530 Anuj Aggarwal wrote:
> > >
> > >> Argument tparams was not being used to program
> > >> global register GCR.HI_THREAD_RESERVED. This patch fixes the same.
> > >>
> > >> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> > >> ---
> > >> arch/arm/plat-omap/dma.c | 15 +++++++++------
> > >> 1 files changed, 9 insertions(+), 6 deletions(-)
> > >
> > >
> > > Hi,
> > > Someone please convert all of this source file to correct kernel-doc notation.
> > >
> > > Thanks.
> > >
> >
> > I now have this on my TODO list. As a bug fix, shouldn't this be
> > pulled in and the doc updates for all the functions can be done as a
> > separate patch ?
>
> Yes. Thanks.
Will add this fix to my omap-fixes queue.
Tony
>
> > Anuj,
> > Can you please correct the comments for this function to proper
> > format along with your changes ?
> >
> > Thanks,
> > Venkat.
>
>
> ---
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-07 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 8:42 [PATCH v2] SDMA: Fixing bug in omap_dma_set_global_params() Anuj Aggarwal
2009-10-05 16:41 ` Randy Dunlap
2009-10-07 9:18 ` Venkatraman S
2009-10-07 15:38 ` Randy Dunlap
2009-10-07 22:03 ` Tony Lindgren [this message]
2009-10-07 22:07 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007220354.GC29320@atomide.com \
--to=tony@atomide.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).