From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: ext Tony Lindgren <tony@atomide.com>,
"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
ALSA-Devel <alsa-devel@vger.kernel.org>
Subject: Re: [PATCH 8/8] ASoC: tpa6130a2: Control vdd using regulator framework
Date: Thu, 8 Oct 2009 14:43:33 +0100 [thread overview]
Message-ID: <20091008134332.GI29176@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1255003137-1034-9-git-send-email-eduardo.valentin@nokia.com>
On Thu, Oct 08, 2009 at 02:58:57PM +0300, Eduardo Valentin wrote:
> + data->regulator = regulator_get(dev, "vdd");
> + if (IS_ERR(data->regulator)) {
> + dev_info(dev, "Could not get regulator for vdd. "
> + "Executing without regulator.\n");
> + data->regulator = NULL;
> + }
Similar comments to the previous patch apply to this driver - regulator
usage should be unconditional, error messages should not be split over
multiple lines and you should represent all the supplies separately (it
looks like there's both VDD and CPVSS required here, for example) to
avoid future surprises.
next prev parent reply other threads:[~2009-10-08 13:43 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 11:58 [PATCH 0/8] RX-51 audio drivers Eduardo Valentin
2009-10-08 11:58 ` [PATCH 1/8] ASoC: TPA6130A2 amplifier driver Eduardo Valentin
2009-10-08 12:30 ` Eero Nurkkala
2009-10-08 13:07 ` Peter Ujfalusi
2009-10-08 12:52 ` Mark Brown
2009-10-08 13:38 ` Peter Ujfalusi
2009-10-08 13:53 ` Mark Brown
2009-10-09 6:53 ` Peter Ujfalusi
2009-10-09 10:36 ` Mark Brown
2009-10-08 11:58 ` [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver Eduardo Valentin
2009-10-08 12:31 ` Eero Nurkkala
2009-10-08 13:18 ` Eduardo Valentin
2009-10-08 13:11 ` Mark Brown
2009-10-09 5:44 ` Jarkko Nikula
2009-10-09 6:37 ` Eduardo Valentin
2009-10-09 12:19 ` Mark Brown
2009-10-08 11:58 ` [PATCH 3/8] McBSP: OMAP3: Add Sidetone feature Eduardo Valentin
2009-10-08 13:17 ` Mark Brown
2009-10-08 13:23 ` Eduardo Valentin
2009-10-08 13:27 ` Mark Brown
2009-10-09 5:09 ` Eero Nurkkala
2009-10-09 10:44 ` [alsa-devel] " Mark Brown
2009-10-12 6:17 ` Eero Nurkkala
2009-10-12 9:12 ` Mark Brown
2009-10-12 9:28 ` Eero Nurkkala
2009-10-12 9:32 ` Mark Brown
2009-10-12 10:28 ` Eero Nurkkala
2009-10-12 10:33 ` Mark Brown
2009-10-08 11:58 ` [PATCH 4/8] OMAP: RX51: Add audio board file Eduardo Valentin
2009-10-08 11:58 ` [PATCH 5/8] board-rx51-peripherals: split vaux3 and vmmc2 supplies Eduardo Valentin
2009-10-08 13:21 ` Mark Brown
2009-10-09 6:45 ` Eduardo Valentin
2009-10-09 11:03 ` Mark Brown
2009-10-12 8:08 ` Eduardo Valentin
2009-10-12 9:18 ` Mark Brown
2009-10-14 17:15 ` Tony Lindgren
2009-10-15 9:01 ` Mark Brown
2009-10-16 16:14 ` Tony Lindgren
2009-10-08 11:58 ` [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2 Eduardo Valentin
2009-10-08 13:26 ` Mark Brown
2009-10-12 9:04 ` Eduardo Valentin
2009-10-12 9:21 ` Mark Brown
2009-10-19 9:13 ` Eduardo Valentin
2009-10-19 9:23 ` Mark Brown
2009-10-19 9:24 ` Mark Brown
2009-10-08 11:58 ` [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac Eduardo Valentin
2009-10-08 12:17 ` Eero Nurkkala
2009-10-08 13:17 ` Eduardo Valentin
2009-10-08 13:40 ` Mark Brown
2009-10-08 15:44 ` ext-Eero.Nurkkala
2009-10-08 16:01 ` Mark Brown
2009-10-09 4:28 ` Eero Nurkkala
2009-10-09 10:19 ` Mark Brown
2009-10-08 13:38 ` Mark Brown
2009-10-08 11:58 ` [PATCH 8/8] ASoC: tpa6130a2: Control vdd using regulator framework Eduardo Valentin
2009-10-08 13:43 ` Mark Brown [this message]
2009-10-08 13:56 ` Eduardo Valentin
2009-10-08 14:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008134332.GI29176@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).