From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduardo Valentin <eduardo.valentin@nokia.com>
Subject: Re: [PATCH 8/8] ASoC: tpa6130a2: Control vdd using
 regulator framework
Date: Thu, 8 Oct 2009 16:56:28 +0300
Message-ID: <20091008135628.GA6616@esdhcp037198.research.nokia.com>
References: <1255003137-1034-1-git-send-email-eduardo.valentin@nokia.com>
	<1255003137-1034-9-git-send-email-eduardo.valentin@nokia.com>
	<20091008134332.GI29176@rakim.wolfsonmicro.main>
Reply-To: eduardo.valentin@nokia.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Content-Disposition: inline
In-Reply-To: <20091008134332.GI29176@rakim.wolfsonmicro.main>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: alsa-devel@alsa-project.org
Cc: ext Tony Lindgren <tony@atomide.com>, "Valentin Eduardo (Nokia-D/Helsinki)" <eduardo.valentin@nokia.com>, "Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>, "Nurkkala Eero.An (EXT-Offcode/Oulu)" <ext-Eero.Nurkkala@nokia.com>, Linux-OMAP <linux-omap@vger.kernel.org>, ALSA-Devel <alsa-devel@vger.kernel.org>
List-Id: linux-omap@vger.kernel.org

On Thu, Oct 08, 2009 at 03:43:33PM +0200, Mark Brown wrote:
> On Thu, Oct 08, 2009 at 02:58:57PM +0300, Eduardo Valentin wrote:
> 
> > +	data->regulator = regulator_get(dev, "vdd");
> > +	if (IS_ERR(data->regulator)) {
> > +		dev_info(dev, "Could not get regulator for vdd. "
> > +					"Executing without regulator.\n");
> > +			data->regulator = NULL;
> > +	}
> 
> Similar comments to the previous patch apply to this driver - regulator
> usage should be unconditional, error messages should not be split over
> multiple lines and you should represent all the supplies separately (it
> looks like there's both VDD and CPVSS required here, for example) to
> avoid future surprises.


Yeah. The idea here was to keep driver running even if regulators
are not properly set in board files. Maybe those in which the regulator
is always on. That's why I wrote it with "nicely" message.

-- 
Eduardo Valentin