From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver Date: Fri, 9 Oct 2009 09:37:20 +0300 Message-ID: <20091009063720.GC6616@esdhcp037198.research.nokia.com> References: <1255003137-1034-1-git-send-email-eduardo.valentin@nokia.com> <1255003137-1034-3-git-send-email-eduardo.valentin@nokia.com> <20091008131116.GB29176@rakim.wolfsonmicro.main> <20091009084400.34df690a.jhnikula@gmail.com> Reply-To: eduardo.valentin@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.nokia.com ([192.100.122.233]:55605 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756791AbZJIGi4 (ORCPT ); Fri, 9 Oct 2009 02:38:56 -0400 Content-Disposition: inline In-Reply-To: <20091009084400.34df690a.jhnikula@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Jarkko Nikula Cc: Mark Brown , "Valentin Eduardo (Nokia-D/Helsinki)" , ext Tony Lindgren , "Ujfalusi Peter (Nokia-D/Tampere)" , "Nurkkala Eero.An (EXT-Offcode/Oulu)" , Linux-OMAP , ALSA-Devel On Fri, Oct 09, 2009 at 07:44:00AM +0200, Jarkko Nikula wrote: > On Thu, 8 Oct 2009 14:11:16 +0100 > Mark Brown wrote: > > > What is an "AIC34b_dummy (block B)"? You probably want to split it out > > into a separate patch. > > > I think this is the reason why Eduardo mentioned my name in the commit > log :-) Yeah, I mentioned Jarkko because he was the person who initially wrote those drivers :-). But I can split then if you prefer. No problem. > > Yep, dummy driver is for block B of AIC34 which is basically dual AIC33 > in a same package. Yes. This is correct. > > > > + * TODO: > > > + * - Get rid of this driver, at least when ASoC v2 is merged and when > > > + * we can support multiple codec instances in tlv320aic3x.c driver. > > > + * This driver is hacked only for Nokia RX51 HW. > > > > Could you please explain what the issue here is? A description of the > > hardware would go a long way here. > > > Eduardo, please correct me if I remember wrong but block B of AIC34 is > not used as an codec as such but more like an amplifier and analogic > mixer with digital parts unused. So with this dummy driver the HW > features were easier to support than to develop multiple intance > support for codec drivers. Yes. This is also correct. It is more like an amplifier / mixer. I think that's why you named it dummy :-). But I think I should add this info as a comment inside the code. > > > -- > Jarkko -- Eduardo Valentin