From: Tony Lindgren <tony@atomide.com>
To: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: "Menon, Nishanth" <nm@ti.com>,
linux-omap <linux-omap@vger.kernel.org>,
"Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>,
"Pandita, Vikram" <vikram.pandita@ti.com>,
"Pais, Allen" <allen.pais@ti.com>,
"Gadiyar, Anand" <gadiyar@ti.com>,
"Cousson, Benoit" <b-cousson@ti.com>,
Felipe Balbi <felipe.balbi@nokia.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
"Premi, Sanjeev" <premi@ti.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v3] OMAP3: introduce OMAP3630
Date: Fri, 9 Oct 2009 10:53:15 -0700 [thread overview]
Message-ID: <20091009175314.GI25892@atomide.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE89444CC6C59E@dlee02.ent.ti.com>
* Aguirre Rodriguez, Sergio Alberto <saaguirre@ti.com> [091009 06:55]:
> Nishanth,
>
> From: Menon, Nishanth
> Sent: Thursday, October 08, 2009 6:47 PM
>
> <snip>
>
> > diff --git a/arch/arm/plat-omap/include/mach/cpu.h
> > b/arch/arm/plat-omap/include/mach/cpu.h
> > index 431fec4..af1080f 100644
> > --- a/arch/arm/plat-omap/include/mach/cpu.h
> > +++ b/arch/arm/plat-omap/include/mach/cpu.h
> > @@ -383,6 +383,12 @@ IS_OMAP_TYPE(3430, 0x3430)
> > #define OMAP3430_REV_ES2_1 0x34302034
> > #define OMAP3430_REV_ES3_0 0x34303034
> > #define OMAP3430_REV_ES3_1 0x34304034
> > +/* NOTE: Add 36xx series below
> > + * If additional 34xx series are added, OMAP3430_REV_ESXXXX can be
> > + * added above the 3630 defines and series renumbered to ensure
> > + * rev() > checks to work
> > + */
> > +#define OMAP3630_REV_ES1_0 0x34305034
>
> Just for the sake of curiosity...
>
> Why not defining 3630 like this?
>
> #define OMAP3630_REV_ES1_0 0x36301034
>
> Sorry if i'm asking something dumb.
Because it's still considered 34xx class chip with
some extra features. It compiles with the same settings,
and uses the same kernel code. So from kernel point of
view we can treat it as 34xx.
Regards,
Tony
next prev parent reply other threads:[~2009-10-09 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 23:47 [PATCH v3] OMAP3: introduce OMAP3630 Nishanth Menon
2009-10-09 13:55 ` Aguirre Rodriguez, Sergio Alberto
2009-10-09 17:53 ` Tony Lindgren [this message]
2009-10-09 18:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009175314.GI25892@atomide.com \
--to=tony@atomide.com \
--cc=allen.pais@ti.com \
--cc=b-cousson@ti.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=nm@ti.com \
--cc=premi@ti.com \
--cc=saaguirre@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox