From: Tony Lindgren <tony@atomide.com>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: nm@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: Fix 35xx detection (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero)
Date: Tue, 13 Oct 2009 12:09:34 -0700 [thread overview]
Message-ID: <20091013190934.GX12700@atomide.com> (raw)
In-Reply-To: <20091013173233.GU12700@atomide.com>
* Tony Lindgren <tony@atomide.com> [091013 11:01]:
> * Tony Lindgren <tony@atomide.com> [091013 10:18]:
> > * Vikram Pandita <vikram.pandita@ti.com> [091012 14:31]:
> > > make default cpu_is_omap3630() return zero
> > >
> > > Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> > > ---
> > > arch/arm/plat-omap/include/mach/cpu.h | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat-omap/include/mach/cpu.h
> > > index da9e8f8..940946e 100644
> > > --- a/arch/arm/plat-omap/include/mach/cpu.h
> > > +++ b/arch/arm/plat-omap/include/mach/cpu.h
> > > @@ -322,6 +322,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> > > #define cpu_is_omap2423() 0
> > > #define cpu_is_omap2430() 0
> > > #define cpu_is_omap3430() 0
> > > +#define cpu_is_omap3630() 0
> > >
> > > /*
> > > * Whether we have MULTI_OMAP1 or not, we still need to distinguish
> > > @@ -386,6 +387,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> > > (omap3_has_sgx()) & \
> > > (!omap3_has_iva()))
> > > # define cpu_is_omap3530 (cpu_is_omap3430())
> > > +# undef cpu_is_omap3630()
> > > # define cpu_is_omap3630() is_omap363x()
> > > #endif
> >
> > This undef should be just undef cpu_is_omap3630 instead of
> > cpu_is_omap3630().
>
> Also looking at the 35xx detection code, should it not be like this?
I've merged all these fixes into the 35xx and 36xx detection patches
in omap for-next branch, can you guys please check?
Regards,
Tony
prev parent reply other threads:[~2009-10-13 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 20:51 [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero Vikram Pandita
2009-10-12 21:05 ` Menon, Nishanth
2009-10-12 21:07 ` Pandita, Vikram
2009-10-12 21:09 ` Menon, Nishanth
2009-10-13 10:03 ` Shilimkar, Santosh
2009-10-13 10:14 ` Nishanth Menon
2009-10-13 17:15 ` Tony Lindgren
2009-10-13 17:43 ` [PATCH] omap: Fix cpu_is_omap35xx default defines (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero) Tony Lindgren
2009-10-13 17:18 ` [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero Tony Lindgren
2009-10-13 17:32 ` [PATCH] omap: Fix 35xx detection (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero) Tony Lindgren
2009-10-13 18:31 ` Nishanth Menon
2009-10-13 19:09 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013190934.GX12700@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox