public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5
@ 2009-10-14 22:31 Paul Walmsley
  2009-10-14 22:31 ` [PATCH 2/2] OMAP2xxx clock: set up clockdomain pointer in struct clk Paul Walmsley
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Paul Walmsley @ 2009-10-14 22:31 UTC (permalink / raw)
  To: linux-omap; +Cc: linux-arm-kernel

Hello,

This series contains:

- one OMAP2 clock fix that allows N800 to boot further (there are unrelated
  problems with both the current linux-omap head and omap-fixes branch that
  cause booting to fail due to other reasons), and

- one OMAP2/3 clockdomain fix that can cause clockdomain transitions to be
  missed by the clockdomain code -- this mostly affects OMAP3 OFF mode.

These patches are also available as a git branch (based on Tony's omap-fixes
branch) from

  git://git.pwsan.com/linux-2.6 2_6_32rc4_fixes


- Paul

---

Kalle Jokiniemi (1):
      OMAP: Fix race condition with autodeps

Paul Walmsley (1):
      OMAP2xxx clock: set up clockdomain pointer in struct clk


 arch/arm/mach-omap2/clock24xx.c   |    1 +
 arch/arm/mach-omap2/clockdomain.c |   74 ++++++++++++++++++++++---------------
 2 files changed, 45 insertions(+), 30 deletions(-)

size:
   text	   data	    bss	    dec	    hex	filename
3588474	 198624	 105152	3892250	 3b641a	vmlinux.omap3beagle.orig
3588562	 198624	 105152	3892338	 3b6472	vmlinux.omap3beagle.patched


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] OMAP2xxx clock: set up clockdomain pointer in struct clk
  2009-10-14 22:31 [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
@ 2009-10-14 22:31 ` Paul Walmsley
  2009-10-14 23:30 ` [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
  2009-10-15  0:24 ` Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2009-10-14 22:31 UTC (permalink / raw)
  To: linux-omap
  Cc: Tony Lindgren, Stefano Panella, Carlos Aguiar, linux-arm-kernel

clock24xx.c is missing a omap2_init_clk_clkdm() in its
omap2_clk_init() function.  Among other bad effects, this causes the
OMAP hwmod layer to oops on boot.

Thanks to Carlos Aguiar <carlos.aguiar@indt.org.br> and Stefano
Panella <Stefano.Panella@csr.com> for reporting this bug.  Thanks to Tony
Lindgren <tony@atomide.com> for N800 booting advice.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Carlos Aguiar <carlos.aguiar@indt.org.br>
Cc: Stefano Panella <Stefano.Panella@csr.com>
Cc: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/clock24xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock24xx.c b/arch/arm/mach-omap2/clock24xx.c
index bc5d3ac..e2dbedd 100644
--- a/arch/arm/mach-omap2/clock24xx.c
+++ b/arch/arm/mach-omap2/clock24xx.c
@@ -769,6 +769,7 @@ int __init omap2_clk_init(void)
 		if (c->cpu & cpu_mask) {
 			clkdev_add(&c->lk);
 			clk_register(c->lk.clk);
+			omap2_init_clk_clkdm(c->lk.clk);
 		}
 
 	/* Check the MPU rate set by bootloader */



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5
  2009-10-14 22:31 [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
  2009-10-14 22:31 ` [PATCH 2/2] OMAP2xxx clock: set up clockdomain pointer in struct clk Paul Walmsley
@ 2009-10-14 23:30 ` Paul Walmsley
  2009-10-15  0:24 ` Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2009-10-14 23:30 UTC (permalink / raw)
  To: linux-omap; +Cc: linux-arm-kernel


Time for a subject line correction of my own: Kevin kindly pointed out 
that the subject should read "2.6.32-rc5"


- Paul

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5
  2009-10-14 22:31 [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
  2009-10-14 22:31 ` [PATCH 2/2] OMAP2xxx clock: set up clockdomain pointer in struct clk Paul Walmsley
  2009-10-14 23:30 ` [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
@ 2009-10-15  0:24 ` Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2009-10-15  0:24 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: linux-omap, linux-arm-kernel

* Paul Walmsley <paul@pwsan.com> [091014 15:36]:
> Hello,
> 
> This series contains:
> 
> - one OMAP2 clock fix that allows N800 to boot further (there are unrelated
>   problems with both the current linux-omap head and omap-fixes branch that
>   cause booting to fail due to other reasons), and
> 
> - one OMAP2/3 clockdomain fix that can cause clockdomain transitions to be
>   missed by the clockdomain code -- this mostly affects OMAP3 OFF mode.
> 
> These patches are also available as a git branch (based on Tony's omap-fixes
> branch) from
> 
>   git://git.pwsan.com/linux-2.6 2_6_32rc4_fixes

I've pulled these on top of the fixes I posted yesterday.

Regards,

Tony
 
> 
> - Paul
> 
> ---
> 
> Kalle Jokiniemi (1):
>       OMAP: Fix race condition with autodeps
> 
> Paul Walmsley (1):
>       OMAP2xxx clock: set up clockdomain pointer in struct clk
> 
> 
>  arch/arm/mach-omap2/clock24xx.c   |    1 +
>  arch/arm/mach-omap2/clockdomain.c |   74 ++++++++++++++++++++++---------------
>  2 files changed, 45 insertions(+), 30 deletions(-)
> 
> size:
>    text	   data	    bss	    dec	    hex	filename
> 3588474	 198624	 105152	3892250	 3b641a	vmlinux.omap3beagle.orig
> 3588562	 198624	 105152	3892338	 3b6472	vmlinux.omap3beagle.patched
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-10-15  0:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-14 22:31 [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
2009-10-14 22:31 ` [PATCH 2/2] OMAP2xxx clock: set up clockdomain pointer in struct clk Paul Walmsley
2009-10-14 23:30 ` [PATCH 0/2] OMAP clock and clockdomain fixes for 2.6.29-rc5 Paul Walmsley
2009-10-15  0:24 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox