From: Tony Lindgren <tony@atomide.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"S, Venkatraman" <svenkatr@ti.com>, Hari n <hari.zoom@gmail.com>,
Jarkko Nikula <jhnikula@gmail.com>
Subject: Re: [PATCH] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking
Date: Thu, 15 Oct 2009 11:40:16 -0700 [thread overview]
Message-ID: <20091015184016.GI14531@atomide.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02BB37CC9F@dbde02.ent.ti.com>
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [091014 21:40]:
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony@atomide.com]
> > Sent: Wednesday, October 14, 2009 10:36 PM
> > To: Shilimkar, Santosh
> > Cc: linux-omap@vger.kernel.org; S, Venkatraman; Hari n; Jarkko Nikula
> > Subject: Re: [PATCH] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel
> > linking
> >
> > * Santosh Shilimkar <santosh.shilimkar@ti.com> [091013 23:14]:
> > > OMAP sDMA driver API omap_stop_dma() doesn't really stop the dma when
> > used
> > > in linking scenario. This patch fixes the same.
> >
> > To me it looks like this will break things for omap1 as the DMA channel
> > interrupt is not disabled first. I guess the fix is to move the
> > "Disable all interrupts on the channel" part above clearing the
> > link mappings.
> Indeed it will break OMAP1. Initially I thought of putting this change at this place so that it takes care of both normal and linking scenario.
>
> I will rework this and send v2.
OK, thanks.
> > This fix should be tested in linux-omap before we send this to mainline.
> Yes ofcourse. That what I meant by merge.
Yeah, we should still have enough time to get it into mainline kernel
as a fix during this -rc cycle.
Regards,
Tony
next prev parent reply other threads:[~2009-10-15 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 6:14 [PATCH] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking Santosh Shilimkar
2009-10-14 6:14 ` [PATCH] ARM: OMAP4: Allow omap_serial_early_init() for OMAP4430 board Santosh Shilimkar
2009-10-14 6:14 ` [PATCH] ARM: OMAP4: Fix UART4 platform data Santosh Shilimkar
2009-10-19 17:28 ` [APPLIED] " Tony Lindgren
2009-10-19 17:25 ` [APPLIED] [PATCH] ARM: OMAP4: Allow omap_serial_early_init() for OMAP4430 Tony Lindgren
2009-10-14 17:06 ` [PATCH] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking Tony Lindgren
2009-10-15 4:40 ` Shilimkar, Santosh
2009-10-15 18:40 ` Tony Lindgren [this message]
2009-10-16 5:07 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015184016.GI14531@atomide.com \
--to=tony@atomide.com \
--cc=hari.zoom@gmail.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).