RE: [PATCH 08/14] omap: Use ioremap for omap4 L4 code

Shilimkar, Santosh
2009-10-19T07:28:00Z

Tony,
> -----Original Message-----
> From: Tony Lindgren [mailto:tony@atomide.com]
> Sent: Monday, October 19, 2009 5:54 AM
> To: Shilimkar, Santosh
> Cc: linux-arm-kernel@lists.infradead.org; linux-omap@vger.kernel.org
> Subject: Re: [PATCH 08/14] omap: Use ioremap for omap4 L4 code
>
> * Tony Lindgren <tony@atomide.com> [091017 09:19]:
> > * Shilimkar, Santosh <santosh.shilimkar@ti.com> [091017 03:49]:
> > > Thanks Tony for this ioremap series!!
> > >
> > > > -----Original Message-----
> > > > From: Tony Lindgren [mailto:tony@atomide.com]
> > > > Sent: Saturday, October 17, 2009 5:16 AM
> > > > To: linux-arm-kernel@lists.infradead.org
> > > > Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh
> > > > Subject: Re: [PATCH 08/14] omap: Use ioremap for omap4 L4 code
> > > >
> > > > * Tony Lindgren <tony@atomide.com> [091016 16:42]:
> > > > > Use ioremap for omap4 L4 code
> > > >
> > > > Santosh, can you please check and ack this patch?
> > > >
> > > > Especially some of the ioremap sizes may be wrong. Also, this one
> > > > I cannot boot test, so it's just compile tested.
> > >
> > > I have checked the patch and it looks all right except few typo. Also
> the scu_base is needed bit earlier.
>
> <snip>
>
> > > Here is the patch on top of ioremap series which should fix above
> mentioned things. With below patch + two serial related patches the kernel
> boots on OMAP4430.
> >
> > Great, will update. Thanks for taking the time to fix it!
>
> Here's this one updated with Santosh's fix merged in.
V2 has one typo which I think I also missed in my patch.
>+ /* Static mapping, never released */
>+ gic_cpu_base_addr = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512);
>+ BUG_ON(!base);
Should be BUG_ON(!gic_cpu_base_addr);

Regards,
Santosh