* Bug on "omap: ioremap fixes for omap4"
@ 2009-10-19 15:54 Aguirre Rodriguez, Sergio Alberto
2009-10-19 17:12 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Aguirre Rodriguez, Sergio Alberto @ 2009-10-19 15:54 UTC (permalink / raw)
To: Shilimkar, Santosh, Tony Lindgren; +Cc: linux-omap@vger.kernel.org
Tony, Santosh,
I think there's a missing fix in this commit:
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=041b80d9a00ab741ce50db92c84b6bed554fc3b6
Here:
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 50a62f2..4b644a9 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -60,9 +60,9 @@ static void __init gic_init_irq(void)
> gic_dist_init(0, base, 29);
>
> /* Static mapping, never released */
> - base = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_256);
> + gic_cpu_base_addr = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512);
> BUG_ON(!base);
Shouldn't it be:
BUG_ON(!gic_cpu_base_addr);
Instead?
> - gic_cpu_init(0, OMAP44XX_GIC_CPU_BASE);
> + gic_cpu_init(0, gic_cpu_base_addr);
> }
>
> static void __init omap_4430sdp_init_irq(void)
Regards,
Sergio
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug on "omap: ioremap fixes for omap4"
2009-10-19 15:54 Bug on "omap: ioremap fixes for omap4" Aguirre Rodriguez, Sergio Alberto
@ 2009-10-19 17:12 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2009-10-19 17:12 UTC (permalink / raw)
To: Aguirre Rodriguez, Sergio Alberto
Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org
* Aguirre Rodriguez, Sergio Alberto <saaguirre@ti.com> [091019 08:54]:
> Tony, Santosh,
>
> I think there's a missing fix in this commit:
>
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=041b80d9a00ab741ce50db92c84b6bed554fc3b6
>
> Here:
>
> > diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> > index 50a62f2..4b644a9 100644
> > --- a/arch/arm/mach-omap2/board-4430sdp.c
> > +++ b/arch/arm/mach-omap2/board-4430sdp.c
> > @@ -60,9 +60,9 @@ static void __init gic_init_irq(void)
> > gic_dist_init(0, base, 29);
> >
> > /* Static mapping, never released */
> > - base = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_256);
> > + gic_cpu_base_addr = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512);
> > BUG_ON(!base);
>
> Shouldn't it be:
>
> BUG_ON(!gic_cpu_base_addr);
>
> Instead?
>
> > - gic_cpu_init(0, OMAP44XX_GIC_CPU_BASE);
> > + gic_cpu_init(0, gic_cpu_base_addr);
> > }
> >
> > static void __init omap_4430sdp_init_irq(void)
Yeah thanks, I've posted a refreshed patch for that
and pushed the fix to linux-omap master and for-next
branches.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-19 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-19 15:54 Bug on "omap: ioremap fixes for omap4" Aguirre Rodriguez, Sergio Alberto
2009-10-19 17:12 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).