public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	e3-hacking@earth.li
Subject: Re: [PATCH] Fix broken NAND on Amstrad Delta
Date: Wed, 21 Oct 2009 08:54:58 -0700	[thread overview]
Message-ID: <20091021155457.GI16230@atomide.com> (raw)
In-Reply-To: <200910211253.51518.jkrzyszt@tis.icnet.pl>

* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [091021 03:54]:
> Wednesday 21 October 2009 02:51:35 Tony Lindgren wrote:
> >
> > Let's just remove the omap_cfg_reg() calls from mach-omap1/serial.c, and
> > add them to the board-*.c files like you suggest above. We should be able
> > to find which ports to mux by looking at the enabled_uarts mask in the
> > commit mentioned above.
> 
> Tony,
> I can prepare a patch if you haven't started working on it yet, but please do 
> me a favour and give your comments on another, old but still not answered 
> subject:

Yes, please do that patch if you can!
 
> http://www.spinics.net/lists/linux-omap/msg17692.html
> I have just checked that temporary solution still applies cleanly on top of 
> 2.6.32-rc5 and corrects the problem of otherwise unusable ASoC over McBSP1 on 
> my Amstrad Delta.

Well let's try to work that in for this coming merge window.

How about we rename it to dsp-c55x-common.c? And only do the minimal bits
to idle the DSP if called from the board-*.c file?

The rest we can move to the old dspgateway branch and rebase that to
the current kernel.

I think the right way would be to update the dspgateway to use the iommu
code, so let's not add similar code except to idle the c55x.

Regards,

Tony

  reply	other threads:[~2009-10-21 15:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21  0:39 [PATCH] Fix broken NAND on Amstrad Delta Janusz Krzysztofik
2009-10-21  0:51 ` Tony Lindgren
2009-10-21 10:53   ` Janusz Krzysztofik
2009-10-21 15:54     ` Tony Lindgren [this message]
2009-10-21 16:27   ` [PATCH] OMAP1: fix redundant UARTs pin muxing that can break other hardware support Janusz Krzysztofik
2009-10-22 18:43     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091021155457.GI16230@atomide.com \
    --to=tony@atomide.com \
    --cc=e3-hacking@earth.li \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox