From: Felipe Balbi <me@felipebalbi.com>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] omap: zoom3: add zoom3 board support
Date: Sat, 24 Oct 2009 02:03:48 +0300 [thread overview]
Message-ID: <20091023230348.GC13020@gandalf> (raw)
In-Reply-To: <1256325806-14400-4-git-send-email-vikram.pandita@ti.com>
Hi,
On Fri, Oct 23, 2009 at 02:23:26PM -0500, Vikram Pandita wrote:
> diff --git a/arch/arm/mach-omap2/board-zoom2-zoom3.c b/arch/arm/mach-omap2/board-zoom2-zoom3.c
> index 4ad9b94..d806dbf 100644
> --- a/arch/arm/mach-omap2/board-zoom2-zoom3.c
> +++ b/arch/arm/mach-omap2/board-zoom2-zoom3.c
> @@ -281,7 +281,11 @@ static void __init omap_zoom2_map_io(void)
> omap2_map_common_io();
> }
>
> +#ifdef CONFIG_MACH_OMAP_ZOOM3
> +MACHINE_START(OMAP_ZOOM3, "OMAP ZOOM3 board")
> +#else
> MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board")
> +#endif
what happens if you want to build a kernel for both boards ?
how about just adding a new MACHINE_START() declaration without
ifdeferry ?
Take a look at arch/arm/mach-omap2/board-n8x0.c for an example ;-)
--
balbi
next prev parent reply other threads:[~2009-10-23 23:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 19:23 [PATCH 0/3] Introduce Zoom3 board Vikram Pandita
2009-10-23 19:23 ` [PATCH 1/3] omap: zoom: reuse zoom2 board file for zoom3 Vikram Pandita
2009-10-23 19:23 ` [PATCH 2/3] omap: zoom2: update makefile for boardfile name change Vikram Pandita
2009-10-23 19:23 ` [PATCH 3/3] omap: zoom3: add zoom3 board support Vikram Pandita
2009-10-23 19:39 ` Aguirre Rodriguez, Sergio Alberto
2009-10-23 19:46 ` Nishanth Menon
2009-10-23 20:07 ` Aguirre Rodriguez, Sergio Alberto
2009-10-23 21:17 ` Nishanth Menon
2009-10-23 23:06 ` Felipe Balbi
2009-10-23 23:03 ` Felipe Balbi [this message]
2009-10-27 21:36 ` Pandita, Vikram
2009-10-28 12:12 ` Welcome: OMAPZoom Tutorial Hour Pandita, Vikram
2009-10-23 23:01 ` [PATCH 1/3] omap: zoom: reuse zoom2 board file for zoom3 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023230348.GC13020@gandalf \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox