From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>
Subject: Re: [alsa-devel] [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode
Date: Tue, 27 Oct 2009 14:04:31 +0200 [thread overview]
Message-ID: <200910271404.31484.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20091027120009.GA19323@rakim.wolfsonmicro.main>
On Tuesday 27 October 2009 14:00:09 ext Mark Brown wrote:
>
> I have to confess that I'm still not entirely clear what the lock is
> supposed to be doing or why it's OK to drop it. I gather that it's just
> that dmap_on_mode() doesn't need a lock at all?
In my opinion it does not need a lock.
If the user space is so broken that it is doing different things in parallel, I
would rather crash the kernel if it is possible to force someone to fix the mess
upstairs.
But the lock is not needed, I think it was a result of over-engineering.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-27 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 11:00 [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode Peter Ujfalusi
2009-10-27 11:07 ` Eero Nurkkala
2009-10-27 11:17 ` Peter Ujfalusi
2009-10-27 12:00 ` Mark Brown
2009-10-27 12:04 ` Eero Nurkkala
2009-10-27 12:04 ` Peter Ujfalusi [this message]
2009-10-27 14:00 ` [alsa-devel] " Jarkko Nikula
2009-10-28 5:52 ` Peter Ujfalusi
2009-10-28 6:53 ` Eero Nurkkala
2009-10-29 6:35 ` Peter Ujfalusi
2009-10-29 7:15 ` [alsa-devel] " Jarkko Nikula
2009-11-09 7:49 ` Peter Ujfalusi
2009-11-09 13:18 ` Mark Brown
2009-10-29 7:13 ` [alsa-devel] " Jarkko Nikula
2009-11-12 22:17 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910271404.31484.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox