From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/2] AM35xx: Runtime detection of the device Date: Wed, 28 Oct 2009 22:17:27 +0200 Message-ID: <20091028201727.GA3773@nokia.com> References: <1256652150-5710-1-git-send-email-premi@ti.com> <20091027161115.GA16494@nokia.com> <20091027210853.GA17061@nokia.com> <20091028165918.GD8820@nokia.com> Reply-To: felipe.balbi@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.nokia.com ([192.100.122.233]:35367 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755021AbZJ2APN (ORCPT ); Wed, 28 Oct 2009 20:15:13 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "ext Premi, Sanjeev" Cc: "Balbi Felipe (Nokia-D/Helsinki)" , "linux-omap@vger.kernel.org" , "tony@atomide.com" Hi, On Wed, Oct 28, 2009 at 07:42:07PM +0100, ext Premi, Sanjeev wrote: > > On Wed, Oct 28, 2009 at 01:40:04PM +0100, ext Premi, Sanjeev wrote: > > > > case 0xb891: > > > > - /* Handle 36xx devices */ > > > > - switch (rev) { > > > > - case 0: > > > > - omap_revision = OMAP3630_REV_ES1_0; > > > > - break; > > > > - default: > > > > - /* Use the latest known revision as default */ > > > > - omap_revision = OMAP3630_REV_ES1_0; > > > > - } > > > > - break; > > > > + /* FALLTHROUGH */ > > > > default: > > > > /* Unknown default to latest silicon rev as default*/ > > > > omap_revision = OMAP3630_REV_ES1_0; > > > > > > [sp] Haven't applied the patch. But, if FALLTHROUGH will > > make the device > > > detected as OMAP3630, then it may not be right. The > > fall through > > > should be on most common device. OMAP3430 ES21./3.1 > > should be ideal. > > > > > > Thoughts? > > > > see that I didn't change the default clause. It was already > > OMAP3630_REV_ES1_0. If it has to be anything else, the > > default should be > > changed and the case 0xb891: should do: > > I did see that. But since you were already proposing a change > thought it would be good idea. if Tony says it's ok, I can change the patch, for sure :-) but I believe he will want that as a separate patch for bisectability. -- balbi