From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [alsa-devel] [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode Date: Thu, 29 Oct 2009 09:15:24 +0200 Message-ID: <20091029091524.a663e4e5.jhnikula@gmail.com> References: <1256641215-26131-1-git-send-email-peter.ujfalusi@nokia.com> <200910280752.23859.peter.ujfalusi@nokia.com> <1256712814.30157.388.camel@eenurkka-desktop> <200910290835.51475.peter.ujfalusi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f227.google.com ([209.85.218.227]:35285 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756559AbZJ2HOf (ORCPT ); Thu, 29 Oct 2009 03:14:35 -0400 Received: by bwz27 with SMTP id 27so1922065bwz.21 for ; Thu, 29 Oct 2009 00:14:39 -0700 (PDT) In-Reply-To: <200910290835.51475.peter.ujfalusi@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Peter Ujfalusi Cc: "Nurkkala Eero.An (EXT-Offcode/Oulu)" , "tony@atomide.com" , "alsa-devel@alsa-project.org" , "linux-omap@vger.kernel.org" , "Valentin Eduardo (Nokia-D/Helsinki)" , "broonie@opensource.wolfsonmicro.com" On Thu, 29 Oct 2009 08:35:51 +0200 Peter Ujfalusi wrote: > > The spinlocks are unnecessary. In the above example, you get the same > > with just "return mcbsp->dma_op_mode;" > > > > -> Peter's patch is a good cleanup. > > Jarkko: are we going to take this? > Yep, you can have my Acked-by: Jarkko Nikula