From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM (Rev >= E) Date: Thu, 29 Oct 2009 11:23:31 +0200 Message-ID: <20091029092331.GB31472@nokia.com> References: <1256742758-32702-1-git-send-email-ajay.gupta@ti.com> <1256742758-32702-2-git-send-email-ajay.gupta@ti.com> <1256742758-32702-3-git-send-email-ajay.gupta@ti.com> <7A436F7769CA33409C6B44B358BFFF0C012AD6D86F@dlee02.ent.ti.com> <5A47E75E594F054BAF48C5E4FC4B92AB0309C8627C@dbde02.ent.ti.com> <19F8576C6E063C45BE387C64729E73940436EEAF1F@dbde02.ent.ti.com> <7A436F7769CA33409C6B44B358BFFF0C012AD6DBEA@dlee02.ent.ti.com> <19F8576C6E063C45BE387C64729E73940436EEAF59@dbde02.ent.ti.com> <20091029065838.GA27534@nokia.com> <19F8576C6E063C45BE387C64729E73940436EEAFAA@dbde02.ent.ti.com> Reply-To: felipe.balbi@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.nokia.com ([192.100.122.233]:63431 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbZJ2JX6 (ORCPT ); Thu, 29 Oct 2009 05:23:58 -0400 Content-Disposition: inline In-Reply-To: <19F8576C6E063C45BE387C64729E73940436EEAFAA@dbde02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "ext Gupta, Ajay Kumar" Cc: "Balbi Felipe (Nokia-D/Helsinki)" , "linux-omap@vger.kernel.org" , "Menon, Nishanth" , "Gadiyar, Anand" Hi, On Thu, Oct 29, 2009 at 08:03:21AM +0100, ext Gupta, Ajay Kumar wrote: > > I was thinking on adding a musb_hdrc_board_data which would group > > board-specific data such as this one. > > > > Musb's init phase is quite messy as of today so we would need to clean > > that up. Anyways, the main idea is: > > > > board will call usb_musb_init() with a musb_hdrc_board_data * as > > parameter. usb-musb would still hold a static struct > > musb_hdrc_platform_data for the (in our case) OMAP-specific init, those > > would be passed down to driver and init phase would be done as > > following: > > > > musb_init() > > -> musb_platform_init() > > -> musb_board_init() > > > > we could also have board_ops and platform_ops structures for the > > function pointers to be passed to musb_core.c Then all init could be > > done there. > > > > What do you say ??? > > This looks really good to isolate board specific settings. Do you have any > ready patch on this ? no, currently I'm working on refactoring the otg support. I could work on this after I finish otg refactoring unless you want to take this task :-) -- balbi