public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Koen Kooi <k.kooi@student.utwente.nl>
Cc: "linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap3: beagle: Fix USB host port power control
Date: Tue, 3 Nov 2009 09:21:39 -0800	[thread overview]
Message-ID: <20091103172139.GL8981@atomide.com> (raw)
In-Reply-To: <CD99E8BE-6FBB-4975-9072-A9BE16B1A00D@student.utwente.nl>

* Koen Kooi <k.kooi@student.utwente.nl> [091103 06:11]:
> Any comments on this, I need this on beagleboard to make ehci work.

Looks like a fix to me, will queue.

Tony
 
> regards,
> 
> Koen
> 
> Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:
> 
> >The host port power is enabled by driving the nEN_USB_PWR low as
> >stated in
> >the comment. This fix is originally from Steve Sakoman
> ><steve@sakoman.com>.
> >
> >Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> >Cc: Steve Sakoman <steve@sakoman.com>
> >---
> >arch/arm/mach-omap2/board-omap3beagle.c |    2 +-
> >1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/arch/arm/mach-omap2/board-omap3beagle.c
> >b/arch/arm/mach-omap2/board-omap3beagle.c
> >index 6cb99f6..7ad9846 100644
> >--- a/arch/arm/mach-omap2/board-omap3beagle.c
> >+++ b/arch/arm/mach-omap2/board-omap3beagle.c
> >@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device
> >*dev,
> >
> >	/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active
> >low) */
> >	gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
> >-	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
> >+	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> >
> >	/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
> >	gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
> >-- 
> >1.6.3.3
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-
> >omap" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-11-03 17:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-24  7:59 [PATCH] omap3: beagle: Fix USB host port power control Jarkko Nikula
2009-11-03 14:11 ` Koen Kooi
2009-11-03 17:21   ` Tony Lindgren [this message]
2009-11-04  2:22   ` Sid Boyce
2009-11-09 23:54 ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091103172139.GL8981@atomide.com \
    --to=tony@atomide.com \
    --cc=k.kooi@student.utwente.nl \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox