From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>,
"Gadiyar, Anand" <gadiyar@ti.com>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Aggarwal, Anuj" <anuj.aggarwal@ti.com>
Subject: Re: Query: Regulator framework in EHCI driver
Date: Thu, 5 Nov 2009 11:41:34 +0200 [thread overview]
Message-ID: <20091105094134.GB3045@nokia.com> (raw)
In-Reply-To: <20091105093641.GA21779@rakim.wolfsonmicro.main>
Hi,
On Thu, Nov 05, 2009 at 10:36:41AM +0100, ext Mark Brown wrote:
> On Thu, Nov 05, 2009 at 08:54:02AM +0530, Gupta, Ajay Kumar wrote:
>
> > I think we can add a check for supply name in EHCI driver, if its
> valid then we will call regulator_get()/enable() but if it's NULL then
> don't do anything.
> >
> > So the boards which don't use any regulator they can pass a NULL to
> supply name.
I don't know if I'm the only one, but Anand's mails are coming in over
80 chars lines.
> No, this would be a substantial misuse of the regulator API. The supply
> name should not be being passed through as platform data, the driver
> should request a fixed name (usually the name of the relevant physical
> supply to the chip) and let the API map this onto the actual supply for
> the system.
I agree with Mark here. The best solution would be to provide a fixed
voltage regulator for the other boards.
--
balbi
next prev parent reply other threads:[~2009-11-05 9:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 11:55 Query: Regulator framework in EHCI driver Gupta, Ajay Kumar
2009-11-03 15:30 ` Felipe Balbi
2009-11-04 12:32 ` Gupta, Ajay Kumar
2009-11-04 13:39 ` Mark Brown
2009-11-04 14:30 ` Gadiyar, Anand
2009-11-04 14:41 ` Mark Brown
2009-11-04 14:45 ` Gadiyar, Anand
2009-11-04 14:48 ` Mark Brown
2009-11-04 14:50 ` Gadiyar, Anand
2009-11-04 14:56 ` Mark Brown
2009-11-05 3:24 ` Gupta, Ajay Kumar
2009-11-05 9:36 ` Mark Brown
2009-11-05 9:41 ` Felipe Balbi [this message]
2009-11-05 10:31 ` Gadiyar, Anand
2009-11-05 11:19 ` Mark Brown
2009-11-05 11:25 ` Gadiyar, Anand
2009-11-11 14:56 ` Gupta, Ajay Kumar
2009-11-11 15:46 ` Mark Brown
2009-11-12 3:41 ` Gupta, Ajay Kumar
2009-11-12 3:51 ` Gupta, Ajay Kumar
2009-11-12 6:21 ` Gadiyar, Anand
2009-11-12 6:48 ` Gupta, Ajay Kumar
2009-11-12 12:16 ` Mark Brown
2009-11-13 4:22 ` Gupta, Ajay Kumar
2009-11-13 12:55 ` Mark Brown
2009-11-15 7:29 ` Gupta, Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105094134.GB3045@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=ajay.gupta@ti.com \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox