From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2/4 v2] OMAP: Configure audio_mclk for twl4030-codec MFD
Date: Mon, 9 Nov 2009 14:01:31 -0800 [thread overview]
Message-ID: <20091109220131.GH23952@atomide.com> (raw)
In-Reply-To: <200911090946.46576.peter.ujfalusi@nokia.com>
Hi,
* Peter Ujfalusi <peter.ujfalusi@nokia.com> [091108 23:46]:
> Hello Tony,
>
> On Wednesday 04 November 2009 09:58:18 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> > audio_mclk value is going to be handled by the
> > twl4030-codec MFD driver, configure the correct
> > value for boards, which is using the twl4030 audio.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> > ---
> > arch/arm/mach-omap2/board-3430sdp.c | 1 +
> > arch/arm/mach-omap2/board-omap3beagle.c | 1 +
> > arch/arm/mach-omap2/board-omap3evm.c | 1 +
> > arch/arm/mach-omap2/board-omap3pandora.c | 1 +
> > arch/arm/mach-omap2/board-overo.c | 1 +
> > arch/arm/mach-omap2/board-zoom2.c | 1 +
> > 6 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-3430sdp.c
> > b/arch/arm/mach-omap2/board-3430sdp.c index 4f91f7a..9afd957 100644
> > --- a/arch/arm/mach-omap2/board-3430sdp.c
> > +++ b/arch/arm/mach-omap2/board-3430sdp.c
> > @@ -415,6 +415,7 @@ static struct twl4030_codec_audio_data sdp3430_audio =
> > { };
> >
> > static struct twl4030_codec_data sdp3430_codec = {
> > + .audio_mclk = 26000000,
> > .audio = &sdp3430_audio,
> > };
> >
<snip>
> Can you take a look at this patch?
> The rest of the series has already got Ack from Samuel and Mark, and only your
> verdict for the OMAP part is missing.
Looks good to me. It seems like it's best to queue this along
with the related ASoC patches.
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2009-11-09 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 7:58 [PATCH 0/4 v2] ASoC/MFD/OMAP: TWL4030: APLL_CTL handling change Peter Ujfalusi
2009-11-04 7:58 ` [PATCH 1/4 v2] MFD: TWL4030: Add audio_mclk to the codec platform data Peter Ujfalusi
2009-11-04 7:58 ` [PATCH 2/4 v2] OMAP: Configure audio_mclk for twl4030-codec MFD Peter Ujfalusi
2009-11-04 7:58 ` [PATCH 3/4 v2] MFD: twl4030-codec: APLL_INFREQ handling in the MFD driver Peter Ujfalusi
2009-11-04 7:58 ` [PATCH 4/4 v2] ASoC: TWL4030: Do not modify the APLL_CTL register Peter Ujfalusi
2009-11-09 7:46 ` [PATCH 2/4 v2] OMAP: Configure audio_mclk for twl4030-codec MFD Peter Ujfalusi
2009-11-09 22:01 ` Tony Lindgren [this message]
2009-11-10 12:08 ` [PATCH 1/4 v2] MFD: TWL4030: Add audio_mclk to the codec platform data Mark Brown
2009-11-04 10:20 ` [PATCH 0/4 v2] ASoC/MFD/OMAP: TWL4030: APLL_CTL handling change Mark Brown
2009-11-04 16:36 ` Samuel Ortiz
2009-11-09 22:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109220131.GH23952@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox