From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 1/1]: Thaws refrigerated bdi flusher threads before invoking kthread_stop on them Date: Wed, 11 Nov 2009 11:34:44 +0100 Message-ID: <20091111103444.GD26423@elf.ucw.cz> References: <1257928216.15415.57.camel@boson> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49686 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbZKKKep (ORCPT ); Wed, 11 Nov 2009 05:34:45 -0500 Content-Disposition: inline In-Reply-To: <1257928216.15415.57.camel@boson> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Romit Dasgupta Cc: jens.axboe@oracle.com, rjw@sisk.pl, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-pm@lists.linux-foundation.org On Wed 2009-11-11 14:00:16, Romit Dasgupta wrote: > Kicks out frozen bdi flusher task out of the refrigerator when the flusher task > needs to exit. > Signed-off-by: Romit Dasgupta Ok, its slightly "interesting", but better than modifying common code. Looks ok to me. ACK. Pavel > --- > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 5a37e20..c757b05 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -606,8 +606,11 @@ static void bdi_wb_shutdown(struct backing_dev_info *bdi) > * Finally, kill the kernel threads. We don't need to be RCU > * safe anymore, since the bdi is gone from visibility. > */ > - list_for_each_entry(wb, &bdi->wb_list, list) > + list_for_each_entry(wb, &bdi->wb_list, list) { > + if (unlikely(frozen(wb->task))) > + wb->task->flags &= ~PF_FROZEN; > kthread_stop(wb->task); > + } > } > > void bdi_unregister(struct backing_dev_info *bdi) > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html