public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 3/8] omap: zoom: drop i2c-1 speed to 2400
Date: Wed, 11 Nov 2009 17:46:46 -0800	[thread overview]
Message-ID: <20091112014646.GR24837@atomide.com> (raw)
In-Reply-To: <1257982896-25087-4-git-send-email-vikram.pandita@ti.com>

* Vikram Pandita <vikram.pandita@ti.com> [091111 15:42]:
> The I2C-1 bus frequency on zoom2/zoom3/sdp3630 should be 2.4 MHz.
> The speed is limited by TWL5030/GAIA; a higher speed could lead to errors
> on the interface.
> 
> The maximum I2C speed depends on the system clock for GAIA:
> 2.2 MHz (sys-clk = 19.2 MHz)
> 2.4 MHz (sys-clk = 26 MHz)
> 2.9 MHz (sys-clk = 38.4 MHz)
> 
> For Zoom2/Zoom3/SDP3630 the system clock is 26Mhz
> and hence choose 2.4Mhz for I2C1 bus speed
> 
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
>  arch/arm/mach-omap2/board-zoom-peripherals.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>  mode change 100644 => 100755 arch/arm/mach-omap2/board-zoom-peripherals.c
> 
> diff --git a/arch/arm/mach-omap2/board-zoom-peripherals.c b/arch/arm/mach-omap2/board-zoom-peripherals.c
> old mode 100644
> new mode 100755
> index 4ca9c20..54619d5

Left out the mode change..

Tony

> --- a/arch/arm/mach-omap2/board-zoom-peripherals.c
> +++ b/arch/arm/mach-omap2/board-zoom-peripherals.c
> @@ -235,7 +235,7 @@ static struct twl4030_platform_data zoom_twldata = {
>  
>  static struct i2c_board_info __initdata zoom_i2c_boardinfo[] = {
>  	{
> -		I2C_BOARD_INFO("twl4030", 0x48),
> +		I2C_BOARD_INFO("twl5030", 0x48),
>  		.flags		= I2C_CLIENT_WAKE,
>  		.irq		= INT_34XX_SYS_NIRQ,
>  		.platform_data	= &zoom_twldata,
> @@ -244,7 +244,7 @@ static struct i2c_board_info __initdata zoom_i2c_boardinfo[] = {
>  
>  static int __init omap_i2c_init(void)
>  {
> -	omap_register_i2c_bus(1, 2600, zoom_i2c_boardinfo,
> +	omap_register_i2c_bus(1, 2400, zoom_i2c_boardinfo,
>  			ARRAY_SIZE(zoom_i2c_boardinfo));
>  	omap_register_i2c_bus(2, 400, NULL, 0);
>  	omap_register_i2c_bus(3, 400, NULL, 0);
> -- 
> 1.6.5.1.69.g36942
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-11-12  1:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 23:41 [PATCH v3 0/8] introduce 3630 boards Vikram Pandita
2009-11-11 23:41 ` [PATCH v3 1/8] omap: zoom2: split board file for software reuse Vikram Pandita
2009-11-11 23:41   ` [PATCH v3 2/8] omap: zoom: rename zoom2 name to generic zoom Vikram Pandita
2009-11-11 23:41     ` [PATCH v3 3/8] omap: zoom: drop i2c-1 speed to 2400 Vikram Pandita
2009-11-11 23:41       ` [PATCH v3 4/8] omap: zoom3: introduce zoom3 board support Vikram Pandita
2009-11-11 23:41         ` [PATCH v3 5/8] omap: 3630sdp: introduce 3630 sdp " Vikram Pandita
2009-11-11 23:41           ` [PATCH v3 6/8] omap: zoom2: update defconfig for LL_DEBUG_NONE Vikram Pandita
2009-11-11 23:41             ` [PATCH v3 7/8] omap: zoom3: defconfig creation Vikram Pandita
2009-11-11 23:41               ` [PATCH v3 8/8] omap: 3630sdp: " Vikram Pandita
2009-11-12  1:48                 ` [APPLIED] " Tony Lindgren
2009-11-12  1:48               ` [APPLIED] [PATCH v3 7/8] omap: zoom3: " Tony Lindgren
2009-11-12  1:47             ` [APPLIED] [PATCH v3 6/8] omap: zoom2: update defconfig for LL_DEBUG_NONE Tony Lindgren
2009-11-12  1:47           ` [APPLIED] [PATCH v3 5/8] omap: 3630sdp: introduce 3630 sdp board support Tony Lindgren
2009-11-12  1:47         ` [APPLIED] [PATCH v3 4/8] omap: zoom3: introduce zoom3 " Tony Lindgren
2009-11-12  1:44       ` [APPLIED] [PATCH v3 3/8] omap: zoom: drop i2c-1 speed to 2400 Tony Lindgren
2009-11-12  1:46       ` Tony Lindgren [this message]
2009-11-12  1:44     ` [APPLIED] [PATCH v3 2/8] omap: zoom: rename zoom2 name to generic zoom Tony Lindgren
2009-11-12  1:43   ` [APPLIED] [PATCH v3 1/8] omap: zoom2: split board file for software reuse Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091112014646.GR24837@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox