From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>
Cc: "Gadiyar, Anand" <gadiyar@ti.com>,
"felipe.balbi@nokia.com" <felipe.balbi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Aggarwal, Anuj" <anuj.aggarwal@ti.com>
Subject: Re: Query: Regulator framework in EHCI driver
Date: Fri, 13 Nov 2009 12:55:20 +0000 [thread overview]
Message-ID: <20091113125520.GA21516@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394043702AFF5@dbde02.ent.ti.com>
On Fri, Nov 13, 2009 at 09:52:14AM +0530, Gupta, Ajay Kumar wrote:
> + snprintf(supply, 7, "hsusb%d", i);
It'd be better to use sizeof() rather than a hard coded 7 here.
> + omap->regulator[i] = regulator_get(omap->dev, supply);
Looking at your code this needs to be regulator_get_exclusive() - you
conditinoally disable the regulator when unregistering depending on if
it reports as enabled but if the supply is shared then it can be enabled
without this driver having done so.
Alternatively, make the regulator_disable() in the shutdown path
unconditional.
next prev parent reply other threads:[~2009-11-13 12:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 11:55 Query: Regulator framework in EHCI driver Gupta, Ajay Kumar
2009-11-03 15:30 ` Felipe Balbi
2009-11-04 12:32 ` Gupta, Ajay Kumar
2009-11-04 13:39 ` Mark Brown
2009-11-04 14:30 ` Gadiyar, Anand
2009-11-04 14:41 ` Mark Brown
2009-11-04 14:45 ` Gadiyar, Anand
2009-11-04 14:48 ` Mark Brown
2009-11-04 14:50 ` Gadiyar, Anand
2009-11-04 14:56 ` Mark Brown
2009-11-05 3:24 ` Gupta, Ajay Kumar
2009-11-05 9:36 ` Mark Brown
2009-11-05 9:41 ` Felipe Balbi
2009-11-05 10:31 ` Gadiyar, Anand
2009-11-05 11:19 ` Mark Brown
2009-11-05 11:25 ` Gadiyar, Anand
2009-11-11 14:56 ` Gupta, Ajay Kumar
2009-11-11 15:46 ` Mark Brown
2009-11-12 3:41 ` Gupta, Ajay Kumar
2009-11-12 3:51 ` Gupta, Ajay Kumar
2009-11-12 6:21 ` Gadiyar, Anand
2009-11-12 6:48 ` Gupta, Ajay Kumar
2009-11-12 12:16 ` Mark Brown
2009-11-13 4:22 ` Gupta, Ajay Kumar
2009-11-13 12:55 ` Mark Brown [this message]
2009-11-15 7:29 ` Gupta, Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091113125520.GA21516@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ajay.gupta@ti.com \
--cc=anuj.aggarwal@ti.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox