public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jane Wang <jwang@ti.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	peter.ujfalusi@nokia.com
Subject: Re: [PATCH 2/2] ASoC: OMAP: reconfigure DMA to resume audio
Date: Fri, 13 Nov 2009 13:50:42 +0000	[thread overview]
Message-ID: <20091113135042.GE21516@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1258056918-19769-1-git-send-email-jwang@ti.com>

On Thu, Nov 12, 2009 at 02:15:18PM -0600, Jane Wang wrote:
> Reconfigure DMA transfer parameters to resume audio after system comming out of OFF state.

> Signed-off-by: Jane Wang <jwang@ti.com>

This looks OK to me but I'd like an ack from the OMAP folks.  Adding
Jarkko as well as he's the maintainer for OMAP audio.

> ---
>  sound/soc/omap/omap-pcm.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 6a829ee..5e04390 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -215,8 +215,13 @@ static int omap_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
>  
>  	spin_lock_irqsave(&prtd->lock, flags);
>  	switch (cmd) {
> -	case SNDRV_PCM_TRIGGER_START:
>  	case SNDRV_PCM_TRIGGER_RESUME:
> +		/* Reconfigure DMA transfer parameters
> +		 * in order to come back from OFF mode
> +		 */
> +		omap_pcm_prepare(substream);
> +		/* fall through */
> +	case SNDRV_PCM_TRIGGER_START:
>  	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>  		prtd->period_index = 0;
>  		/* Configure McBSP internal buffer usage */
> -- 
> 1.5.4.3
> 

       reply	other threads:[~2009-11-13 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1258056918-19769-1-git-send-email-jwang@ti.com>
2009-11-13 13:50 ` Mark Brown [this message]
2009-11-13 17:48   ` [PATCH 2/2] ASoC: OMAP: reconfigure DMA to resume audio Wang, Jane
2009-11-13 18:02 Jane Wang
2009-11-14  8:36 ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113135042.GE21516@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jwang@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox