public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* Some patches need reposting, inbox cleared, patchwork cleared
@ 2009-11-13  0:38 Tony Lindgren
  2009-11-13  4:41 ` Gadiyar, Anand
  0 siblings, 1 reply; 12+ messages in thread
From: Tony Lindgren @ 2009-11-13  0:38 UTC (permalink / raw)
  To: linux-omap

Hi all,

I'm finally done sorting through the patchwork patches to add to
the omap for-next queue. So I've nuked my linux-omap inbox, and
cleared the patches that I'm supposed to deal with in patchwork.

Please check that you patch is applied (or merged into some existing
patch) in the omap for-next branch.

If you don't see your patch in the omap for-next branch, and you
don't see the patch in the patchwork list, please repost your
patch. When reposting, please send the whole series again.

The patchwork pending patches are at:

http://patchwork.kernel.org/project/linux-omap/list/

I have not touched the patches in patchwork that are tagged for
felipebalbi, khilman or pwsan, so this message only concerns the
ones I'm supposed to deal with.

If you have lots of patches, you can also post a git branch that's
rebased on commit 8171d88089ad63fc442b2bf32af7c18653adc5cb.
Don't use the omap for-next for rebasing, as it's still changing.

I've dropped all the patches that did not apply to for-next,
or that have dependency to some other subsystem. I've commented
on few of the patches that don't apply, but not all of them.
Then some fix patches I've merged to the earlier patches,
and for those there's no APPLIED email message.

I've probably also accidentally trashed some perfectly valid
patches too.. So please check and repost as needed!

Cheers,

Tony

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13  0:38 Some patches need reposting, inbox cleared, patchwork cleared Tony Lindgren
@ 2009-11-13  4:41 ` Gadiyar, Anand
  2009-11-13  4:44   ` Gadiyar, Anand
  0 siblings, 1 reply; 12+ messages in thread
From: Gadiyar, Anand @ 2009-11-13  4:41 UTC (permalink / raw)
  To: Tony Lindgren, linux-omap@vger.kernel.org

Tony Lindgren wrote:
> Hi all,
> 
> I'm finally done sorting through the patchwork patches to add to
> the omap for-next queue. So I've nuked my linux-omap inbox, and
> cleared the patches that I'm supposed to deal with in patchwork.
> 
> Please check that you patch is applied (or merged into some existing
> patch) in the omap for-next branch.
> 
> If you don't see your patch in the omap for-next branch, and you
> don't see the patch in the patchwork list, please repost your
> patch. When reposting, please send the whole series again.
> 
> The patchwork pending patches are at:
> 
> http://patchwork.kernel.org/project/linux-omap/list/
> 
> I have not touched the patches in patchwork that are tagged for
> felipebalbi, khilman or pwsan, so this message only concerns the
> ones I'm supposed to deal with.
> 
> If you have lots of patches, you can also post a git branch that's
> rebased on commit 8171d88089ad63fc442b2bf32af7c18653adc5cb.
> Don't use the omap for-next for rebasing, as it's still changing.
> 
> I've dropped all the patches that did not apply to for-next,
> or that have dependency to some other subsystem. I've commented
> on few of the patches that don't apply, but not all of them.
> Then some fix patches I've merged to the earlier patches,
> and for those there's no APPLIED email message.
> 
> I've probably also accidentally trashed some perfectly valid
> patches too.. So please check and repost as needed!
> 

Tony,

What happened to the 3630 support stuff that had been merged to
your master branch as of yesterday?

- Anand

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13  4:41 ` Gadiyar, Anand
@ 2009-11-13  4:44   ` Gadiyar, Anand
  2009-11-13 18:03     ` Tony Lindgren
  0 siblings, 1 reply; 12+ messages in thread
From: Gadiyar, Anand @ 2009-11-13  4:44 UTC (permalink / raw)
  To: Gadiyar, Anand, Tony Lindgren, linux-omap@vger.kernel.org

Gadiyar, Anand wrote:
> Tony Lindgren wrote:
> > Hi all,
> > 
> > I'm finally done sorting through the patchwork patches to add to
> > the omap for-next queue. So I've nuked my linux-omap inbox, and
> > cleared the patches that I'm supposed to deal with in patchwork.
> > 
> > Please check that you patch is applied (or merged into some existing
> > patch) in the omap for-next branch.
> > 
> > If you don't see your patch in the omap for-next branch, and you
> > don't see the patch in the patchwork list, please repost your
> > patch. When reposting, please send the whole series again.
> > 
> > The patchwork pending patches are at:
> > 
> > http://patchwork.kernel.org/project/linux-omap/list/
> > 
> > I have not touched the patches in patchwork that are tagged for
> > felipebalbi, khilman or pwsan, so this message only concerns the
> > ones I'm supposed to deal with.
> > 
> > If you have lots of patches, you can also post a git branch that's
> > rebased on commit 8171d88089ad63fc442b2bf32af7c18653adc5cb.
> > Don't use the omap for-next for rebasing, as it's still changing.
> > 
> > I've dropped all the patches that did not apply to for-next,
> > or that have dependency to some other subsystem. I've commented
> > on few of the patches that don't apply, but not all of them.
> > Then some fix patches I've merged to the earlier patches,
> > and for those there's no APPLIED email message.
> > 
> > I've probably also accidentally trashed some perfectly valid
> > patches too.. So please check and repost as needed!
> > 
> 
> Tony,
> 
> What happened to the 3630 support stuff that had been merged to
> your master branch as of yesterday?
> 
> - Anand

I meant, I see these patches in for-next, but they're not present
in the l-o master branch. Is this deliberate?

- Anand

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13  4:44   ` Gadiyar, Anand
@ 2009-11-13 18:03     ` Tony Lindgren
  2009-11-13 18:06       ` Pandita, Vikram
  2009-11-13 18:29       ` Gadiyar, Anand
  0 siblings, 2 replies; 12+ messages in thread
From: Tony Lindgren @ 2009-11-13 18:03 UTC (permalink / raw)
  To: Gadiyar, Anand; +Cc: linux-omap@vger.kernel.org

* Gadiyar, Anand <gadiyar@ti.com> [091112 20:43]:
> Gadiyar, Anand wrote:
> > Tony Lindgren wrote:
> > > Hi all,
> > > 
> > > I'm finally done sorting through the patchwork patches to add to
> > > the omap for-next queue. So I've nuked my linux-omap inbox, and
> > > cleared the patches that I'm supposed to deal with in patchwork.
> > > 
> > > Please check that you patch is applied (or merged into some existing
> > > patch) in the omap for-next branch.
> > > 
> > > If you don't see your patch in the omap for-next branch, and you
> > > don't see the patch in the patchwork list, please repost your
> > > patch. When reposting, please send the whole series again.
> > > 
> > > The patchwork pending patches are at:
> > > 
> > > http://patchwork.kernel.org/project/linux-omap/list/
> > > 
> > > I have not touched the patches in patchwork that are tagged for
> > > felipebalbi, khilman or pwsan, so this message only concerns the
> > > ones I'm supposed to deal with.
> > > 
> > > If you have lots of patches, you can also post a git branch that's
> > > rebased on commit 8171d88089ad63fc442b2bf32af7c18653adc5cb.
> > > Don't use the omap for-next for rebasing, as it's still changing.
> > > 
> > > I've dropped all the patches that did not apply to for-next,
> > > or that have dependency to some other subsystem. I've commented
> > > on few of the patches that don't apply, but not all of them.
> > > Then some fix patches I've merged to the earlier patches,
> > > and for those there's no APPLIED email message.
> > > 
> > > I've probably also accidentally trashed some perfectly valid
> > > patches too.. So please check and repost as needed!
> > > 
> > 
> > Tony,
> > 
> > What happened to the 3630 support stuff that had been merged to
> > your master branch as of yesterday?
> > 
> > - Anand
> 
> I meant, I see these patches in for-next, but they're not present
> in the l-o master branch. Is this deliberate?

Hmm, it should be all merged into master branch also:

$ git log --pretty=oneline --grep=3630 -n100 master arch/arm/mach-omap2
1739bbc268aeffc8d3d040cf6493ef4399a1a181 omap: 3630sdp: introduce 3630 sdp board support
13ac7e77f407e4c529eb1cb058031f896fd3e80c omap: zoom3: introduce zoom3 board support
79c6fce9daa80936eba830c49b6c559f5ca6295d omap: zoom: drop i2c-1 speed to 2400
3efbe15e7755108268b9ed72d3b6c6539f671ebe omap: zoom: rename zoom2 name to generic zoom
97bd76cf5e5c18ddcc8d38f997ae7aec4db3bb01 omap: zoom2: split board file for software reuse
2c8681ac36b4247c26c5789f63de9f522436c1c5 omap3630: Set omap3630 MMC1 I/O speed to 52Mhz
9283cf8a9d21889fb838634e7017e84acf69e79f omap3630: Configure HSMMC1 to 4-bit
1a309b7370e5aa6d703eded1afc53218a205a71f omap3630: Add HSMMC related checks
1e9e0b997c30b81b2165fa68cad4411e6136a8d2 omap3: 3630: update is_chip variable
6fb081fb525c05aed6fee28bf73fe4ee1fe2d5bd omap3: Introduce OMAP3630

Can you check and let me know if something is missing?

Regards,

Tony

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13 18:03     ` Tony Lindgren
@ 2009-11-13 18:06       ` Pandita, Vikram
  2009-11-13 18:15         ` Tony Lindgren
  2009-11-13 18:29       ` Gadiyar, Anand
  1 sibling, 1 reply; 12+ messages in thread
From: Pandita, Vikram @ 2009-11-13 18:06 UTC (permalink / raw)
  To: Tony Lindgren, Gadiyar, Anand; +Cc: linux-omap@vger.kernel.org



>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Tony
>Lindgren
>Sent: Friday, November 13, 2009 12:03 PM
>To: Gadiyar, Anand
>Cc: linux-omap@vger.kernel.org
>Subject: Re: Some patches need reposting, inbox cleared, patchwork cleared
>
>> > Tony,
>> >
>> > What happened to the 3630 support stuff that had been merged to
>> > your master branch as of yesterday?
>> >
>> > - Anand
>>
>> I meant, I see these patches in for-next, but they're not present
>> in the l-o master branch. Is this deliberate?
>
>Hmm, it should be all merged into master branch also:
>
>$ git log --pretty=oneline --grep=3630 -n100 master arch/arm/mach-omap2
>1739bbc268aeffc8d3d040cf6493ef4399a1a181 omap: 3630sdp: introduce 3630 sdp board support
>13ac7e77f407e4c529eb1cb058031f896fd3e80c omap: zoom3: introduce zoom3 board support
>79c6fce9daa80936eba830c49b6c559f5ca6295d omap: zoom: drop i2c-1 speed to 2400
>3efbe15e7755108268b9ed72d3b6c6539f671ebe omap: zoom: rename zoom2 name to generic zoom
>97bd76cf5e5c18ddcc8d38f997ae7aec4db3bb01 omap: zoom2: split board file for software reuse
>2c8681ac36b4247c26c5789f63de9f522436c1c5 omap3630: Set omap3630 MMC1 I/O speed to 52Mhz
>9283cf8a9d21889fb838634e7017e84acf69e79f omap3630: Configure HSMMC1 to 4-bit
>1a309b7370e5aa6d703eded1afc53218a205a71f omap3630: Add HSMMC related checks
>1e9e0b997c30b81b2165fa68cad4411e6136a8d2 omap3: 3630: update is_chip variable
>6fb081fb525c05aed6fee28bf73fe4ee1fe2d5bd omap3: Introduce OMAP3630
>
>Can you check and let me know if something is missing?

I just verified booting zoom3 on l-o master, and its working fine.

Only extra patch that I have to add is the 8250 patch, that needs posting separately.

>
>Regards,
>
>Tony
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13 18:06       ` Pandita, Vikram
@ 2009-11-13 18:15         ` Tony Lindgren
  2009-11-13 18:20           ` Pandita, Vikram
  0 siblings, 1 reply; 12+ messages in thread
From: Tony Lindgren @ 2009-11-13 18:15 UTC (permalink / raw)
  To: Pandita, Vikram; +Cc: Gadiyar, Anand, linux-omap@vger.kernel.org

* Pandita, Vikram <vikram.pandita@ti.com> [091113 10:05]:
> 
> 
> >-----Original Message-----
> >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Tony
> >Lindgren
> >Sent: Friday, November 13, 2009 12:03 PM
> >To: Gadiyar, Anand
> >Cc: linux-omap@vger.kernel.org
> >Subject: Re: Some patches need reposting, inbox cleared, patchwork cleared
> >
> >> > Tony,
> >> >
> >> > What happened to the 3630 support stuff that had been merged to
> >> > your master branch as of yesterday?
> >> >
> >> > - Anand
> >>
> >> I meant, I see these patches in for-next, but they're not present
> >> in the l-o master branch. Is this deliberate?
> >
> >Hmm, it should be all merged into master branch also:
> >
> >$ git log --pretty=oneline --grep=3630 -n100 master arch/arm/mach-omap2
> >1739bbc268aeffc8d3d040cf6493ef4399a1a181 omap: 3630sdp: introduce 3630 sdp board support
> >13ac7e77f407e4c529eb1cb058031f896fd3e80c omap: zoom3: introduce zoom3 board support
> >79c6fce9daa80936eba830c49b6c559f5ca6295d omap: zoom: drop i2c-1 speed to 2400
> >3efbe15e7755108268b9ed72d3b6c6539f671ebe omap: zoom: rename zoom2 name to generic zoom
> >97bd76cf5e5c18ddcc8d38f997ae7aec4db3bb01 omap: zoom2: split board file for software reuse
> >2c8681ac36b4247c26c5789f63de9f522436c1c5 omap3630: Set omap3630 MMC1 I/O speed to 52Mhz
> >9283cf8a9d21889fb838634e7017e84acf69e79f omap3630: Configure HSMMC1 to 4-bit
> >1a309b7370e5aa6d703eded1afc53218a205a71f omap3630: Add HSMMC related checks
> >1e9e0b997c30b81b2165fa68cad4411e6136a8d2 omap3: 3630: update is_chip variable
> >6fb081fb525c05aed6fee28bf73fe4ee1fe2d5bd omap3: Introduce OMAP3630
> >
> >Can you check and let me know if something is missing?
> 
> I just verified booting zoom3 on l-o master, and its working fine.

OK good. Can you also try booting this patch from Felipe on 3630:

http://patchwork.kernel.org/patch/59540/
 
> Only extra patch that I have to add is the 8250 patch, that needs posting separately.

OK

Regards,

Tony

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13 18:15         ` Tony Lindgren
@ 2009-11-13 18:20           ` Pandita, Vikram
  2009-11-13 19:07             ` Pandita, Vikram
  0 siblings, 1 reply; 12+ messages in thread
From: Pandita, Vikram @ 2009-11-13 18:20 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Gadiyar, Anand, linux-omap@vger.kernel.org



>-----Original Message-----
>From: Tony Lindgren [mailto:tony@atomide.com]
>> I just verified booting zoom3 on l-o master, and its working fine.
>
>OK good. Can you also try booting this patch from Felipe on 3630:
>
>http://patchwork.kernel.org/patch/59540/

Patch does not apply. Rebasing now and testing.

>
>> Only extra patch that I have to add is the 8250 patch, that needs posting separately.
>
>OK
>
>Regards,
>
>Tony


^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13 18:03     ` Tony Lindgren
  2009-11-13 18:06       ` Pandita, Vikram
@ 2009-11-13 18:29       ` Gadiyar, Anand
  1 sibling, 0 replies; 12+ messages in thread
From: Gadiyar, Anand @ 2009-11-13 18:29 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap@vger.kernel.org

> 
> Hmm, it should be all merged into master branch also:
> 
> $ git log --pretty=oneline --grep=3630 -n100 master arch/arm/mach-omap2
> 1739bbc268aeffc8d3d040cf6493ef4399a1a181 omap: 3630sdp: introduce 3630 sdp board support
> 13ac7e77f407e4c529eb1cb058031f896fd3e80c omap: zoom3: introduce zoom3 board support
> 79c6fce9daa80936eba830c49b6c559f5ca6295d omap: zoom: drop i2c-1 speed to 2400
> 3efbe15e7755108268b9ed72d3b6c6539f671ebe omap: zoom: rename zoom2 name to generic zoom
> 97bd76cf5e5c18ddcc8d38f997ae7aec4db3bb01 omap: zoom2: split board file for software reuse
> 2c8681ac36b4247c26c5789f63de9f522436c1c5 omap3630: Set omap3630 MMC1 I/O speed to 52Mhz
> 9283cf8a9d21889fb838634e7017e84acf69e79f omap3630: Configure HSMMC1 to 4-bit
> 1a309b7370e5aa6d703eded1afc53218a205a71f omap3630: Add HSMMC related checks
> 1e9e0b997c30b81b2165fa68cad4411e6136a8d2 omap3: 3630: update is_chip variable
> 6fb081fb525c05aed6fee28bf73fe4ee1fe2d5bd omap3: Introduce OMAP3630
> 
> Can you check and let me know if something is missing?
> 

Looks like I pulled too early. I did a git pull now and the files are back.

- Anand

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13 18:20           ` Pandita, Vikram
@ 2009-11-13 19:07             ` Pandita, Vikram
  2009-11-14  1:08               ` Tony Lindgren
  0 siblings, 1 reply; 12+ messages in thread
From: Pandita, Vikram @ 2009-11-13 19:07 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Tony

>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of
>Pandita, Vikram
>>From: Tony Lindgren [mailto:tony@atomide.com]
>>> I just verified booting zoom3 on l-o master, and its working fine.
>>
>>OK good. Can you also try booting this patch from Felipe on 3630:
>>
>>http://patchwork.kernel.org/patch/59540/
>
>Patch does not apply. Rebasing now and testing.

Rebased Patch (attached) boots up fine now on 3630 Zoom3 board.

Logs:
CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7f
CPU: VIPT nonaliasing data cache, VIPT nonaliasing instruction cache
Machine: OMAP Zoom3 board
Memory policy: ECC disabled, Data cache writeback
OMAP3630 ES1.0 (l2cache iva sgx neon isp )



[-- Attachment #2: arm-omap-code-cleanup-to-id.c.patch --]
[-- Type: application/octet-stream, Size: 4283 bytes --]

From: Felipe Balbi <felipe.balbi@nokia.com>

Cleanup the coding style in id.c while avoiding unneeded switch()
statements.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>

---
refreshed on top of Today's linux-omap (0aaf4859f62d2ead2dd949646d12b0216439facd)

this patch was compile-tested only with all omap defconfigs, it would be
nice to see it boot-tested on several boards before we apply it.

 arch/arm/mach-omap2/id.c |   61 ++++++++++++++++-------------------------------
 1 file changed, 21 insertions(+), 40 deletions(-)

Index: l-o/arch/arm/mach-omap2/id.c
===================================================================
--- l-o.orig/arch/arm/mach-omap2/id.c	2009-11-13 08:18:16.000000000 -0600
+++ l-o/arch/arm/mach-omap2/id.c	2009-11-13 13:02:16.000000000 -0600
@@ -53,11 +53,11 @@ int omap_type(void)
 {
 	u32 val = 0;
 
-	if (cpu_is_omap24xx())
+	if (cpu_is_omap24xx()) {
 		val = omap_ctrl_readl(OMAP24XX_CONTROL_STATUS);
-	else if (cpu_is_omap34xx())
+	} else if (cpu_is_omap34xx()) {
 		val = omap_ctrl_readl(OMAP343X_CONTROL_STATUS);
-	else {
+	} else {
 		pr_err("Cannot detect omap type!\n");
 		goto out;
 	}
@@ -224,24 +224,12 @@ void __init omap3_check_revision(void)
 			omap_revision = OMAP3430_REV_ES3_0;
 			break;
 		case 4:
-			omap_revision = OMAP3430_REV_ES3_1;
-			break;
+		/* FALLTHROUGH */
 		default:
 			/* Use the latest known revision as default */
 			omap_revision = OMAP3430_REV_ES3_1;
 		}
 		break;
-	case 0xb891:
-		/* Handle 36xx devices */
-		switch (rev) {
-		case 0:
-			omap_revision = OMAP3630_REV_ES1_0;
-			break;
-		default:
-			/* Use the latest known revision as default */
-			omap_revision = OMAP3630_REV_ES1_0;
-		}
-		break;
 	case 0xb868:
 		/* Handle OMAP35xx/AM35xx devices
 		 *
@@ -250,6 +238,8 @@ void __init omap3_check_revision(void)
 		 */
 		omap_revision = OMAP3505_REV(rev);
 		break;
+	case 0xb891:
+	/* FALLTHROUGH */
 	default:
 		/* Unknown default to latest silicon rev as default*/
 		omap_revision = OMAP3630_REV_ES1_0;
@@ -271,35 +261,29 @@ void __init omap3_cpuinfo(void)
 	 * on available features. Upon detection, update the CPU id
 	 * and CPU class bits.
 	 */
-	if (cpu_is_omap3630())
+	if (cpu_is_omap3630()) {
 		strcpy(cpu_name, "OMAP3630");
-	else if (cpu_is_omap3505()) {
+	} else if (cpu_is_omap3505()) {
 		/*
 		 * AM35xx devices
 		 */
 		if (omap3_has_sgx()) {
 			omap_revision = OMAP3517_REV(rev);
 			strcpy(cpu_name, "AM3517");
-		}
-		else {
+		} else {
 			/* Already set in omap3_check_revision() */
 			strcpy(cpu_name, "AM3505");
 		}
-	}
-	/*
-	 * OMAP3430, OMAP3525, OMAP3515, OMAP3503 devices
-	 */
-	else if (omap3_has_iva() && omap3_has_sgx())
+	} else if (omap3_has_iva() && omap3_has_sgx()) {
+		/* OMAP3430, OMAP3525, OMAP3515, OMAP3503 devices */
 		strcpy(cpu_name, "OMAP3430/3530");
-	else if (omap3_has_sgx()) {
+	} else if (omap3_has_sgx()) {
 		omap_revision = OMAP3525_REV(rev);
 		strcpy(cpu_name, "OMAP3525");
-	}
-	else if (omap3_has_iva()) {
+	} else if (omap3_has_iva()) {
 		omap_revision = OMAP3515_REV(rev);
 		strcpy(cpu_name, "OMAP3515");
-	}
-	else {
+	} else {
 		omap_revision = OMAP3503_REV(rev);
 		strcpy(cpu_name, "OMAP3503");
 	}
@@ -318,16 +302,13 @@ void __init omap3_cpuinfo(void)
 		strcpy(cpu_rev, "3.0");
 		break;
 	case OMAP_REVBITS_40:
-		strcpy(cpu_rev, "3.1");
-		break;
+	/* FALLTHROUGH */
 	default:
 		/* Use the latest known revision as default */
 		strcpy(cpu_rev, "3.1");
 	}
 
-	/*
-	 * Print verbose information
-	 */
+	/* Print verbose information */
 	pr_info("%s ES%s (", cpu_name, cpu_rev);
 
 	OMAP3_SHOW_FEATURE(l2cache);
@@ -348,18 +329,18 @@ void __init omap2_check_revision(void)
 	 * At this point we have an idea about the processor revision set
 	 * earlier with omap2_set_globals_tap().
 	 */
-	if (cpu_is_omap24xx())
+	if (cpu_is_omap24xx()) {
 		omap24xx_check_revision();
-	else if (cpu_is_omap34xx()) {
+	} else if (cpu_is_omap34xx()) {
 		omap3_check_revision();
 		omap3_check_features();
 		omap3_cpuinfo();
-	}
-	else if (cpu_is_omap44xx()) {
+	} else if (cpu_is_omap44xx()) {
 		printk(KERN_INFO "FIXME: CPU revision = OMAP4430\n");
 		return;
-	} else
+	} else {
 		pr_err("OMAP revision unknown, please fix!\n");
+	}
 
 	/*
 	 * OK, now we know the exact revision. Initialize omap_chip bits

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-13 19:07             ` Pandita, Vikram
@ 2009-11-14  1:08               ` Tony Lindgren
  2009-11-16 11:37                 ` Aggarwal, Anuj
  0 siblings, 1 reply; 12+ messages in thread
From: Tony Lindgren @ 2009-11-14  1:08 UTC (permalink / raw)
  To: Pandita, Vikram; +Cc: linux-omap@vger.kernel.org

* Pandita, Vikram <vikram.pandita@ti.com> [091113 11:06]:
> Tony
> 
> >-----Original Message-----
> >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of
> >Pandita, Vikram
> >>From: Tony Lindgren [mailto:tony@atomide.com]
> >>> I just verified booting zoom3 on l-o master, and its working fine.
> >>
> >>OK good. Can you also try booting this patch from Felipe on 3630:
> >>
> >>http://patchwork.kernel.org/patch/59540/
> >
> >Patch does not apply. Rebasing now and testing.
> 
> Rebased Patch (attached) boots up fine now on 3630 Zoom3 board.
> 
> Logs:
> CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7f
> CPU: VIPT nonaliasing data cache, VIPT nonaliasing instruction cache
> Machine: OMAP Zoom3 board
> Memory policy: ECC disabled, Data cache writeback
> OMAP3630 ES1.0 (l2cache iva sgx neon isp )
> 

OK, thanks applying it.

Tony 



^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-14  1:08               ` Tony Lindgren
@ 2009-11-16 11:37                 ` Aggarwal, Anuj
  2009-11-16 20:59                   ` Tony Lindgren
  0 siblings, 1 reply; 12+ messages in thread
From: Aggarwal, Anuj @ 2009-11-16 11:37 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap@vger.kernel.org

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Tony Lindgren
> Sent: Saturday, November 14, 2009 6:38 AM
> To: Pandita, Vikram
> Cc: linux-omap@vger.kernel.org
> Subject: Re: Some patches need reposting, inbox cleared, patchwork cleared
> 
> * Pandita, Vikram <vikram.pandita@ti.com> [091113 11:06]:
> > Tony
> >
> > >-----Original Message-----
> > >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of
> > >Pandita, Vikram
> > >>From: Tony Lindgren [mailto:tony@atomide.com]
> > >>> I just verified booting zoom3 on l-o master, and its working fine.
> > >>
> > >>OK good. Can you also try booting this patch from Felipe on 3630:
> > >>
> > >>http://patchwork.kernel.org/patch/59540/
> > >
> > >Patch does not apply. Rebasing now and testing.
> >
> > Rebased Patch (attached) boots up fine now on 3630 Zoom3 board.
> >
> > Logs:
> > CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7f
> > CPU: VIPT nonaliasing data cache, VIPT nonaliasing instruction cache
> > Machine: OMAP Zoom3 board
> > Memory policy: ECC disabled, Data cache writeback
> > OMAP3630 ES1.0 (l2cache iva sgx neon isp )
> >
> 
> OK, thanks applying it.
Tony,

I am not able to see the following patch in the list:

OMAP3EVM: Use the twl4030_setup_data for headset pop-removal
http://marc.info/?l=linux-omap&m=125368984011630&w=2

Can you apply it please?
> 
> Tony
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Some patches need reposting, inbox cleared, patchwork cleared
  2009-11-16 11:37                 ` Aggarwal, Anuj
@ 2009-11-16 20:59                   ` Tony Lindgren
  0 siblings, 0 replies; 12+ messages in thread
From: Tony Lindgren @ 2009-11-16 20:59 UTC (permalink / raw)
  To: Aggarwal, Anuj; +Cc: linux-omap@vger.kernel.org

* Aggarwal, Anuj <anuj.aggarwal@ti.com> [091116 03:37]:
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Tony Lindgren
> > Sent: Saturday, November 14, 2009 6:38 AM
> > To: Pandita, Vikram
> > Cc: linux-omap@vger.kernel.org
> > Subject: Re: Some patches need reposting, inbox cleared, patchwork cleared
> > 
> > * Pandita, Vikram <vikram.pandita@ti.com> [091113 11:06]:
> > > Tony
> > >
> > > >-----Original Message-----
> > > >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of
> > > >Pandita, Vikram
> > > >>From: Tony Lindgren [mailto:tony@atomide.com]
> > > >>> I just verified booting zoom3 on l-o master, and its working fine.
> > > >>
> > > >>OK good. Can you also try booting this patch from Felipe on 3630:
> > > >>
> > > >>http://patchwork.kernel.org/patch/59540/
> > > >
> > > >Patch does not apply. Rebasing now and testing.
> > >
> > > Rebased Patch (attached) boots up fine now on 3630 Zoom3 board.
> > >
> > > Logs:
> > > CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7f
> > > CPU: VIPT nonaliasing data cache, VIPT nonaliasing instruction cache
> > > Machine: OMAP Zoom3 board
> > > Memory policy: ECC disabled, Data cache writeback
> > > OMAP3630 ES1.0 (l2cache iva sgx neon isp )
> > >
> > 
> > OK, thanks applying it.
> Tony,
> 
> I am not able to see the following patch in the list:
> 
> OMAP3EVM: Use the twl4030_setup_data for headset pop-removal
> http://marc.info/?l=linux-omap&m=125368984011630&w=2
> 
> Can you apply it please?

It looks like it should go in via the ASoC, so not taking it.

>From MAINTAINERS file:

SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC)
M:      Liam Girdwood <lrg@slimlogic.co.uk>
M:      Mark Brown <broonie@opensource.wolfsonmicro.com>
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
L:      alsa-devel@alsa-project.org (moderated for non-subscribers)
W:      http://alsa-project.org/main/index.php/ASoC
S:      Supported
F:      sound/soc/
F:      include/sound/soc*

Regards,

Tony

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2009-11-16 20:59 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-13  0:38 Some patches need reposting, inbox cleared, patchwork cleared Tony Lindgren
2009-11-13  4:41 ` Gadiyar, Anand
2009-11-13  4:44   ` Gadiyar, Anand
2009-11-13 18:03     ` Tony Lindgren
2009-11-13 18:06       ` Pandita, Vikram
2009-11-13 18:15         ` Tony Lindgren
2009-11-13 18:20           ` Pandita, Vikram
2009-11-13 19:07             ` Pandita, Vikram
2009-11-14  1:08               ` Tony Lindgren
2009-11-16 11:37                 ` Aggarwal, Anuj
2009-11-16 20:59                   ` Tony Lindgren
2009-11-13 18:29       ` Gadiyar, Anand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox