From: Tony Lindgren <tony@atomide.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 1/2] serial: 8250: add UPF_NO_EMPTY_FIFO_READ flag
Date: Tue, 17 Nov 2009 09:46:40 -0800 [thread overview]
Message-ID: <20091117174640.GG29266@atomide.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC35608702FA689E5F@dbde02.ent.ti.com>
* Pandita, Vikram <vikram.pandita@ti.com> [091117 09:39]:
> Tony
>
> >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Tony
> >Lindgren
> >Sent: Tuesday, November 17, 2009 11:06 AM
> >To: Pandita, Vikram
> >Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh
> >Subject: Re: [PATCH 1/2] serial: 8250: add UPF_NO_EMPTY_FIFO_READ flag
> >
> >* Vikram Pandita <vikram.pandita@ti.com> [091116 15:00]:
> >> OMAP3630 and OMAP4430 UART IP blocks have a restriction wrt RX FIFO.
> >> Empty RX fifo read causes an abort. OMAP1/2/3 do not have this restriction.
> >>
> >> So interoduce a flag in 8250 driver: UPF_NO_EMPTY_FIFO_READ
> >>
> >> If this flag is specified for an 8250 port, then first check if rx fifo has
> >> contents, and only then proceed to read the fifo.
> >>
> >> The change affects only boards passing this flag in port data and hence is
> >> non-disruptive for other boards.
> >>
> >> First reported/fixed on omap4430 by Shilimkar, Santosh
> >
> >This should go to linux-serial@vger.kernel.org and Alan Cox.
>
> Patches were posted to l-o for review. Next step was to get it to the right subsystem.
>
> I thought Alan Cox stepped down from the maintainership of serial/tty subsystem.
> Not sure if Andrew Morton is taking these patches to MM tree for now.
> Any idea?
OK, no idea who's dealing with 8250 now :)
Tony
next prev parent reply other threads:[~2009-11-17 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 22:53 [PATCH 1/2] serial: 8250: add UPF_NO_EMPTY_FIFO_READ flag Vikram Pandita
2009-11-17 17:06 ` Tony Lindgren
2009-11-17 17:39 ` Pandita, Vikram
2009-11-17 17:46 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-17 21:16 Vikram Pandita
2009-11-17 21:25 ` Alan Cox
2009-11-17 21:38 ` Pandita, Vikram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117174640.GG29266@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox