From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] OMAP: Exporting functions doing common register access Date: Wed, 18 Nov 2009 16:33:14 +0200 Message-ID: <20091118163314.d0325283.jhnikula@gmail.com> References: <1258384836-24854-1-git-send-email-anuj.aggarwal@ti.com> <5A47E75E594F054BAF48C5E4FC4B92AB030A8C8EC2@dbde02.ent.ti.com> <5A47E75E594F054BAF48C5E4FC4B92AB030A9CA8F7@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Paul Walmsley Cc: "Aggarwal, Anuj" , "alsa-devel@alsa-project.org" , "linux-omap@vger.kernel.org" List-Id: linux-omap@vger.kernel.org On Wed, 18 Nov 2009 03:40:40 -0700 (MST) Paul Walmsley wrote: > In the interim, I would suggest that you remove the the clock source and > receiver source change functions from omap-mcbsp.c, split them into OMAP1 > and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c. > Expand struct omap_mcbsp_ops to add function pointers to those functions. > Call those from soc/omap-mcbsp.c via mcbsp->pdata->ops. That way you won't > need those exports. > Paul: What's your opinnion, would it be possible or would it be wise to handle these McBSP clock route setups with the clock framework instead? Functions omap_mcbsp_dai_set_clks_src and omap_mcbsp_dai_set_rcvr_src are basically just setting up the input clock for McBSP SRG or McBSP1 receiver. > I don't understand how this code compiled on OMAP1 in any case, since it > doesn't have a System Control Module. > OMAP1 can include control.h as well :-) Access is anyway protected with the cpu_class_is_omap1(). -- Jarkko