RE: [RFC][PATCH] ARM: OMAP: McBSP: Use register cache

ext-Eero.Nurkkala
2009-09-05T20:47:52Z

> Isn't the better way to achieve this thing, at least from the OFF mode
> perspective, is to provide similar implementation for McBSP in
> omap3_core_save_context () / omap3_core_restore_context(), in
> file arch/arm/mach-omap2/pm34xx.c? Code for other core peripherals
> is already there and we have to add support for rest of the core-domain
> peripherals.

Yes and no. I'm not sure McBSP context would be needed to be restored
after every wake up from PER off mode.. isn't that how it's handled now
for other peripherals? But maybe restore context for McBSP whenever
there's need for it. Rewriting millions of registers just for the case doesn't
sound good. IMO, with an irq from an external device, a rewrite of the
McBSP registers occurs. You loose the point of the OFF mode if you always
start rewriting all registers? (you're not saving power.. the opposite).
Or did I not understand something? (most likely the case) =)

- Eero