Re: [RFC][PATCH] ARM: OMAP: McBSP: Use register cache

Eero Nurkkala
2009-09-04T11:08:33Z

On Fri, 2009-09-04 at 12:34 +0200, ext Janusz Krzysztofik wrote:
> in normal (handset) mode, the noise level seems still acceptable. The only
> missing piece of a puzzle is my patch, that prevents the kernel driver from
> putting corrupted values into the McBSP control registers.
>
> That learned, please reconsider:
> 1. Can my patch break anything, related or not?

That needs to be investigated in more detail.

> 2. How does it affect performance of otherwise unaffected machines?

Like you already know, shouldn't.

> 3. Is correcting a poorly designed machine behaviour worth of the change?
>
> Thanks,
> Janusz

I'd say this is in the right track. All McBSP registers
(not status etc) will need to be stored in memory. (Now, they're not).
And all those register contents will need to be written back
in certain situations. So this is the case when there is an external
audio chip, that takes audio in in bursts. So once the
burst is complete, all McBSP clocks will be disabled for a duration.

Then (at least >= 3430) device will hit OFF mode, meaning
all register contents are lost, also McBSP's. They will
need to be written back at some point.

My quick verdict is, that your patch is, going into right
direction. But the thing is that my words don't count much ;)

(Possibly worth taking the patch in, if guaranteed to not break
any others).

- Eero