From: Olof Johansson <olof@lixom.net>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Vikram Pandita <vikram.pandita@ti.com>,
Ajay Kumar Gupta <ajay.gupta@ti.com>,
tony@atomide.com
Subject: Re: [PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3
Date: Wed, 25 Nov 2009 02:56:48 -0600 [thread overview]
Message-ID: <20091125085648.GA30331@lixom.net> (raw)
In-Reply-To: <1257536793-15291-1-git-send-email-gadiyar@ti.com>
OMAP34XX has EHCI, so select USB_ARCH_HAS_EHCI.
Signed-off-by: Olof Johansson <olof@lixom.net>
---
On Sat, Nov 07, 2009 at 01:16:32AM +0530, Anand Gadiyar wrote:
> usb: ehci: Allow EHCI to be built on OMAP3
>
> OMAP3 chips have a built-in EHCI controller.
> The recently introduced omap ehci-hcd driver missed
> out on selecting USB_ARCH_HAS_EHCI in Kconfig.
>
> Without this, the driver cannot be built.
This is a losing battle. It scales much better to select the option
from OMAP34XX, instead of starting to enumerate the various platforms
in drivers/usb.
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 034d990..a913b05 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -18,6 +18,7 @@ config ARCH_OMAP2430
config ARCH_OMAP34XX
bool "OMAP34xx Based System"
depends on ARCH_OMAP3
+ select USB_ARCH_HAS_EHCI
config ARCH_OMAP3430
bool "OMAP3430 support"
next prev parent reply other threads:[~2009-11-25 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 19:46 [PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3 Anand Gadiyar
2009-11-25 8:56 ` Olof Johansson [this message]
[not found] ` <20091125085648.GA30331-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2009-11-25 9:06 ` Gadiyar, Anand
2009-12-07 22:11 ` [APPLIED] " Tony Lindgren
2009-12-12 7:48 ` Sid Boyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125085648.GA30331@lixom.net \
--to=olof@lixom.net \
--cc=ajay.gupta@ti.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox