From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 5/9] DSPBRIDGE: trivial cleanup and indentation for io_sm Date: Wed, 25 Nov 2009 21:15:09 +0200 Message-ID: <20091125191509.GA28486@nokia.com> References: <1259023830-7557-1-git-send-email-omar.ramirez@ti.com> <1259023830-7557-2-git-send-email-omar.ramirez@ti.com> <1259023830-7557-3-git-send-email-omar.ramirez@ti.com> <1259023830-7557-4-git-send-email-omar.ramirez@ti.com> <1259023830-7557-5-git-send-email-omar.ramirez@ti.com> <1259023830-7557-6-git-send-email-omar.ramirez@ti.com> Reply-To: felipe.balbi@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Received: from smtp.nokia.com ([192.100.122.233]:57230 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753574AbZKYTRu (ORCPT ); Wed, 25 Nov 2009 14:17:50 -0500 Content-Disposition: inline In-Reply-To: <1259023830-7557-6-git-send-email-omar.ramirez@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Omar Ramirez Luna Cc: linux-omap , Artem Bityutskiy , "Doyu Hiroshi (Nokia-D/Helsinki)" On Tue, Nov 24, 2009 at 01:50:26AM +0100, ext Omar Ramirez Luna wrote: >Remove duplicate set of braces from if statement and reduce >indentation. > >Signed-off-by: Omar Ramirez Luna >--- > drivers/dsp/bridge/wmd/io_sm.c | 96 +++++++++++++++++----------------------- > 1 files changed, 40 insertions(+), 56 deletions(-) > >diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/bridge/wmd/io_sm.c >index af31831..96a5aa6 100644 >--- a/drivers/dsp/bridge/wmd/io_sm.c >+++ b/drivers/dsp/bridge/wmd/io_sm.c >@@ -115,7 +115,7 @@ struct IO_MGR { > /* private extnd proc info; mmu setup */ > struct MGR_PROCESSOREXTINFO extProcInfo; > struct CMM_OBJECT *hCmmMgr; /* Shared Mem Mngr */ >- struct work_struct io_workq; /*workqueue */ >+ struct work_struct io_workq; /*workqueue */ while at that: /* workqueue */ add the missing space. > u32 dQuePowerMbxVal[MAX_PM_REQS]; > u32 iQuePowerHead; > u32 iQuePowerTail; >@@ -185,7 +185,7 @@ DSP_STATUS WMD_IO_Create(OUT struct IO_MGR **phIOMgr, > struct CFG_HOSTRES hostRes; > struct CFG_DEVNODE *hDevNode; > struct CHNL_MGR *hChnlMgr; >- static int ref_count; >+ static int ref_count; > u32 devType; > /* Check requirements: */ > if (!phIOMgr || !pMgrAttrs || pMgrAttrs->uWordSize == 0) { >@@ -197,9 +197,10 @@ DSP_STATUS WMD_IO_Create(OUT struct IO_MGR **phIOMgr, > status = DSP_EHANDLE; > goto func_end; > } >- /* Message manager will be created when a file is loaded, since >+ /* Message manager will be created when a file is loaded, since > * size of message buffer in shared memory is configurable in >- * the base image. */ >+ * the base image. >+ */ same here... it should be: /* multi-line comment start here and has only one * space after the * character. * If you could remove the extra space above would * be nice. */ -- balbi