From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Date: Fri, 27 Nov 2009 17:54:26 +0300 Message-ID: <20091127145426.GA6135@oksana.dev.rtsoft.ru> References: <1259333060-24277-1-git-send-email-notasas@gmail.com> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1259333060-24277-1-git-send-email-notasas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Grazvydas Ignotas Cc: linux-kernel@vger.kernel.org, Madhusudhan Chikkature , linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Fri, Nov 27, 2009 at 04:44:20PM +0200, Grazvydas Ignotas wrote: > TWL4030/TPS65950 is a multi-function device with integrated charger, > which allows charging from AC or USB. This driver enables the > charger and provides several monitoring functions. > > Signed-off-by: Grazvydas Ignotas > --- Thanks for the patch. [...] > +/* > + * Attend to TWL4030 CHG_PRES (AC charger presence) events > + */ > +static irqreturn_t twl4030_charger_interrupt(int irq, void *_di) > +{ > + struct twl4030_bci_device_info *di = _di; > + > +#ifdef CONFIG_LOCKDEP > + /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which > + * we don't want and can't tolerate. Although it might be > + * friendlier not to borrow this thread context... > + */ > + local_irq_enable(); > +#endif Can you explain why the driver can't tolerate disabled irqs? Calling schedule_delayed_work() from an irq context should be OK. > + schedule_delayed_work(&di->bat_work, msecs_to_jiffies(BCI_DELAY)); > + > + return IRQ_HANDLED; > +} -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2