* [PATCH] ASoC: AIC23: Fixing infinite loop in resume path
@ 2009-11-27 12:10 Anuj Aggarwal
2009-11-27 12:24 ` Belisko Marek
2009-11-27 16:48 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Anuj Aggarwal @ 2009-11-27 12:10 UTC (permalink / raw)
To: alsa-devel, linux-omap; +Cc: Anuj Aggarwal, broonie
This patch fixes two issues:
a) Infinite loop in resume function
b) Writes to non-existing registers in resume function
Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
sound/soc/codecs/tlv320aic23.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
index 6b24d8b..90a0264 100644
--- a/sound/soc/codecs/tlv320aic23.c
+++ b/sound/soc/codecs/tlv320aic23.c
@@ -625,11 +625,10 @@ static int tlv320aic23_resume(struct platform_device *pdev)
{
struct snd_soc_device *socdev = platform_get_drvdata(pdev);
struct snd_soc_codec *codec = socdev->card->codec;
- int i;
u16 reg;
/* Sync reg_cache with the hardware */
- for (reg = 0; reg < ARRAY_SIZE(tlv320aic23_reg); i++) {
+ for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
u16 val = tlv320aic23_read_reg_cache(codec, reg);
tlv320aic23_write(codec, reg, val);
}
--
1.6.2.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: AIC23: Fixing infinite loop in resume path
2009-11-27 12:10 [PATCH] ASoC: AIC23: Fixing infinite loop in resume path Anuj Aggarwal
@ 2009-11-27 12:24 ` Belisko Marek
2009-11-27 12:45 ` Aggarwal, Anuj
2009-11-27 16:48 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Belisko Marek @ 2009-11-27 12:24 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: alsa-devel, linux-omap, broonie
On Fri, Nov 27, 2009 at 1:10 PM, Anuj Aggarwal <anuj.aggarwal@ti.com> wrote:
> This patch fixes two issues:
> a) Infinite loop in resume function
> b) Writes to non-existing registers in resume function
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> sound/soc/codecs/tlv320aic23.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
> index 6b24d8b..90a0264 100644
> --- a/sound/soc/codecs/tlv320aic23.c
> +++ b/sound/soc/codecs/tlv320aic23.c
> @@ -625,11 +625,10 @@ static int tlv320aic23_resume(struct platform_device *pdev)
> {
> struct snd_soc_device *socdev = platform_get_drvdata(pdev);
> struct snd_soc_codec *codec = socdev->card->codec;
> - int i;
> u16 reg;
>
> /* Sync reg_cache with the hardware */
> - for (reg = 0; reg < ARRAY_SIZE(tlv320aic23_reg); i++) {
> + for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
ARRAY_SIZE() shouldn't be preserved?
> u16 val = tlv320aic23_read_reg_cache(codec, reg);
> tlv320aic23_write(codec, reg, val);
> }
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Marek
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ASoC: AIC23: Fixing infinite loop in resume path
2009-11-27 12:24 ` Belisko Marek
@ 2009-11-27 12:45 ` Aggarwal, Anuj
0 siblings, 0 replies; 4+ messages in thread
From: Aggarwal, Anuj @ 2009-11-27 12:45 UTC (permalink / raw)
To: Belisko Marek
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com
> > @@ -625,11 +625,10 @@ static int tlv320aic23_resume(struct
> platform_device *pdev)
> > {
> > struct snd_soc_device *socdev = platform_get_drvdata(pdev);
> > struct snd_soc_codec *codec = socdev->card->codec;
> > - int i;
> > u16 reg;
> >
> > /* Sync reg_cache with the hardware */
> > - for (reg = 0; reg < ARRAY_SIZE(tlv320aic23_reg); i++) {
> > + for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
> ARRAY_SIZE() shouldn't be preserved?
[Aggarwal, Anuj] No, since registers 0x0A - 0x0E are not present.
> > u16 val = tlv320aic23_read_reg_cache(codec, reg);
> > tlv320aic23_write(codec, reg, val);
> > }
> > --
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: AIC23: Fixing infinite loop in resume path
2009-11-27 12:10 [PATCH] ASoC: AIC23: Fixing infinite loop in resume path Anuj Aggarwal
2009-11-27 12:24 ` Belisko Marek
@ 2009-11-27 16:48 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2009-11-27 16:48 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: alsa-devel, linux-omap
On Fri, Nov 27, 2009 at 05:40:58PM +0530, Anuj Aggarwal wrote:
> This patch fixes two issues:
> a) Infinite loop in resume function
> b) Writes to non-existing registers in resume function
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-27 16:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-27 12:10 [PATCH] ASoC: AIC23: Fixing infinite loop in resume path Anuj Aggarwal
2009-11-27 12:24 ` Belisko Marek
2009-11-27 12:45 ` Aggarwal, Anuj
2009-11-27 16:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox