* [PATCH V2] AM3517: Add support for TSC2004 driver @ 2009-11-26 5:11 hvaibhav 2009-11-26 5:14 ` Hiremath, Vaibhav 0 siblings, 1 reply; 6+ messages in thread From: hvaibhav @ 2009-11-26 5:11 UTC (permalink / raw) To: linux-omap; +Cc: tony, Vaibhav Hiremath From: Vaibhav Hiremath <hvaibhav@ti.com> Changes: - Removed omap_cfg_reg() Reviewed-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> --- arch/arm/mach-omap2/board-am3517evm.c | 61 +++++++++++++++++++++++++++++++++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c index 415a13d..b183d93 100644 --- a/arch/arm/mach-omap2/board-am3517evm.c +++ b/arch/arm/mach-omap2/board-am3517evm.c @@ -20,6 +20,8 @@ #include <linux/init.h> #include <linux/platform_device.h> #include <linux/gpio.h> +#include <linux/irq.h> +#include <linux/i2c/tsc2004.h> #include <mach/hardware.h> #include <asm/mach-types.h> @@ -27,10 +29,64 @@ #include <asm/mach/map.h> #include <plat/board.h> +#include <plat/mux.h> #include <plat/common.h> #include <plat/usb.h> /* + * TSC 2004 Support + */ +#define GPIO_TSC2004_IRQ 65 + +static int tsc2004_init_irq(void) +{ + int ret = 0; + + ret = gpio_request(GPIO_TSC2004_IRQ, "tsc2004-irq"); + if (ret < 0) { + printk(KERN_WARNING "failed to request GPIO#%d: %d\n", + GPIO_TSC2004_IRQ, ret); + return ret; + } + + if (gpio_direction_input(GPIO_TSC2004_IRQ)) { + printk(KERN_WARNING "GPIO#%d cannot be configured as " + "input\n", GPIO_TSC2004_IRQ); + return -ENXIO; + } + + omap_set_gpio_debounce(GPIO_TSC2004_IRQ, 1); + omap_set_gpio_debounce_time(GPIO_TSC2004_IRQ, 0xa); + return ret; +} + +static void tsc2004_exit_irq(void) +{ + gpio_free(GPIO_TSC2004_IRQ); +} + +static int tsc2004_get_irq_level(void) +{ + return gpio_get_value(GPIO_TSC2004_IRQ) ? 0 : 1; +} + +struct tsc2004_platform_data am3517evm_tsc2004data = { + .model = 2004, + .x_plate_ohms = 180, + .get_pendown_state = tsc2004_get_irq_level, + .init_platform_hw = tsc2004_init_irq, + .exit_platform_hw = tsc2004_exit_irq, +}; + +static struct i2c_board_info __initdata am3517evm_tsc_i2c_boardinfo[] = { + { + I2C_BOARD_INFO("tsc2004", 0x4B), + .type = "tsc2004", + .platform_data = &am3517evm_tsc2004data, + }, +}; + +/* * Board initialization */ static struct omap_board_config_kernel am3517_evm_config[] __initdata = { @@ -67,6 +123,11 @@ static void __init am3517_evm_init(void) omap_serial_init(); usb_ehci_init(&ehci_pdata); + + /* TSC 2004 */ + am3517evm_tsc_i2c_boardinfo[0].irq = gpio_to_irq(GPIO_TSC2004_IRQ); + i2c_register_board_info(1, am3517evm_tsc_i2c_boardinfo, + ARRAY_SIZE(am3517evm_tsc_i2c_boardinfo)); } static void __init am3517_evm_map_io(void) -- 1.6.2.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH V2] AM3517: Add support for TSC2004 driver 2009-11-26 5:11 [PATCH V2] AM3517: Add support for TSC2004 driver hvaibhav @ 2009-11-26 5:14 ` Hiremath, Vaibhav 2009-11-30 17:33 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Hiremath, Vaibhav @ 2009-11-26 5:14 UTC (permalink / raw) To: Hiremath, Vaibhav, linux-omap@vger.kernel.org; +Cc: tony@atomide.com > -----Original Message----- > From: Hiremath, Vaibhav > Sent: Thursday, November 26, 2009 10:41 AM > To: linux-omap@vger.kernel.org > Cc: tony@atomide.com; Hiremath, Vaibhav > Subject: [PATCH V2] AM3517: Add support for TSC2004 driver > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > Changes: > - Removed omap_cfg_reg() > > Reviewed-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > --- > arch/arm/mach-omap2/board-am3517evm.c | 61 > +++++++++++++++++++++++++++++++++ > 1 files changed, 61 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach- > omap2/board-am3517evm.c > index 415a13d..b183d93 100644 > --- a/arch/arm/mach-omap2/board-am3517evm.c > +++ b/arch/arm/mach-omap2/board-am3517evm.c > @@ -20,6 +20,8 @@ > #include <linux/init.h> > #include <linux/platform_device.h> > #include <linux/gpio.h> > +#include <linux/irq.h> > +#include <linux/i2c/tsc2004.h> > > #include <mach/hardware.h> > #include <asm/mach-types.h> > @@ -27,10 +29,64 @@ > #include <asm/mach/map.h> > > #include <plat/board.h> > +#include <plat/mux.h> > #include <plat/common.h> > #include <plat/usb.h> > > /* > + * TSC 2004 Support > + */ > +#define GPIO_TSC2004_IRQ 65 > + > +static int tsc2004_init_irq(void) > +{ > + int ret = 0; > + > + ret = gpio_request(GPIO_TSC2004_IRQ, "tsc2004-irq"); > + if (ret < 0) { > + printk(KERN_WARNING "failed to request GPIO#%d: %d\n", > + GPIO_TSC2004_IRQ, ret); > + return ret; > + } > + > + if (gpio_direction_input(GPIO_TSC2004_IRQ)) { > + printk(KERN_WARNING "GPIO#%d cannot be configured as " > + "input\n", GPIO_TSC2004_IRQ); > + return -ENXIO; > + } > + > + omap_set_gpio_debounce(GPIO_TSC2004_IRQ, 1); > + omap_set_gpio_debounce_time(GPIO_TSC2004_IRQ, 0xa); > + return ret; > +} > + > +static void tsc2004_exit_irq(void) > +{ > + gpio_free(GPIO_TSC2004_IRQ); > +} > + > +static int tsc2004_get_irq_level(void) > +{ > + return gpio_get_value(GPIO_TSC2004_IRQ) ? 0 : 1; > +} > + > +struct tsc2004_platform_data am3517evm_tsc2004data = { > + .model = 2004, > + .x_plate_ohms = 180, > + .get_pendown_state = tsc2004_get_irq_level, > + .init_platform_hw = tsc2004_init_irq, > + .exit_platform_hw = tsc2004_exit_irq, > +}; > + > +static struct i2c_board_info __initdata > am3517evm_tsc_i2c_boardinfo[] = { > + { > + I2C_BOARD_INFO("tsc2004", 0x4B), > + .type = "tsc2004", > + .platform_data = &am3517evm_tsc2004data, > + }, > +}; > + > +/* > * Board initialization > */ > static struct omap_board_config_kernel am3517_evm_config[] > __initdata = { > @@ -67,6 +123,11 @@ static void __init am3517_evm_init(void) > > omap_serial_init(); > usb_ehci_init(&ehci_pdata); > + > + /* TSC 2004 */ > + am3517evm_tsc_i2c_boardinfo[0].irq = > gpio_to_irq(GPIO_TSC2004_IRQ); > + i2c_register_board_info(1, am3517evm_tsc_i2c_boardinfo, > + ARRAY_SIZE(am3517evm_tsc_i2c_boardinfo)); > } > > static void __init am3517_evm_map_io(void) [Hiremath, Vaibhav] Hi Tony, Since I haven't received any comments on driver code it should get merged. But I am not sure what the procedure is for input subsystem drivers? Is it happens through linux-omap or linux-input? Thanks, Vaibhav > -- > 1.6.2.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] AM3517: Add support for TSC2004 driver 2009-11-26 5:14 ` Hiremath, Vaibhav @ 2009-11-30 17:33 ` Tony Lindgren 2009-12-10 5:42 ` Hiremath, Vaibhav 2009-12-17 18:08 ` Hiremath, Vaibhav 0 siblings, 2 replies; 6+ messages in thread From: Tony Lindgren @ 2009-11-30 17:33 UTC (permalink / raw) To: Hiremath, Vaibhav; +Cc: linux-omap@vger.kernel.org * Hiremath, Vaibhav <hvaibhav@ti.com> [091125 21:13]: > > > -----Original Message----- > > From: Hiremath, Vaibhav > > Sent: Thursday, November 26, 2009 10:41 AM > > To: linux-omap@vger.kernel.org > > Cc: tony@atomide.com; Hiremath, Vaibhav > > Subject: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > Changes: > > - Removed omap_cfg_reg() > > > > Reviewed-by: Tony Lindgren <tony@atomide.com> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > --- > > arch/arm/mach-omap2/board-am3517evm.c | 61 > > +++++++++++++++++++++++++++++++++ > > 1 files changed, 61 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach- > > omap2/board-am3517evm.c > > index 415a13d..b183d93 100644 > > --- a/arch/arm/mach-omap2/board-am3517evm.c > > +++ b/arch/arm/mach-omap2/board-am3517evm.c > > @@ -20,6 +20,8 @@ > > #include <linux/init.h> > > #include <linux/platform_device.h> > > #include <linux/gpio.h> > > +#include <linux/irq.h> > > +#include <linux/i2c/tsc2004.h> > > > > #include <mach/hardware.h> > > #include <asm/mach-types.h> > > @@ -27,10 +29,64 @@ > > #include <asm/mach/map.h> > > > > #include <plat/board.h> > > +#include <plat/mux.h> > > #include <plat/common.h> > > #include <plat/usb.h> > > > > /* > > + * TSC 2004 Support > > + */ > > +#define GPIO_TSC2004_IRQ 65 > > + > > +static int tsc2004_init_irq(void) > > +{ > > + int ret = 0; > > + > > + ret = gpio_request(GPIO_TSC2004_IRQ, "tsc2004-irq"); > > + if (ret < 0) { > > + printk(KERN_WARNING "failed to request GPIO#%d: %d\n", > > + GPIO_TSC2004_IRQ, ret); > > + return ret; > > + } > > + > > + if (gpio_direction_input(GPIO_TSC2004_IRQ)) { > > + printk(KERN_WARNING "GPIO#%d cannot be configured as " > > + "input\n", GPIO_TSC2004_IRQ); > > + return -ENXIO; > > + } > > + > > + omap_set_gpio_debounce(GPIO_TSC2004_IRQ, 1); > > + omap_set_gpio_debounce_time(GPIO_TSC2004_IRQ, 0xa); > > + return ret; > > +} > > + > > +static void tsc2004_exit_irq(void) > > +{ > > + gpio_free(GPIO_TSC2004_IRQ); > > +} > > + > > +static int tsc2004_get_irq_level(void) > > +{ > > + return gpio_get_value(GPIO_TSC2004_IRQ) ? 0 : 1; > > +} > > + > > +struct tsc2004_platform_data am3517evm_tsc2004data = { > > + .model = 2004, > > + .x_plate_ohms = 180, > > + .get_pendown_state = tsc2004_get_irq_level, > > + .init_platform_hw = tsc2004_init_irq, > > + .exit_platform_hw = tsc2004_exit_irq, > > +}; > > + > > +static struct i2c_board_info __initdata > > am3517evm_tsc_i2c_boardinfo[] = { > > + { > > + I2C_BOARD_INFO("tsc2004", 0x4B), > > + .type = "tsc2004", > > + .platform_data = &am3517evm_tsc2004data, > > + }, > > +}; > > + > > +/* > > * Board initialization > > */ > > static struct omap_board_config_kernel am3517_evm_config[] > > __initdata = { > > @@ -67,6 +123,11 @@ static void __init am3517_evm_init(void) > > > > omap_serial_init(); > > usb_ehci_init(&ehci_pdata); > > + > > + /* TSC 2004 */ > > + am3517evm_tsc_i2c_boardinfo[0].irq = > > gpio_to_irq(GPIO_TSC2004_IRQ); > > + i2c_register_board_info(1, am3517evm_tsc_i2c_boardinfo, > > + ARRAY_SIZE(am3517evm_tsc_i2c_boardinfo)); > > } > > > > static void __init am3517_evm_map_io(void) > [Hiremath, Vaibhav] Hi Tony, > > Since I haven't received any comments on driver code it should get merged. But I am not sure what the procedure is for input subsystem drivers? Is it happens through linux-omap or linux-input? I'd rather see it merged via linux-input as that's where most of the code is. The platform init code looks OK to me to merge via linux-input too. Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V2] AM3517: Add support for TSC2004 driver 2009-11-30 17:33 ` Tony Lindgren @ 2009-12-10 5:42 ` Hiremath, Vaibhav 2009-12-17 18:08 ` Hiremath, Vaibhav 1 sibling, 0 replies; 6+ messages in thread From: Hiremath, Vaibhav @ 2009-12-10 5:42 UTC (permalink / raw) To: Tony Lindgren, Dmitry Torokhov, dtor@mail.ru Cc: linux-omap@vger.kernel.org, linux-input@vger.kernel.org > -----Original Message----- > From: Tony Lindgren [mailto:tony@atomide.com] > Sent: Monday, November 30, 2009 11:04 PM > To: Hiremath, Vaibhav > Cc: linux-omap@vger.kernel.org > Subject: Re: [PATCH V2] AM3517: Add support for TSC2004 driver > > * Hiremath, Vaibhav <hvaibhav@ti.com> [091125 21:13]: > > > > > -----Original Message----- > > > From: Hiremath, Vaibhav > > > Sent: Thursday, November 26, 2009 10:41 AM > > > To: linux-omap@vger.kernel.org > > > Cc: tony@atomide.com; Hiremath, Vaibhav > > > Subject: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > > > Changes: > > > - Removed omap_cfg_reg() > > > > > > Reviewed-by: Tony Lindgren <tony@atomide.com> > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > > --- > > > arch/arm/mach-omap2/board-am3517evm.c | 61 > > > +++++++++++++++++++++++++++++++++ > > > 1 files changed, 61 insertions(+), 0 deletions(-) > > > > > > diff --git a/arch/arm/mach-omap2/board-am3517evm.c > b/arch/arm/mach- > > > omap2/board-am3517evm.c > > > index 415a13d..b183d93 100644 > > > --- a/arch/arm/mach-omap2/board-am3517evm.c > > > +++ b/arch/arm/mach-omap2/board-am3517evm.c > > > @@ -20,6 +20,8 @@ > > > #include <linux/init.h> > > > #include <linux/platform_device.h> > > > #include <linux/gpio.h> > > > +#include <linux/irq.h> > > > +#include <linux/i2c/tsc2004.h> > > > > > > #include <mach/hardware.h> > > > #include <asm/mach-types.h> > > > @@ -27,10 +29,64 @@ > > > #include <asm/mach/map.h> > > > > > > #include <plat/board.h> > > > +#include <plat/mux.h> > > > #include <plat/common.h> > > > #include <plat/usb.h> > > > > > > /* > > > + * TSC 2004 Support > > > + */ > > > +#define GPIO_TSC2004_IRQ 65 > > > + > > > +static int tsc2004_init_irq(void) > > > +{ > > > + int ret = 0; > > > + > > > + ret = gpio_request(GPIO_TSC2004_IRQ, "tsc2004-irq"); > > > + if (ret < 0) { > > > + printk(KERN_WARNING "failed to request GPIO#%d: %d\n", > > > + GPIO_TSC2004_IRQ, ret); > > > + return ret; > > > + } > > > + > > > + if (gpio_direction_input(GPIO_TSC2004_IRQ)) { > > > + printk(KERN_WARNING "GPIO#%d cannot be configured as " > > > + "input\n", GPIO_TSC2004_IRQ); > > > + return -ENXIO; > > > + } > > > + > > > + omap_set_gpio_debounce(GPIO_TSC2004_IRQ, 1); > > > + omap_set_gpio_debounce_time(GPIO_TSC2004_IRQ, 0xa); > > > + return ret; > > > +} > > > + > > > +static void tsc2004_exit_irq(void) > > > +{ > > > + gpio_free(GPIO_TSC2004_IRQ); > > > +} > > > + > > > +static int tsc2004_get_irq_level(void) > > > +{ > > > + return gpio_get_value(GPIO_TSC2004_IRQ) ? 0 : 1; > > > +} > > > + > > > +struct tsc2004_platform_data am3517evm_tsc2004data = { > > > + .model = 2004, > > > + .x_plate_ohms = 180, > > > + .get_pendown_state = tsc2004_get_irq_level, > > > + .init_platform_hw = tsc2004_init_irq, > > > + .exit_platform_hw = tsc2004_exit_irq, > > > +}; > > > + > > > +static struct i2c_board_info __initdata > > > am3517evm_tsc_i2c_boardinfo[] = { > > > + { > > > + I2C_BOARD_INFO("tsc2004", 0x4B), > > > + .type = "tsc2004", > > > + .platform_data = &am3517evm_tsc2004data, > > > + }, > > > +}; > > > + > > > +/* > > > * Board initialization > > > */ > > > static struct omap_board_config_kernel am3517_evm_config[] > > > __initdata = { > > > @@ -67,6 +123,11 @@ static void __init am3517_evm_init(void) > > > > > > omap_serial_init(); > > > usb_ehci_init(&ehci_pdata); > > > + > > > + /* TSC 2004 */ > > > + am3517evm_tsc_i2c_boardinfo[0].irq = > > > gpio_to_irq(GPIO_TSC2004_IRQ); > > > + i2c_register_board_info(1, am3517evm_tsc_i2c_boardinfo, > > > + ARRAY_SIZE(am3517evm_tsc_i2c_boardinfo)); > > > } > > > > > > static void __init am3517_evm_map_io(void) > > [Hiremath, Vaibhav] Hi Tony, > > > > Since I haven't received any comments on driver code it should get > merged. But I am not sure what the procedure is for input subsystem > drivers? Is it happens through linux-omap or linux-input? > > I'd rather see it merged via linux-input as that's where most > of the code is. The platform init code looks OK to me to merge > via linux-input too. > [Hiremath, Vaibhav] Dmitry, Can you please merge the TSC2004 driver patch? Thanks, Vaibhav > Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V2] AM3517: Add support for TSC2004 driver 2009-11-30 17:33 ` Tony Lindgren 2009-12-10 5:42 ` Hiremath, Vaibhav @ 2009-12-17 18:08 ` Hiremath, Vaibhav 2009-12-17 18:21 ` Dmitry Torokhov 1 sibling, 1 reply; 6+ messages in thread From: Hiremath, Vaibhav @ 2009-12-17 18:08 UTC (permalink / raw) To: Hiremath, Vaibhav, Tony Lindgren, Dmitry Torokhov, dtor@mail.ru Cc: linux-omap@vger.kernel.org, linux-input@vger.kernel.org > -----Original Message----- > From: Hiremath, Vaibhav > Sent: Thursday, December 10, 2009 11:13 AM > To: 'Tony Lindgren'; 'Dmitry Torokhov'; 'dtor@mail.ru' > Cc: linux-omap@vger.kernel.org; linux-input@vger.kernel.org > Subject: RE: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > -----Original Message----- > > From: Tony Lindgren [mailto:tony@atomide.com] > > Sent: Monday, November 30, 2009 11:04 PM > > To: Hiremath, Vaibhav > > Cc: linux-omap@vger.kernel.org > > Subject: Re: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > * Hiremath, Vaibhav <hvaibhav@ti.com> [091125 21:13]: > > > > > > > -----Original Message----- > > > > From: Hiremath, Vaibhav > > > > Sent: Thursday, November 26, 2009 10:41 AM > > > > To: linux-omap@vger.kernel.org > > > > Cc: tony@atomide.com; Hiremath, Vaibhav > > > > Subject: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > > > > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > > > > > Changes: > > > > - Removed omap_cfg_reg() > > > > > > > > Reviewed-by: Tony Lindgren <tony@atomide.com> > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > > > --- > > > > arch/arm/mach-omap2/board-am3517evm.c | 61 > > > > +++++++++++++++++++++++++++++++++ > > > > 1 files changed, 61 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/board-am3517evm.c > > b/arch/arm/mach- > > > > omap2/board-am3517evm.c > > > > index 415a13d..b183d93 100644 > > > > --- a/arch/arm/mach-omap2/board-am3517evm.c > > > > +++ b/arch/arm/mach-omap2/board-am3517evm.c > > > > @@ -20,6 +20,8 @@ > > > > #include <linux/init.h> > > > > #include <linux/platform_device.h> > > > > #include <linux/gpio.h> > > > > +#include <linux/irq.h> > > > > +#include <linux/i2c/tsc2004.h> > > > > > > > > #include <mach/hardware.h> > > > > #include <asm/mach-types.h> > > > > @@ -27,10 +29,64 @@ > > > > #include <asm/mach/map.h> > > > > > > > > #include <plat/board.h> > > > > +#include <plat/mux.h> > > > > #include <plat/common.h> > > > > #include <plat/usb.h> > > > > > > > > /* > > > > + * TSC 2004 Support > > > > + */ <snip>... > > merged. But I am not sure what the procedure is for input > subsystem > > drivers? Is it happens through linux-omap or linux-input? > > > > I'd rather see it merged via linux-input as that's where most > > of the code is. The platform init code looks OK to me to merge > > via linux-input too. > > > [Hiremath, Vaibhav] Dmitry, > > Can you please merge the TSC2004 driver patch? > [Hiremath, Vaibhav] Just a gentle reminder. Thanks, Vaibhav > Thanks, > Vaibhav > > > Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] AM3517: Add support for TSC2004 driver 2009-12-17 18:08 ` Hiremath, Vaibhav @ 2009-12-17 18:21 ` Dmitry Torokhov 0 siblings, 0 replies; 6+ messages in thread From: Dmitry Torokhov @ 2009-12-17 18:21 UTC (permalink / raw) To: Hiremath, Vaibhav Cc: Tony Lindgren, linux-omap@vger.kernel.org, linux-input@vger.kernel.org On Thu, Dec 17, 2009 at 11:38:18PM +0530, Hiremath, Vaibhav wrote: > > > -----Original Message----- > > From: Hiremath, Vaibhav > > Sent: Thursday, December 10, 2009 11:13 AM > > To: 'Tony Lindgren'; 'Dmitry Torokhov'; 'dtor@mail.ru' > > Cc: linux-omap@vger.kernel.org; linux-input@vger.kernel.org > > Subject: RE: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > > > > -----Original Message----- > > > From: Tony Lindgren [mailto:tony@atomide.com] > > > Sent: Monday, November 30, 2009 11:04 PM > > > To: Hiremath, Vaibhav > > > Cc: linux-omap@vger.kernel.org > > > Subject: Re: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > > > * Hiremath, Vaibhav <hvaibhav@ti.com> [091125 21:13]: > > > > > > > > > -----Original Message----- > > > > > From: Hiremath, Vaibhav > > > > > Sent: Thursday, November 26, 2009 10:41 AM > > > > > To: linux-omap@vger.kernel.org > > > > > Cc: tony@atomide.com; Hiremath, Vaibhav > > > > > Subject: [PATCH V2] AM3517: Add support for TSC2004 driver > > > > > > > > > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > > > > > > > Changes: > > > > > - Removed omap_cfg_reg() > > > > > > > > > > Reviewed-by: Tony Lindgren <tony@atomide.com> > > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > > > > > --- > > > > > arch/arm/mach-omap2/board-am3517evm.c | 61 > > > > > +++++++++++++++++++++++++++++++++ > > > > > 1 files changed, 61 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git a/arch/arm/mach-omap2/board-am3517evm.c > > > b/arch/arm/mach- > > > > > omap2/board-am3517evm.c > > > > > index 415a13d..b183d93 100644 > > > > > --- a/arch/arm/mach-omap2/board-am3517evm.c > > > > > +++ b/arch/arm/mach-omap2/board-am3517evm.c > > > > > @@ -20,6 +20,8 @@ > > > > > #include <linux/init.h> > > > > > #include <linux/platform_device.h> > > > > > #include <linux/gpio.h> > > > > > +#include <linux/irq.h> > > > > > +#include <linux/i2c/tsc2004.h> > > > > > > > > > > #include <mach/hardware.h> > > > > > #include <asm/mach-types.h> > > > > > @@ -27,10 +29,64 @@ > > > > > #include <asm/mach/map.h> > > > > > > > > > > #include <plat/board.h> > > > > > +#include <plat/mux.h> > > > > > #include <plat/common.h> > > > > > #include <plat/usb.h> > > > > > > > > > > /* > > > > > + * TSC 2004 Support > > > > > + */ > <snip>... > > > > merged. But I am not sure what the procedure is for input > > subsystem > > > drivers? Is it happens through linux-omap or linux-input? > > > > > > I'd rather see it merged via linux-input as that's where most > > > of the code is. The platform init code looks OK to me to merge > > > via linux-input too. > > > > > [Hiremath, Vaibhav] Dmitry, > > > > Can you please merge the TSC2004 driver patch? > > > [Hiremath, Vaibhav] Just a gentle reminder. > Sorry for the delays, I am swamped at the moment. Fortunately the Christmas break is coming up so I'll try to catch up. -- Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-12-17 18:21 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-11-26 5:11 [PATCH V2] AM3517: Add support for TSC2004 driver hvaibhav 2009-11-26 5:14 ` Hiremath, Vaibhav 2009-11-30 17:33 ` Tony Lindgren 2009-12-10 5:42 ` Hiremath, Vaibhav 2009-12-17 18:08 ` Hiremath, Vaibhav 2009-12-17 18:21 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox