From: Tony Lindgren <tony@atomide.com>
To: Mike Rapoport <mike@compulab.co.il>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap3: mux: add shorthands for OUTPUT_PULL{UP,DOWN}
Date: Mon, 30 Nov 2009 13:12:55 -0800 [thread overview]
Message-ID: <20091130211255.GZ4348@atomide.com> (raw)
In-Reply-To: <1b6ff0b31e4c22532659749282e0dcf4dccdf5e4.1259481545.git.mike@compulab.co.il>
* Mike Rapoport <mike@compulab.co.il> [091129 00:10]:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> ---
> arch/arm/mach-omap2/mux.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.h b/arch/arm/mach-omap2/mux.h
> index e09c5d2..02a1b53 100644
> --- a/arch/arm/mach-omap2/mux.h
> +++ b/arch/arm/mach-omap2/mux.h
> @@ -37,6 +37,8 @@
>
> /* Active pin states */
> #define OMAP_PIN_OUTPUT 0
> +#define OMAP_PIN_OUTPUT_PULLUP (OMAP_PULL_ENA | OMAP_PULL_UP)
> +#define OMAP_PIN_OUTPUT_PULLDOWN OMAP_PULL_ENA
> #define OMAP_PIN_INPUT OMAP_INPUT_EN
> #define OMAP_PIN_INPUT_PULLUP (OMAP_PULL_ENA | OMAP_INPUT_EN \
> | OMAP_PULL_UP)
Hmm, isn't this same as configuring as GPIO with up or
down value?
Or is there's some need doing it with mux only? Like
power savings?
Regards,
Tony
next prev parent reply other threads:[~2009-11-30 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 8:07 [PATCH] omap3: cm-t35: add mux initialization Mike Rapoport
2009-11-29 8:07 ` [PATCH] omap3: mux: add shorthands for OUTPUT_PULL{UP,DOWN} Mike Rapoport
2009-11-30 21:12 ` Tony Lindgren [this message]
2009-11-30 21:58 ` Mike Rapoport
2009-11-30 23:10 ` Tony Lindgren
2009-12-01 7:57 ` Mike Rapoport
2009-11-29 8:07 ` [PATCH] omap3: cm-t35: add mux initialization Mike Rapoport
2009-12-06 15:31 ` Mike Rapoport
2009-12-07 16:22 ` Tony Lindgren
2009-12-07 16:35 ` Gadiyar, Anand
2009-12-07 17:44 ` Tony Lindgren
2009-12-08 10:40 ` Mike Rapoport
2009-12-09 6:49 ` [PATCH v2] " Mike Rapoport
2009-12-09 13:27 ` [PATCH] omap3: cm-t35: add mux initialization (was: Re: [PATCH] omap3: cm-t35: add mux initialization) Mike Rapoport
2009-12-09 16:36 ` Tony Lindgren
2009-12-11 22:00 ` [APPLIED] [PATCH] omap3: cm-t35: add mux initialization Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130211255.GZ4348@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox