From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: felipe.balbi@nokia.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Madhusudhan Chikkature <madhu.cr@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger
Date: Thu, 3 Dec 2009 00:54:42 +0300 [thread overview]
Message-ID: <20091202215442.GA30658@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <6ed0b2680912021329g372bd0a4vb5b4a80244960f95@mail.gmail.com>
On Wed, Dec 02, 2009 at 11:29:10PM +0200, Grazvydas Ignotas wrote:
[...]
> From what I saw in other drivers they are setup to start charging
> automatically as soon as they see VBUS.
Yes. I see nothing wrong here.
> > How are you differing between those currently?
>
> Not handled at all at the moment (uses BCI defaults).
[...]
> Agree about USB userspace switch though..
Yes, so far we don't have any writable properties in power supply
class, though the feature is in demand by various drivers.
Somebody should step up and implement it. ;-)
But for the start, I like this driver the way it is.
As for the default USB VBUS current value, it could be Kconfig
option (something alike to USB_GADGET_VBUS_DRAW) and/or module
parameter, or hw default, or hardcoded for now. Either will
work.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-12-02 21:54 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 14:44 [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Grazvydas Ignotas
2009-11-27 14:54 ` Anton Vorontsov
2009-11-27 15:47 ` Grazvydas Ignotas
2009-11-27 16:23 ` Mark Brown
2009-11-30 18:45 ` Madhusudhan
2009-11-30 18:58 ` Anton Vorontsov
2009-12-02 20:38 ` Grazvydas Ignotas
2009-12-02 21:27 ` Anton Vorontsov
2009-12-02 21:32 ` Grazvydas Ignotas
2009-11-30 21:33 ` Grazvydas Ignotas
2009-12-02 16:59 ` Madhusudhan
2009-12-02 17:33 ` Felipe Balbi
2009-12-02 20:34 ` Grazvydas Ignotas
2009-12-02 20:49 ` Felipe Balbi
2009-12-02 21:29 ` Grazvydas Ignotas
2009-12-02 21:54 ` Anton Vorontsov [this message]
2009-12-02 22:31 ` Felipe Balbi
2009-12-02 22:59 ` Anton Vorontsov
2009-12-03 8:39 ` Felipe Balbi
2009-12-03 10:55 ` Grazvydas Ignotas
2009-12-03 11:03 ` Felipe Balbi
2009-12-10 14:09 ` Grazvydas Ignotas
2009-12-10 14:18 ` Anton Vorontsov
2009-12-10 14:21 ` Felipe Balbi
2009-12-10 14:44 ` Anton Vorontsov
2009-12-10 16:51 ` Felipe Balbi
2009-12-10 20:51 ` Grazvydas Ignotas
2009-12-11 11:31 ` [RFC/PATCH 1/5] usb: otg: add notifier support Felipe Balbi
[not found] ` <1260531086-23857-2-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-11 11:55 ` Mark Brown
2009-12-11 11:58 ` Felipe Balbi
2010-01-26 11:16 ` David Brownell
2010-01-26 13:11 ` Mark Brown
2010-01-26 13:35 ` David Brownell
2010-01-26 14:14 ` Felipe Balbi
2010-01-26 14:24 ` Oliver Neukum
[not found] ` <201001261524.49661.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-01-26 14:30 ` Felipe Balbi
2010-01-26 15:16 ` David Brownell
2010-01-26 15:21 ` David Brownell
2010-01-26 18:50 ` Felipe Balbi
[not found] ` <201001260535.21689.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2010-01-26 14:21 ` Mark Brown
2010-01-26 15:44 ` David Brownell
2010-01-26 16:13 ` Mark Brown
2010-01-26 14:10 ` Felipe Balbi
2010-01-26 14:19 ` Felipe Balbi
[not found] ` <20100126141935.GG10690-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-01-26 15:33 ` David Brownell
2010-01-26 15:07 ` David Brownell
2010-01-26 19:09 ` Felipe Balbi
[not found] ` <20100126190934.GC20049-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-01-26 19:15 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier Felipe Balbi
[not found] ` <1260531086-23857-3-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-11 17:22 ` sai pavan
[not found] ` <c60a9cb0912110922g10fd0cc7m3b3430731db5ed81-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-11 20:40 ` Felipe Balbi
2009-12-12 18:34 ` Mark Brown
2009-12-14 10:30 ` [RFC/PATCH 0/4] twl4030 threaded_irq support Felipe Balbi
[not found] ` <1260786654-13294-1-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-01-26 7:06 ` David Brownell
2010-01-26 7:36 ` David Brownell
2010-01-26 10:07 ` Mark Brown
2010-01-26 11:02 ` Felipe Balbi
2010-01-26 12:18 ` David Brownell
[not found] ` <20091212183410.GF3092-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-12-14 10:30 ` [RFC/PATCH 1/4] input: keyboard: twl4030: move to request_threaded_irq Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 2/4] input: misc: " Felipe Balbi
2009-12-14 11:31 ` Shilimkar, Santosh
2009-12-14 11:40 ` Felipe Balbi
2009-12-14 13:16 ` Shilimkar, Santosh
2009-12-14 10:30 ` [RFC/PATCH 4/4] usb: otg: " Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 3/4] rtc: " Felipe Balbi
[not found] ` <6ed0b2680912101251jeec28e6i216dfc51caab13aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-11 11:31 ` [RFC/PATCH 0/5] usb transceiver notifier Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 3/5] usb: musb: add support for ulpi block Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 4/5] usb: musb: isp1704: add registers from isp1704 Felipe Balbi
[not found] ` <1260531086-23857-5-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-11 12:35 ` Krogerus Heikki (EXT-Teleca/Helsinki)
2009-12-11 12:57 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 5/5] usb: musb: musb supports otg notifier Felipe Balbi
[not found] ` <1260531086-23857-6-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-11 11:40 ` Felipe Balbi
2009-12-30 19:07 ` [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Madhusudhan
2009-12-10 14:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202215442.GA30658@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox