From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Date: Thu, 3 Dec 2009 00:54:42 +0300 Message-ID: <20091202215442.GA30658@oksana.dev.rtsoft.ru> References: <1259333060-24277-1-git-send-email-notasas@gmail.com> <20091202173321.GA23738@nokia.com> <6ed0b2680912021234x6b5e6058p6d50d5cd20ecf019@mail.gmail.com> <20091202204946.GB25682@nokia.com> <6ed0b2680912021329g372bd0a4vb5b4a80244960f95@mail.gmail.com> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <6ed0b2680912021329g372bd0a4vb5b4a80244960f95@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Grazvydas Ignotas Cc: felipe.balbi@nokia.com, "linux-kernel@vger.kernel.org" , Madhusudhan Chikkature , "linux-omap@vger.kernel.org" List-Id: linux-omap@vger.kernel.org On Wed, Dec 02, 2009 at 11:29:10PM +0200, Grazvydas Ignotas wrote: [...] > From what I saw in other drivers they are setup to start charging > automatically as soon as they see VBUS. Yes. I see nothing wrong here. > > How are you differing between those currently? > > Not handled at all at the moment (uses BCI defaults). [...] > Agree about USB userspace switch though.. Yes, so far we don't have any writable properties in power supply class, though the feature is in demand by various drivers. Somebody should step up and implement it. ;-) But for the start, I like this driver the way it is. As for the default USB VBUS current value, it could be Kconfig option (something alike to USB_GADGET_VBUS_DRAW) and/or module parameter, or hw default, or hardcoded for now. Either will work. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2