Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c

Russell King - ARM Linux
2009-12-03T15:03:05Z

On Thu, Dec 03, 2009 at 05:33:44AM -0700, Paul Walmsley wrote:
> My preference was to keep data separated from code in the source files; I
> think it is slightly more readable.

It's less readable because instead of having similar stuff together, it's
at opposite ends of the file.

> The other consideration is that there are some patches in the works here
> to move all of the struct clk function pointers into the struct clkops.

Oh for gods sake, why do people take things to the extreme?

I looked into doing exactly that and decided it was a *bad* *idea* because
it stupidly multiplies the number of ops structures. Instead of having a
few well-defined and well-understood ops structures, you end up with one
ops structure per special case.

Then you're going to be back into adding all that sodding crap that you
had back before I cleaned up the enable/disable shite.

No, please don't do this, this would definitely be a total backwards step.

Please take a moment to think about the changes you're doing.