Re: [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c

Russell King
2009-12-03T10:27:07Z

On Thu, Dec 03, 2009 at 03:07:08AM -0700, Paul Walmsley wrote:
> -static int clk_omap1_dummy_enable(struct clk *clk)
> +int clk_omap1_dummy_enable(struct clk *clk)
> {
> return 0;
> }
>
> -static void clk_omap1_dummy_disable(struct clk *clk)
> +void clk_omap1_dummy_disable(struct clk *clk)
> {
> }
>
> -static const struct clkops clkops_dummy = {
> - .enable = clk_omap1_dummy_enable,
> - .disable = clk_omap1_dummy_disable,
> -};

I've no idea why you're moving the clkops into these other files - I think
this is going far too far. Why not just make the clkops structures non-
static?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/