Re: [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c

Paul Walmsley
2009-12-03T10:36:41Z

Hello Russell,

On Thu, 3 Dec 2009, Russell King wrote:

> On Thu, Dec 03, 2009 at 03:07:08AM -0700, Paul Walmsley wrote:
> > -static int clk_omap1_dummy_enable(struct clk *clk)
> > +int clk_omap1_dummy_enable(struct clk *clk)
> > {
> > return 0;
> > }
> >
> > -static void clk_omap1_dummy_disable(struct clk *clk)
> > +void clk_omap1_dummy_disable(struct clk *clk)
> > {
> > }
> >
> > -static const struct clkops clkops_dummy = {
> > - .enable = clk_omap1_dummy_enable,
> > - .disable = clk_omap1_dummy_disable,
> > -};
>
> I've no idea why you're moving the clkops into these other files - I think
> this is going far too far. Why not just make the clkops structures non-
> static?

clkops that are shared between multiple platforms, such as clkops_null,
are indeed non-static. However, many of the clkops are only used by one
OMAP variant, so it seemed pointless to make them non-static. No point in
polluting the symbol table unnecessarily. Is there some reason that all
of them should be non-static?

- Paul