public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH]OMAP3 PM: Fix for DSP Crash at OPP 1 and 2 under DVFS+SR operation
Date: Fri, 4 Dec 2009 11:06:11 -0800	[thread overview]
Message-ID: <20091204190611.GG24013@atomide.com> (raw)
In-Reply-To: <1259918576-31870-1-git-send-email-vishwanath.bs@ti.com>

* Vishwanath BS <vishwanath.bs@ti.com> [091204 01:20]:
> From: Shweta Gulati <shweta.gulati@ti.com>
> 
> DSP usage at VDD1 OPP1 and OPP2 with Smartreflex enabled and any MM UCs
> running DSP codec was earlier restricted as DSP crashed.
> The root cause is wrong DPLL1/DPLL2 Bypass clock at VDD1 OPP1 and OPP2. 
> The workaround is:
> 	For DPLL2 (DSP) select CORECLK/4 as DPLL2 bypass clock for 3430.
> 	Select CORECLK/2 as DPLL2 bypass clock for 3630.
> During DPLL2 relock phase, DSP clock will be 83MHz/200MHz which is always OK
> irrespective of Vdd1 voltage.
> For DPLL1 (MPU), prior to any DVFS transition to OPP1, select CORECLK/4
> 	(CORECLK/2 for 3630) as DPLL1 bypass clock.
> 	For other OPPs select CORECLK/2 (CORECLK/1 for 3630) as DPLL1 bypass
> 	clock.
> These configurations are typically set in bootloader. However bootloaders may 
> mess up configuration and kernel with this chang ensures that system is in a 
> known state.
> 
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> ---
>  arch/arm/mach-omap2/cm-regbits-34xx.h |    4 ++--
>  arch/arm/mach-omap2/pm34xx.c          |   19 +++++++++++++++++++
>  arch/arm/mach-omap2/resource34xx.c    |   20 ++++++++++++++++++++
>  3 files changed, 41 insertions(+), 2 deletions(-)
>  mode change 100644 => 100755 arch/arm/mach-omap2/cm-regbits-34xx.h
>  mode change 100644 => 100755 arch/arm/mach-omap2/pm34xx.c
>  mode change 100644 => 100755 arch/arm/mach-omap2/resource34xx.c

This mode change stuff does not look right.

Tony

      parent reply	other threads:[~2009-12-04 19:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04  9:22 [PATCH]OMAP3 PM: Fix for DSP Crash at OPP 1 and 2 under DVFS+SR operation Vishwanath BS
2009-12-04 10:16 ` Cousson, Benoit
2009-12-04 10:28   ` Sripathy, Vishwanath
2009-12-04 10:57     ` Cousson, Benoit
2009-12-04 11:35       ` Sripathy, Vishwanath
2009-12-04 11:46         ` Cousson, Benoit
2009-12-04 19:06 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091204190611.GG24013@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox