From: Tony Lindgren <tony@atomide.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: Mike Rapoport <mike@compulab.co.il>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap3: cm-t35: add mux initialization
Date: Mon, 7 Dec 2009 09:44:46 -0800 [thread overview]
Message-ID: <20091207174446.GY24013@atomide.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0309C863C8@dbde02.ent.ti.com>
* Gadiyar, Anand <gadiyar@ti.com> [091207 08:35]:
> Tony Lindgren wrote:
> > * Mike Rapoport <mike@compulab.co.il> [091206 07:30]:
> > > Tony,
> > > Any chance this can go to 2.6.33?
> >
> > Sure, I was just waiting to hear back if the OUTPUT_PULLUP is
> > needed for sure? Or is just OUTPUT enough for musb to work?
> >
> > Tony
> >
>
> OUTPUT should work too. The ULPI spec recommends a weak pull-up
> on STP line, but we needn't really have that. Plain OUTPUT is sufficient.
OK, thanks for checking that. Mike, what do you prefer to do?
I guess in some cases the pull may be needed for a pin
to change faster if an external pull is not used?
We could add the OUTPUT_PULL defines, but we should probably
mark them with comments that they should be rarely needed.
Regards,
Tony
next prev parent reply other threads:[~2009-12-07 17:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 8:07 [PATCH] omap3: cm-t35: add mux initialization Mike Rapoport
2009-11-29 8:07 ` [PATCH] omap3: mux: add shorthands for OUTPUT_PULL{UP,DOWN} Mike Rapoport
2009-11-30 21:12 ` Tony Lindgren
2009-11-30 21:58 ` Mike Rapoport
2009-11-30 23:10 ` Tony Lindgren
2009-12-01 7:57 ` Mike Rapoport
2009-11-29 8:07 ` [PATCH] omap3: cm-t35: add mux initialization Mike Rapoport
2009-12-06 15:31 ` Mike Rapoport
2009-12-07 16:22 ` Tony Lindgren
2009-12-07 16:35 ` Gadiyar, Anand
2009-12-07 17:44 ` Tony Lindgren [this message]
2009-12-08 10:40 ` Mike Rapoport
2009-12-09 6:49 ` [PATCH v2] " Mike Rapoport
2009-12-09 13:27 ` [PATCH] omap3: cm-t35: add mux initialization (was: Re: [PATCH] omap3: cm-t35: add mux initialization) Mike Rapoport
2009-12-09 16:36 ` Tony Lindgren
2009-12-11 22:00 ` [APPLIED] [PATCH] omap3: cm-t35: add mux initialization Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207174446.GY24013@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox