public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>
Subject: Re: [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
Date: Mon, 7 Dec 2009 13:34:11 -0800	[thread overview]
Message-ID: <20091207213411.GJ24013@atomide.com> (raw)
In-Reply-To: <200912071538.06968.peter.ujfalusi@nokia.com>

* Peter Ujfalusi <peter.ujfalusi@nokia.com> [091207 05:37]:
> Hello Tony, Kevin,
> 
> On Thursday 26 November 2009 15:18:50 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> > Wake-up from McBSP ports are needed, especially when the THRESHOLD
> > dma mode is in use for audio playback.
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> > ---
> >  arch/arm/mach-omap2/pm34xx.c |    8 ++++++--
> >  1 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> > index 81ed252..6b17647 100644
> > --- a/arch/arm/mach-omap2/pm34xx.c
> > +++ b/arch/arm/mach-omap2/pm34xx.c
> > @@ -878,12 +878,16 @@ static void __init prcm_setup_regs(void)
> >  	/* Enable wakeups in PER */
> >  	prm_write_mod_reg(OMAP3430_EN_GPIO2 | OMAP3430_EN_GPIO3 |
> >  			  OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
> > -			  OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3,
> > +			  OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
> > +			  OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> > +			  OMAP3430_EN_MCBSP4,
> >  			  OMAP3430_PER_MOD, PM_WKEN);
> >  	/* and allow them to wake up MPU */
> >  	prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
> >  			  OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
> > -			  OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3,
> > +			  OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
> > +			  OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> > +			  OMAP3430_EN_MCBSP4,
> >  			  OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
> > 
> >  	/* Don't attach IVA interrupts */
> > 
> 
> Have you had time to take a look at this patch?

Makes sense to me, let's let Kevin queue it up.

Tony

  reply	other threads:[~2009-12-07 21:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26 13:18 [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
2009-12-07 13:38 ` Peter Ujfalusi
2009-12-07 21:34   ` Tony Lindgren [this message]
2009-12-09 23:38 ` Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2010-03-03 13:08 [PATCHv2 0/5] FIFO caused playback delay (latency) handling in soc/omap Peter Ujfalusi
2010-03-03 13:08 ` [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
2010-03-03 14:08   ` Peter Ujfalusi
2010-03-03 14:46   ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207213411.GJ24013@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox