commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

[Felipe Balbi]

Hi,

the patch renaming twl4030 to twl broke compilation of several omap 
boards.

Here are all the files including a file that doesn't exist anymore:

arch/arm/mach-omap2/board-cm-t35.c:#include <linux/i2c/twl4030.h>
arch/arm/mach-omap2/board-igep0020.c:#include <linux/i2c/twl4030.h>
arch/arm/mach-omap2/board-omap3evm.c:#include <linux/i2c/twl4030.h>
arch/arm/mach-omap2/board-omap3touchbook.c:#include <linux/i2c/twl4030.h>
arch/arm/mach-omap2/board-rx51-peripherals.c:#include <linux/i2c/twl4030.h>
arch/arm/mach-omap2/board-zoom-peripherals.c:#include <linux/i2c/twl4030.h>
drivers/mfd/twl4030-codec.c:#include <linux/i2c/twl4030.h>
drivers/video/omap/lcd_ldp.c:#include <linux/i2c/twl4030.h>
drivers/video/omap/lcd_omap2evm.c:#include <linux/i2c/twl4030.h>
drivers/video/omap/lcd_omap3beagle.c:#include <linux/i2c/twl4030.h>
drivers/video/omap/lcd_omap3evm.c:#include <linux/i2c/twl4030.h>
drivers/video/omap/lcd_overo.c:#include <linux/i2c/twl4030.h>
sound/soc/omap/sdp3430.c:#include <linux/i2c/twl4030.h>

-- 
balbi

RE: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

[Krishnamoorthy, Balaji T]

> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> Sent: Tuesday, December 15, 2009 5:28 PM
> To: Linux OMAP Mailing List
> Cc: Krishnamoorthy, Balaji T
> Subject: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation
> 
> Hi,
> 
> the patch renaming twl4030 to twl broke compilation of several omap
> boards.
> 
> Here are all the files including a file that doesn't exist anymore:
> 
Thanks Felipe,
I am preparing a patch for this.

Thanks and Regards,
Balaji T K
> --
> balbi

Re: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

[Felipe Balbi]

On Tue, Dec 15, 2009 at 01:05:01PM +0100, ext Krishnamoorthy, Balaji T wrote:
>> -----Original Message-----
>> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
>> Sent: Tuesday, December 15, 2009 5:28 PM
>> To: Linux OMAP Mailing List
>> Cc: Krishnamoorthy, Balaji T
>> Subject: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation
>>
>> Hi,
>>
>> the patch renaming twl4030 to twl broke compilation of several omap
>> boards.
>>
>> Here are all the files including a file that doesn't exist anymore:
>>
>Thanks Felipe,
>I am preparing a patch for this.

please, compile test with all omap3 defconfigs to be sure.

something like:

for i in `ls arch/arm/configs | grep omap | grep -v 'omap-l137'`; do
	make CROSS_COMPILE=arm-linux- ARCH=arm $i defconfig;
	make CROSS_COMPILE=arm-linux- ARCH=arm;
done

this won't get rx51_defconfig or n8x0_deconfig nor n770_defconfig, but 
it's good enough. rx51_defconfig is the only of those three that twl4030 
anyways.

-- 
balbi